audrius/web
1
0
Fork 1
mirror of https://github.com/OCA/web.git synced 2025-02-22 13:21:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

web_widget_x2many_2d_matrix: Fix show_column_totals option

Browse Source 
Commit a5e6acc3 introduced a bug, where show_column_totals="0" wouldn't work.
This is because JS ternary operator took node's attribute value as part of the condition.

As an example simplified JS code (before change):
`'0' || true ? '1' : ''` -> `'1'`
And this is what was probably meant originally (after change)
`'0' || (true ? '1' : '')` -> `'0'`
This commit is contained in:
gaikaz
2020-06-17 18:14:11 +03:00
parent e528c12926
commit 74559098b4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web_widget_x2many_2d_matrix/static/src/js/widget_x2many_2d_matrix.js
View File

@@ -68,11 +68,11 @@ odoo.define('web_widget_x2many_2d_matrix.widget', function (require) {
}
this.show_row_totals = this.parse_boolean(
node.show_row_totals ||
this.is_aggregatable(field_defs[this.field_value]) ? '1' : ''
(this.is_aggregatable(field_defs[this.field_value]) ? '1' : '')
);
this.show_column_totals = this.parse_boolean(
node.show_column_totals ||
this.is_aggregatable(field_defs[this.field_value]) ? '1' : ''
(this.is_aggregatable(field_defs[this.field_value]) ? '1' : '')
);
},