[IMP] hr_commission: Remove implicit requirement on sale

hr_commission/__manifest__.py

@@ -9,6 +9,7 @@
     'website': 'https://hibou.io/',
     'depends': [
         # 'account_invoice_margin',  # optional
+        'hibou_professional',
         'hr_contract',
     ],
     'data': [

hr_commission/models/account.py

@@ -24,8 +24,8 @@ class AccountMove(models.Model):
             'context': {'search_default_source_move_id': self[0].id}
         }
 
-    def action_post(self):
+    def post(self):
-        res = super(AccountMove, self).action_post()
+        res = super(AccountMove, self).post()
         invoices = self.filtered(lambda m: m.is_invoice())
         if invoices:
             self.env['hr.commission'].invoice_validated(invoices)

hr_commission/tests/test_commission.py

@@ -4,6 +4,7 @@ from odoo.tests import common
 
 
 class TestCommission(common.TransactionCase):
+    # TODO refactor tests to not require sale.order
 
     def setUp(self):
         super().setUp()

hr_commission/views/commission_views.xml

@@ -118,15 +118,15 @@
 
     <menuitem
         action="action_hr_commission"
-        id="menu_action_sales_commission_form"
+        id="menu_action_account_commission_root"
-        parent="sale.sale_menu_root"
+        parent="account.menu_finance_receivables"
         sequence="5"
         />
 
     <menuitem
         action="action_hr_commission"
-        id="menu_action_sales_commission_form2"
+        id="menu_action_account_commission_form"
-        parent="menu_action_sales_commission_form"
+        parent="menu_action_account_commission_root"
         sequence="5"
         />
 
@@ -223,8 +223,8 @@ action = records.action_mark_paid()
 
     <menuitem
         action="action_hr_commission_payment"
-        id="menu_action_sales_commission_payment_form"
+        id="menu_action_account_commission_payment_form"
-        parent="menu_action_sales_commission_form"
+        parent="menu_action_account_commission_root"
         sequence="10"
         />