From fa1f940bc43e5e6e2fd7a5c3dd8e4a3413ceff3c Mon Sep 17 00:00:00 2001
From: Jared Kipe <jared@hibou.io>
Date: Wed, 30 Sep 2020 09:40:02 -0700
Subject: [PATCH] [IMP] hr_commission: Remove implicit requirement on `sale`

---
 hr_commission/__manifest__.py            |  1 +
 hr_commission/models/account.py          |  4 ++--
 hr_commission/tests/test_commission.py   |  1 +
 hr_commission/views/commission_views.xml | 12 ++++++------
 4 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/hr_commission/__manifest__.py b/hr_commission/__manifest__.py
index 52e7d5d7..dabe560a 100644
--- a/hr_commission/__manifest__.py
+++ b/hr_commission/__manifest__.py
@@ -9,6 +9,7 @@
     'website': 'https://hibou.io/',
     'depends': [
         # 'account_invoice_margin',  # optional
+        'hibou_professional',
         'hr_contract',
     ],
     'data': [
diff --git a/hr_commission/models/account.py b/hr_commission/models/account.py
index 9fc6c166..819c69d3 100644
--- a/hr_commission/models/account.py
+++ b/hr_commission/models/account.py
@@ -24,8 +24,8 @@ class AccountMove(models.Model):
             'context': {'search_default_source_move_id': self[0].id}
         }
 
-    def action_post(self):
-        res = super(AccountMove, self).action_post()
+    def post(self):
+        res = super(AccountMove, self).post()
         invoices = self.filtered(lambda m: m.is_invoice())
         if invoices:
             self.env['hr.commission'].invoice_validated(invoices)
diff --git a/hr_commission/tests/test_commission.py b/hr_commission/tests/test_commission.py
index 688513d1..0ccdfbe1 100644
--- a/hr_commission/tests/test_commission.py
+++ b/hr_commission/tests/test_commission.py
@@ -4,6 +4,7 @@ from odoo.tests import common
 
 
 class TestCommission(common.TransactionCase):
+    # TODO refactor tests to not require sale.order
 
     def setUp(self):
         super().setUp()
diff --git a/hr_commission/views/commission_views.xml b/hr_commission/views/commission_views.xml
index 0e99a965..887cbbe8 100644
--- a/hr_commission/views/commission_views.xml
+++ b/hr_commission/views/commission_views.xml
@@ -118,15 +118,15 @@
 
     <menuitem
         action="action_hr_commission"
-        id="menu_action_sales_commission_form"
-        parent="sale.sale_menu_root"
+        id="menu_action_account_commission_root"
+        parent="account.menu_finance_receivables"
         sequence="5"
         />
 
     <menuitem
         action="action_hr_commission"
-        id="menu_action_sales_commission_form2"
-        parent="menu_action_sales_commission_form"
+        id="menu_action_account_commission_form"
+        parent="menu_action_account_commission_root"
         sequence="5"
         />
 
@@ -223,8 +223,8 @@ action = records.action_mark_paid()
 
     <menuitem
         action="action_hr_commission_payment"
-        id="menu_action_sales_commission_payment_form"
-        parent="menu_action_sales_commission_form"
+        id="menu_action_account_commission_payment_form"
+        parent="menu_action_account_commission_root"
         sequence="10"
         />