[MIG] hr_expense_recruitment: to 16

hr_expense_recruitment/__manifest__.py

@@ -1,6 +1,6 @@
 {
     'name': 'HR Expense Recruitment',
-    'version': '12.0.1.0.0',
+    'version': '16.0.1.0.0',
     'author': 'Hibou Corp. <hello@hibou.io>',
     'category': 'Human Resources',
     'summary': 'Assign Recruitment to expenses for reporting.',

hr_expense_recruitment/models/hr_job.py

@@ -11,7 +11,6 @@ class HRJob(models.Model):
                                         compute_sudo=True)
     expense_ids = fields.One2many('hr.expense', 'job_id', string='Expenses')
 
-    @api.multi
     @api.depends('expense_ids.total_amount')
     def _compute_expense_total_amount(self):
         for job in self:

hr_expense_recruitment/tests/test_expenses.py

@@ -1,15 +1,24 @@
-from odoo.tests import common
+from odoo.addons.hr_expense.tests.common import TestExpenseCommon
+from odoo.tests import tagged, Form
 
 
-class TestJobExpense(common.TransactionCase):
+
+@tagged('-at_install', 'post_install')
+class TestJobExpense(TestExpenseCommon):
     def test_fields(self):
+        
+        employee = self.env['hr.employee'].create({
+            'name': 'Leo Pinedo',
+        })
         job = self.env['hr.job'].create({'name': 'Test Job'})
         expense = self.env['hr.expense'].create({
             'name': 'Test Expense',
-            'employee_id': self.env['hr.employee'].search([], limit=1).id,
-            'product_id': self.env['product.product'].search([('can_be_expensed', '=', True)], limit=1).id,
+            'employee_id': self.expense_employee.id,
+            'product_id': self.product_a.id,
             'unit_amount': 34.0,
         })
+        self.assertTrue(job)
+        self.assertTrue(expense)
         self.assertFalse(job.expense_ids)
         self.assertEqual(job.expense_total_amount, 0.0)
         expense.job_id = job

hr_expense_recruitment/views/hr_expense_views.xml

@@ -14,9 +14,9 @@
     <record id="view_hr_expense_filter_inherit" model="ir.ui.view">
         <field name="name">hr.expense.filter.inherit</field>
         <field name="model">hr.expense</field>
-        <field name="inherit_id" ref="hr_expense.view_hr_expense_filter"/>
+        <field name="inherit_id" ref="hr_expense.hr_expense_view_search"/>
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='product_id']" position="after">
+            <xpath expr="//field[@name='employee_id']" position="after">
                 <field name="job_id"/>
             </xpath>
         </field>