mirror of
https://github.com/ForgeFlow/stock-rma.git
synced 2025-01-21 12:57:49 +02:00
[FIX] rma_sale: Ensure that configuration on the operation is applied
Without this, some policies are not being copied from the operation selected when creating new rma line from a rma group. In v16 this patch and the usage of such onchange can be removed in favor of (pre)computed stored editable fields for all policies and configuration in the RMA operation.
This commit is contained in:
committed by
Jordi Ballester Alomar
parent
998578ed52
commit
89c5eb1e18
@@ -175,7 +175,12 @@ class RmaAddSale(models.TransientModel):
|
||||
if line not in existing_sale_lines or tracking_move:
|
||||
if not tracking_move:
|
||||
data = self._prepare_rma_line_from_sale_order_line(line)
|
||||
rma_line_obj.create(data)
|
||||
rec = rma_line_obj.create(data)
|
||||
# Ensure that configuration on the operation is applied
|
||||
# TODO MIG: in v16 the usage of such onchange can be removed in
|
||||
# favor of (pre)computed stored editable fields for all policies
|
||||
# and configuration in the RMA operation.
|
||||
rec._onchange_operation_id()
|
||||
else:
|
||||
for lot in line.mapped("move_ids.move_line_ids.lot_id").filtered(
|
||||
lambda x: x.id in self.lot_ids.ids
|
||||
@@ -183,7 +188,12 @@ class RmaAddSale(models.TransientModel):
|
||||
if lot.id in self.rma_id.rma_line_ids.mapped("lot_id").ids:
|
||||
continue
|
||||
data = self._prepare_rma_line_from_sale_order_line(line, lot)
|
||||
rma_line_obj.create(data)
|
||||
rec = rma_line_obj.create(data)
|
||||
# Ensure that configuration on the operation is applied
|
||||
# TODO MIG: in v16 the usage of such onchange can be removed in
|
||||
# favor of (pre)computed stored editable fields for all policies
|
||||
# and configuration in the RMA operation.
|
||||
rec._onchange_operation_id()
|
||||
rma = self.rma_id
|
||||
data_rma = self._get_rma_data()
|
||||
rma.write(data_rma)
|
||||
|
||||
Reference in New Issue
Block a user