Commit Graph

44 Commits

Author SHA1 Message Date
OCA-git-bot
bcb23f11b2 stock_vertical_lift 14.0.1.1.1 2021-12-10 13:05:29 +00:00
Florent Xicluna
1a446ffbcf [FIX] adapt syntax for act_window lookup 2021-12-09 13:41:34 +01:00
OCA-git-bot
71b3ad711c stock_vertical_lift 14.0.1.1.0 2021-12-02 09:34:12 +00:00
Hai Lang
73b1c95adc [IMP] stock_vertical_lift: increase coverage 2021-11-22 19:37:04 +07:00
Telmo Santos
53eacf9af3 [13] Fix stock_vertical_lift skip screen
Fix unit tests

fixup! [13] Fix stock_vertical_lift skip screen

Rename variable to current_move_line

fixup! Rename variable to current_move_line
2021-11-22 19:36:16 +07:00
Carlos Serra-Toro
f7e7c8fbf0 [ADD] stock_vertical_lift_empty_tray_check: is the tray empty?
A vertical lift retrieves a tray and places it in front of the
user, and depending on the quantity the user takes from it,
it adapts the pending quantity in the tray. However, because of
errors, it could be that the system thinks the tray is empty
while it is not. With this module, when the system thinks the
tray is empty, while in the step for the release of the tray
the operator is asked explicitly to check if the tray is
actually empty. Depending on his/her answer (yes/no) an inventory
adjustment is created stating the situation.

To activate this optional feature, a new configuration setting
has been added to Inventory > Configuration > Settings, named
'Check Empty Tray'. It is deactivated by default.

Developing decisions:
- The screens shown to the operator are actually wizards, but
  since in the original module (`stock_vertical_lift`) they
  were considered (on the source tree) as views, this has been
  continued here.
- It has been decided, to not change the current workflow of
  the operators, to embed the new check inside the step for
  the 'release'. So, a new screen is shown to ask for the
  visual inspection of whether the tray is empty. In
  order to test this easily, the method `button_release` of
  the module `stock_vertical_lift` has been slightly modified
  so that it always returns. This way we can check easily
  in the unit-tests for the outcome of the intermediate
  screen (i.e. wizard) ─ similarly to how it is done when
  validating a picking that can result in a backorder.
2021-11-22 19:36:16 +07:00
oca-travis
261fac2c87 [UPD] Update stock_vertical_lift.pot 2021-09-17 13:25:12 +00:00
dzung.tran
80d93bffbc [MIG] stock_vertical_lift: Migration to 14.0 2021-09-17 07:47:34 +07:00
dzung.tran
6938b2e269 [IMP] stock_vertical_lift: black, isort, prettier 2021-09-16 20:17:34 +07:00
Carlos Serra-Toro
f092b86092 [FIX] stock_vertical_lift: skip button is only for pick operation
The button to skip an operation is only implemented for the pick
operation (not for the put or for the inventory ones) but it was
shown in the screens for all the operations, yielding to a stack
trace when it was pressed from the wrong operationg. The button
has been moved now to the screen for the pick operation, only.
2021-09-16 20:17:34 +07:00
Carlos Serra-Toro
e1e417b5f7 [IMP] stock_vertical_lift: Add skip operation to vertical lift shuttles
In the screen for the vertical lift shuttles, accessible through
Inventory > Operations > Vertical Lift Shuttles, a new button has been
added to allow to skip an operation. This button can also be triggered
by scanning the barcode O-BTN.skip.svg that is inside the folder
'images'.

When a skip is done, the next stock.move.line to pick is chosen and
shown to the operator. A skipped move line is added to the end of the
list of pending move lines to be picked, so they will be shown again
in the future as soon as the other move lines have been successfully
processed.

This option was added because, sometimes, the operator can not process
a move line for whatever reason. Right now, the only way of proceeding
is to wait until he/she can effectively process it, which involves a
delay in the operations. With this new skip operation, the operator
can continue processing the rest of move lines.
2021-09-16 20:17:34 +07:00
Guewen Baconnier
42d7106315 Revert "[13.0][FIX] stock_vertical_lift: Error in tests" 2021-09-16 20:17:33 +07:00
Sébastien Alix
ff4d9bbfad [FIX] stock_vertical_lift: handles multiple move lines on pick
If there is two move lines for the same product in the vertical lift
(stored in2 differents trays for instance), the pick scenario was
failing when the user was processing the first line.

To circumvent this, instead of validating directly the move, we put the line
in its own stock move, then we put the stock move in its own transfer and
validate this one.

Methods used to do that have been copied from the `shopfloor` module,
they probably deserves their own module as they are quite generic.
2021-09-16 20:17:33 +07:00
Víctor Martínez
a2476efdaa [FIX] stock_vertical_lift: Error in tests 2021-09-16 20:17:33 +07:00
Guewen Baconnier
8fb6930ed5 Improve put-away release in vertical lift
If we have several goods to put in the same tray, it is inefficient to
release (close) the tray between each line if we reopen the same tray.
Release the tray only when the last line is reached.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
4306b8db4a inventory: always fetch tray
The check was means as an optimization: no need to fetch at tray already
open. But "fetch_tray" will not only open the tray, it may also move the
laser on the exact position. So  we should do it for every inventory line.
2021-09-16 20:17:33 +07:00
Simone Orsi
60ab3f72a1 stock_vertical_lift: change x/y tray order 2021-09-16 20:17:33 +07:00
Simone Orsi
457ee74690 stock_vertical_lift: make pkg compute more solid (#16)
* stock_vertical_lift: make pkg compute more solid

Somehow sometimes you can get a move line without product
while computing product packaging in inventory.

Make it more defensive and skip packaging rendering if no product is
there.
2021-09-16 20:17:33 +07:00
Simone Orsi
6a702b30bb stock_vertical_lift: packaging template more flexible
As the template is not used by JS we can pass full objects to it.
This way we can use any recordset information directly in the template
without having to override the method.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
59952bf8c4 Prevent crash if 2 packages have the same name 2021-09-16 20:17:33 +07:00
Guewen Baconnier
c58d60a26d Add release (close) of vertical lift trays
* Rename methods that fetch a tray to prevent confusion
* Add methods to release a tray
* The Kardex method to fetch a tray has to send "0" in the carrier and
  carrierNext field
* The pick and inventory screens release the tray only when there is no next
  line, because the release is implicit when we fetch the next line,
  the put screen releases everytime because the operator may take time
  to start the next line and we don't know if they are going to scan a
  next line or not.
* Exiting the screen or switching screen between put/pick/put-away has
  to release the tray as well.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
b878102ca2 Putaway: show rainbow man when all the lines are putaway 2021-09-16 20:17:33 +07:00
Guewen Baconnier
3eaf69cc48 Extract methods to allow more precise overrides 2021-09-16 20:17:33 +07:00
Guewen Baconnier
f2553e0fc3 Allow changing a putaway tray type after assigned
When the shuttle screen propose a tray based on a tray type and we
are in the 'save' step, where we are supposed to physically putaway
the good and save, we should still be able to change the tray type
to fetch another tray.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
abdde7cbf5 Add stock_vertical_lift_storage_type
Compatibility module between stock_vertical_lift and stock_storage_type
(in OCA/wms).

In the vertical lift's Putaway screen, when a good is scanned for a putaway, the
user has to scan the tray type of the corresponding size, so an empty place in a
matching tray is found. When we use storage types, we should know what tray is
compatible with the storage type.

Changes with this module:

* The storage types of trays cannot be selected in the locations form, they have
  to be set in the Tray types.
* In the lift put-away screen, when a package has a storage type, the user isn't
  asked to scan a tray type, instead, the putaway of the Package Storage Type is
  applied.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
7d78e8b540 Rework workflows using a small state machine
The documentation of the state machine is in
VerticalLiftOperationBase._transitions.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
d1b7a6f47c Execute the barcode scanner method as side-effect method
Instead of going through the onchange machinery.
The intended usage of onchange methods is to update something on the
screen, without side-effects in the database, then let the user save
the form with the proposed changes.

Weirdly, the barcode scanner event triggers an onchange on the field
`_barcode_scanned`.

It doesn't work well with our use case, as the whole form is read-only
and we only care about having the barcode events doing side-effects on
the backend and displaying back the changes.

This particular onchange will then be executed as a normal method, with
side-effects. However, contrarily to other actions on the form, the
frontend does not reload the view after an onchange, as it relies on the
data returned back in the values. As we cannot know which values may
have been changed in the different implementations (location
destination, state, ...), the onchange returns a read with every field.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
5fb25caed4 Fix issues in Pick mode
* The change of destination location was not updated on the screen when
  the barcode was scanned (it was when the "manual barcode wizard" is
  used though)
* We should be able to pick partially available move lines
* prevent to scan a location when no move line is selected or the move
  line has already been set to done
2021-09-16 20:17:33 +07:00
Alexandre Fayolle
b3ffc206ce [FIX] command key must be a string
not a list
2021-09-16 20:17:33 +07:00
Guewen Baconnier
98988078d5 run pre-commit with new prettiers 2021-09-16 20:17:33 +07:00
Guewen Baconnier
9ae58438ad Replace custom js by 'target': 'main' 2021-09-16 20:17:33 +07:00
Guewen Baconnier
439d2bc72c [MIG] stock_vertical_lift{,_kardex}: Migration to 13.0 2021-09-16 20:17:33 +07:00
Guewen Baconnier
d9cbd996b0 [IMP] stock_vertical_lift: black, isort 2021-09-16 20:17:33 +07:00
Alexandre Fayolle
68e10cd503 [IMP] add a proxy to communicate with the kardex server 2021-09-16 20:17:33 +07:00
Guewen Baconnier
cf5848c2c3 Add method to refresh a shuttle screen
Example of usage in an odoo shell, when a screen is open:

>>> self.env['vertical.lift.shuttle'].browse(1)._operation_for_mode().operation_descr = 'foo'
>>> self.env['vertical.lift.shuttle'].browse(1)._send_notification_refresh()
>>> env.cr.commit()

Provided the longpolling is correctly configured with a proxy, the
screen should immediately refresh with 'foo' as operation description.
2021-09-16 20:17:33 +07:00
Alexandre Fayolle
06fa3da67f [IMP] abstract communication with shuttle 2021-09-16 20:17:33 +07:00
Guewen Baconnier
084c86b356 Add button on locations to fetch the tray 2021-09-16 20:17:33 +07:00
Guewen Baconnier
d9d0dc8d63 Fix 'fetch' buttons on move lines
There is no such action as 'ir.actions.do_nothing', it kinda works,
until you look into the js console and stares at the errors.

There is a nice OCA module that serves this purpose (more or less,
because it reloads the window, this is not an issue).
2021-09-16 20:17:33 +07:00
Guewen Baconnier
abb323ce89 Implement inventory screen 2021-09-16 20:17:33 +07:00
Guewen Baconnier
fcd1c6b766 Add Put-Away workflow 2021-09-16 20:17:33 +07:00
Guewen Baconnier
7d582b450f Add default views to re-open the screen views properly
When we refresh the page on the browser when we are using the "screen"
view, odoo loses the information that we want the view to be headless,
fullscreen, etc. so it's displayed pretty badly.  This view is a
work-around: its priority is lower, so it will be picked up by default
on loading, and a button allows to re-open the screen view with the
proper options.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
4d3ce20810 Split the shuttle operations in different models/views
Namely, the pick/put/inventory operations are now split in
different models.

Pick and Put share a model and customize their behavior, which is pretty
similar. The inventory operation will have a different view and
different workflow.

This changes will ease a lot the customization of the different
workflows and views.
2021-09-16 20:17:33 +07:00
Guewen Baconnier
4e00019c7d Add method on location to fetch a tray
* Add vertical_lift_shuttle_id field on stock.location, help to find the
shuttle for a location
* Add StockLocation.fetch_vertical_lift_tray(), that needs to be
implemented in addons to send commands to the hardward to fetch a tray,
and if existing show a cell (laser pointer, ...)
* Add helpers on stock.move.line fetch_vertical_lift_tray_source() and
fetch_vertical_lift_tray_dest() that fetch the tray directly from a move
line's source or destination location
2021-09-16 20:17:33 +07:00
Guewen Baconnier
fc52390b14 Add stock_vertical_lift module 2021-09-16 20:17:33 +07:00