audrius/stock-logistics-warehouse
1
0
Fork 1
mirror of https://github.com/OCA/stock-logistics-warehouse.git synced 2025-01-21 14:27:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

stock_vertical_lift: make pkg compute more solid (#16)

Browse Source 
* stock_vertical_lift: make pkg compute more solid

Somehow sometimes you can get a move line without product
while computing product packaging in inventory.

Make it more defensive and skip packaging rendering if no product is
there.
This commit is contained in:
Simone Orsi
2020-09-03 13:09:10 +02:00
committed by Hai Lang
parent 6a702b30bb
commit 457ee74690
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
stock_vertical_lift/models/vertical_lift_operation_base.py
View File

@@ -229,6 +229,8 @@ class VerticalLiftOperationBase(models.AbstractModel):
self.next_step()
def _render_product_packagings(self, product):
if not product:
return ""
return self.env["ir.qweb"].render(
"stock_vertical_lift.packagings",
self._prepare_values_for_product_packaging(product),
@@ -343,10 +345,10 @@ class VerticalLiftOperationTransfer(models.AbstractModel):
@api.depends("current_move_line_id.product_id.packaging_ids")
def _compute_product_packagings(self):
for record in self:
if not record.current_move_line_id:
product = record.current_move_line_id.product_id
if not product:
record.product_packagings = ""
continue
product = record.current_move_line_id.product_id
content = self._render_product_packagings(product)
record.product_packagings = content

4
stock_vertical_lift/models/vertical_lift_operation_inventory.py
View File

@@ -143,10 +143,10 @@ class VerticalLiftOperationInventory(models.Model):
@api.depends("current_inventory_line_id.product_id.packaging_ids")
def _compute_product_packagings(self):
for record in self:
if not record.current_inventory_line_id:
product = record.current_inventory_line_id.product_id
if not product:
record.product_packagings = ""
continue
product = record.current_inventory_line_id.product_id
content = self._render_product_packagings(product)
record.product_packagings = content