audrius/stock-logistics-warehouse
1
0
Fork 1
mirror of https://github.com/OCA/stock-logistics-warehouse.git synced 2025-01-21 14:27:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] stock_inventory_lockdown: refactor in order to block movement in stock.move.line confirmation

Browse Source
This commit is contained in:
Joan Sisquella
2024-09-17 17:13:22 +02:00
committed by ArnauCForgeFlow
parent afbc8e106a
commit 9462014342
4 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
stock_inventory_lockdown/models/__init__.py
View File

@@ -1,3 +1,3 @@
from . import stock_move
from . import stock_move_line
from . import stock_inventory
from . import stock_location

2
stock_inventory_lockdown/models/stock_inventory.py
View File

@@ -11,7 +11,6 @@ class StockInventory(models.Model):
@api.model
def _get_locations_open_inventories(self, locations_ids=None):
"""IDs of locations in open exhaustive inventories, with children"""
inventory_domain = [("state", "=", "in_progress")]
if locations_ids:
inventory_domain.append(("location_ids", "child_of", locations_ids))
@@ -20,7 +19,6 @@ class StockInventory(models.Model):
# Early exit if no match found
return []
location_ids = inventories.mapped("location_ids")
# Extend to the children Locations
location_domain = [
"|",

4
stock_inventory_lockdown/models/stock_location.py
View File

@@ -6,13 +6,10 @@ from odoo.exceptions import ValidationError
class StockLocation(models.Model):
"""Refuse changes during exhaustive Inventories"""
_inherit = "stock.location"
@api.constrains("location_id")
def _check_inventory_location_id(self):
"""Error if an inventory is being conducted here"""
vals = set(self.ids) | set(self.mapped("location_id").ids)
location_inventory_open_ids = self.env[
"stock.inventory"
@@ -21,7 +18,6 @@ class StockLocation(models.Model):
raise ValidationError(_("An inventory is being conducted at this location"))
def unlink(self):
"""Refuse unlink if an inventory is being conducted"""
location_inventory_open_ids = (
self.env["stock.inventory"].sudo()._get_locations_open_inventories(self.ids)
)

27
stock_inventory_lockdown/models/stock_move.py → stock_inventory_lockdown/models/stock_move_line.py
View File

@@ -7,8 +7,8 @@ from odoo import _, api, models
from odoo.exceptions import ValidationError
class StockMove(models.Model):
_inherit = "stock.move"
class StockMoveLine(models.Model):
_inherit = "stock.move.line"
def _get_reserved_locations(self):
self.ensure_one()
@@ -20,33 +20,34 @@ class StockMove(models.Model):
@api.constrains("location_dest_id", "location_id", "state")
def _check_locked_location(self):
for move in self.filtered(lambda m: m.state != "draft"):
for move_line in self.filtered(lambda m: m.state == "done"):
locked_location_ids = self.env[
"stock.inventory"
]._get_locations_open_inventories(
[move.location_dest_id.id, move.location_id.id]
[move_line.location_dest_id.id, move_line.location_id.id]
)
reserved_locs = move._get_reserved_locations()
dest_locs = move._get_dest_locations()
reserved_origin_loc = move_line.location_id
dest_loc = move_line.location_dest_id
if (
locked_location_ids
and not any(
[
move.location_dest_id.usage == "inventory",
move.location_id.usage == "inventory",
move_line.location_dest_id.usage == "inventory",
move_line.location_id.usage == "inventory",
]
)
and (
move.location_dest_id in locked_location_ids
or any([loc in locked_location_ids for loc in dest_locs])
or any([loc in locked_location_ids for loc in reserved_locs])
reserved_origin_loc in locked_location_ids
or dest_loc in locked_location_ids
)
):
location_names = locked_location_ids.mapped("complete_name")
raise ValidationError(
_(
"An inventory is being conducted at the following "
"location(s):\n - %s"
"Inventory adjusment underway at "
"the following location(s):\n- %s\n"
"Moving products to or from these locations is "
"not allowed until the inventory check is complete."
)
% "\n - ".join(location_names)
)