Merge PR #1177 into 13.0

Signed-off-by LoisRForgeFlow

setup/stock_account_inventory_discrepancy/odoo/addons/stock_account_inventory_discrepancy

@@ -0,0 +1 @@
+../../../../stock_account_inventory_discrepancy

setup/stock_account_inventory_discrepancy/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)

stock_account_inventory_discrepancy/README.rst

@@ -0,0 +1,85 @@
+===================================
+Stock Account Inventory Discrepancy
+===================================
+
+.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github
+    :target: https://github.com/OCA/stock-logistics-warehouse/tree/12.0/stock_account_inventory_discrepancy
+    :alt: OCA/stock-logistics-warehouse
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_account_inventory_discrepancy
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
+    :target: https://runbot.odoo-community.org/runbot/153/12.0
+    :alt: Try me on Runbot
+
+|badge1| |badge2| |badge3| |badge4| |badge5| 
+
+Extends `stock_inventory_discrepancy` module to also consider cost
+discrepancies. In other words, this module adds the capability to show the
+cost discrepancy of every line in an inventory adjustment and to block the
+inventory adjustment validation (setting it as 'Pending to Approve') when
+the discrepancy is greater than an user defined amount threshold.
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Configuration
+=============
+
+#. Go to "Inventory > Warehouse Management" > Warehouses" or to "Inventory >
+   Warehouse Management" > Locations".
+#. Modify the "Maximum Discrepancy Amount Threshold" either in a Warehouse or
+   in a location. If set to 0.0 in both the threshold is disabled.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-warehouse/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_account_inventory_discrepancy%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+~~~~~~~
+
+* ForgeFlow
+
+Contributors
+~~~~~~~~~~~~
+
+* Lois Rilo <lois.rilo@forgeflow.com>
+
+Maintainers
+~~~~~~~~~~~
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/stock-logistics-warehouse <https://github.com/OCA/stock-logistics-warehouse/tree/12.0/stock_account_inventory_discrepancy>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

stock_account_inventory_discrepancy/__init__.py

@@ -0,0 +1 @@
+from . import models

stock_account_inventory_discrepancy/__manifest__.py

@@ -0,0 +1,21 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+{
+    "name": "Stock Account Inventory Discrepancy",
+    "summary": "Adds the capability to show the value discrepancy of every "
+    "line in an inventory and to block the inventory validation "
+    "when the discrepancy is over a user defined threshold.",
+    "version": "13.0.1.0.0",
+    "author": "ForgeFlow, " "Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/stock-logistics-warehouse",
+    "category": "Warehouse",
+    "depends": ["stock_inventory_discrepancy"],
+    "data": [
+        "views/stock_inventory_view.xml",
+        "views/stock_warehouse_view.xml",
+        "views/stock_location_view.xml",
+    ],
+    "license": "AGPL-3",
+    "installable": True,
+    "application": False,
+}

stock_account_inventory_discrepancy/models/__init__.py

@@ -0,0 +1,4 @@
+from . import stock_inventory_line
+from . import stock_warehouse
+from . import stock_location
+from . import stock_quant

stock_account_inventory_discrepancy/models/stock_inventory_line.py

@@ -0,0 +1,55 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import api, fields, models
+
+
+class StockInventoryLine(models.Model):
+    _inherit = "stock.inventory.line"
+
+    discrepancy_amount = fields.Monetary(
+        string="Amount Discrepancy",
+        compute="_compute_discrepancy_amount",
+        currency_field="company_currency_id",
+        help="The difference between the actual qty counted and the "
+        "theoretical quantity on hand expressed in the cost amount.",
+        digits="Product Unit of Measure",
+        default=0,
+    )
+    discrepancy_amount_threshold = fields.Monetary(
+        string="Amount Threshold",
+        currency_field="company_currency_id",
+        help="Maximum Discrepancy Amount Threshold",
+        compute="_compute_discrepancy_amount_threshold",
+    )
+    company_currency_id = fields.Many2one(
+        string="Company Currency",
+        comodel_name="res.currency",
+        related="inventory_id.company_id.currency_id",
+        readonly=False,
+    )
+
+    @api.depends("theoretical_qty", "product_qty")
+    def _compute_discrepancy_amount(self):
+        for line in self:
+            discrepancy_qty = line.product_qty - line.theoretical_qty
+            cost = line.product_id.standard_price
+            line.discrepancy_amount = discrepancy_qty * cost
+
+    def _compute_discrepancy_amount_threshold(self):
+        for line in self:
+            whs = line.location_id.get_warehouse()
+            if line.location_id.discrepancy_amount_threshold > 0.0:
+                line.discrepancy_amount_threshold = (
+                    line.location_id.discrepancy_amount_threshold
+                )
+            elif whs.discrepancy_amount_threshold > 0.0:
+                line.discrepancy_amount_threshold = whs.discrepancy_amount_threshold
+            else:
+                line.discrepancy_amount_threshold = False
+
+    def _has_over_discrepancy(self):
+        res = super()._has_over_discrepancy()
+        return (
+            res or abs(self.discrepancy_amount) > self.discrepancy_amount_threshold > 0
+        )

stock_account_inventory_discrepancy/models/stock_location.py

@@ -0,0 +1,19 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import fields, models
+
+
+class StockLocation(models.Model):
+    _inherit = "stock.location"
+
+    discrepancy_amount_threshold = fields.Monetary(
+        string="Maximum Discrepancy Amount Threshold",
+        currency_field="discrepancy_amount_threshold_currency_id",
+        help="Maximum Discrepancy Amount allowed for any product when doing "
+        "an Inventory Adjustment. Thresholds defined in Locations have "
+        "preference over Warehouse's ones.",
+    )
+    discrepancy_amount_threshold_currency_id = fields.Many2one(
+        comodel_name="res.currency", related="company_id.currency_id", readonly=True,
+    )

stock_account_inventory_discrepancy/models/stock_quant.py

@@ -0,0 +1,40 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import _, models
+from odoo.exceptions import UserError
+
+
+class Quant(models.Model):
+    _inherit = "stock.quant"
+
+    def _has_over_discrepancy(self, qty=None):
+        self.ensure_one()
+        whs = self.location_id.get_warehouse()
+        if self.location_id.discrepancy_amount_threshold > 0.0:
+            discrepancy_amount_threshold = self.location_id.discrepancy_amount_threshold
+        elif whs.discrepancy_amount_threshold > 0.0:
+            discrepancy_amount_threshold = whs.discrepancy_amount_threshold
+        else:
+            return False
+
+        discrepancy_qty = qty or self.quantity
+        cost = self.product_id.standard_price
+        discrepancy_amount = discrepancy_qty * cost
+
+        return abs(discrepancy_amount) > discrepancy_amount_threshold > 0
+
+    def _set_inventory_quantity(self):
+        for rec in self:
+            variance = self.inventory_quantity - rec.quantity
+            if rec._has_over_discrepancy(qty=variance) and not self.user_has_groups(
+                "stock_inventory_discrepancy.group_stock_inventory_validation_always"
+            ):
+                raise UserError(
+                    _(
+                        "The Qty Update is over the Discrepancy Threshold.\n "
+                        "Please, contact a user with rights to perform "
+                        "this action."
+                    )
+                )
+        return super(Quant, self)._set_inventory_quantity()

stock_account_inventory_discrepancy/models/stock_warehouse.py

@@ -0,0 +1,19 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo import fields, models
+
+
+class StockWarehouse(models.Model):
+    _inherit = "stock.warehouse"
+
+    discrepancy_amount_threshold = fields.Monetary(
+        string="Maximum Discrepancy Amount Threshold",
+        currency_field="discrepancy_amount_threshold_currency_id",
+        help="Maximum Discrepancy Amount allowed for any product when doing "
+        "an Inventory Adjustment. Threshold defined in involved Location "
+        "has preference.",
+    )
+    discrepancy_amount_threshold_currency_id = fields.Many2one(
+        comodel_name="res.currency", related="company_id.currency_id", readonly=True,
+    )

stock_account_inventory_discrepancy/readme/CONFIGURE.rst

@@ -0,0 +1,4 @@
+#. Go to "Inventory > Warehouse Management" > Warehouses" or to "Inventory >
+   Warehouse Management" > Locations".
+#. Modify the "Maximum Discrepancy Amount Threshold" either in a Warehouse or
+   in a location. If set to 0.0 in both the threshold is disabled.

stock_account_inventory_discrepancy/readme/CONTRIBUTORS.rst

@@ -0,0 +1 @@
+* Lois Rilo <lois.rilo@forgeflow.com>

stock_account_inventory_discrepancy/readme/DESCRIPTION.rst

@@ -0,0 +1,5 @@
+Extends `stock_inventory_discrepancy` module to also consider cost
+discrepancies. In other words, this module adds the capability to show the
+cost discrepancy of every line in an inventory adjustment and to block the
+inventory adjustment validation (setting it as 'Pending to Approve') when
+the discrepancy is greater than an user defined amount threshold.

stock_account_inventory_discrepancy/static/description/index.html

@@ -0,0 +1,433 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
+<meta name="generator" content="Docutils: http://docutils.sourceforge.net/" />
+<title>Stock Account Inventory Discrepancy</title>
+<style type="text/css">
+
+/*
+:Author: David Goodger (goodger@python.org)
+:Id: $Id: html4css1.css 7952 2016-07-26 18:15:59Z milde $
+:Copyright: This stylesheet has been placed in the public domain.
+
+Default cascading style sheet for the HTML output of Docutils.
+
+See http://docutils.sf.net/docs/howto/html-stylesheets.html for how to
+customize this style sheet.
+*/
+
+/* used to remove borders from tables and images */
+.borderless, table.borderless td, table.borderless th {
+  border: 0 }
+
+table.borderless td, table.borderless th {
+  /* Override padding for "table.docutils td" with "! important".
+     The right padding separates the table cells. */
+  padding: 0 0.5em 0 0 ! important }
+
+.first {
+  /* Override more specific margin styles with "! important". */
+  margin-top: 0 ! important }
+
+.last, .with-subtitle {
+  margin-bottom: 0 ! important }
+
+.hidden {
+  display: none }
+
+.subscript {
+  vertical-align: sub;
+  font-size: smaller }
+
+.superscript {
+  vertical-align: super;
+  font-size: smaller }
+
+a.toc-backref {
+  text-decoration: none ;
+  color: black }
+
+blockquote.epigraph {
+  margin: 2em 5em ; }
+
+dl.docutils dd {
+  margin-bottom: 0.5em }
+
+object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] {
+  overflow: hidden;
+}
+
+/* Uncomment (and remove this text!) to get bold-faced definition list terms
+dl.docutils dt {
+  font-weight: bold }
+*/
+
+div.abstract {
+  margin: 2em 5em }
+
+div.abstract p.topic-title {
+  font-weight: bold ;
+  text-align: center }
+
+div.admonition, div.attention, div.caution, div.danger, div.error,
+div.hint, div.important, div.note, div.tip, div.warning {
+  margin: 2em ;
+  border: medium outset ;
+  padding: 1em }
+
+div.admonition p.admonition-title, div.hint p.admonition-title,
+div.important p.admonition-title, div.note p.admonition-title,
+div.tip p.admonition-title {
+  font-weight: bold ;
+  font-family: sans-serif }
+
+div.attention p.admonition-title, div.caution p.admonition-title,
+div.danger p.admonition-title, div.error p.admonition-title,
+div.warning p.admonition-title, .code .error {
+  color: red ;
+  font-weight: bold ;
+  font-family: sans-serif }
+
+/* Uncomment (and remove this text!) to get reduced vertical space in
+   compound paragraphs.
+div.compound .compound-first, div.compound .compound-middle {
+  margin-bottom: 0.5em }
+
+div.compound .compound-last, div.compound .compound-middle {
+  margin-top: 0.5em }
+*/
+
+div.dedication {
+  margin: 2em 5em ;
+  text-align: center ;
+  font-style: italic }
+
+div.dedication p.topic-title {
+  font-weight: bold ;
+  font-style: normal }
+
+div.figure {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+div.footer, div.header {
+  clear: both;
+  font-size: smaller }
+
+div.line-block {
+  display: block ;
+  margin-top: 1em ;
+  margin-bottom: 1em }
+
+div.line-block div.line-block {
+  margin-top: 0 ;
+  margin-bottom: 0 ;
+  margin-left: 1.5em }
+
+div.sidebar {
+  margin: 0 0 0.5em 1em ;
+  border: medium outset ;
+  padding: 1em ;
+  background-color: #ffffee ;
+  width: 40% ;
+  float: right ;
+  clear: right }
+
+div.sidebar p.rubric {
+  font-family: sans-serif ;
+  font-size: medium }
+
+div.system-messages {
+  margin: 5em }
+
+div.system-messages h1 {
+  color: red }
+
+div.system-message {
+  border: medium outset ;
+  padding: 1em }
+
+div.system-message p.system-message-title {
+  color: red ;
+  font-weight: bold }
+
+div.topic {
+  margin: 2em }
+
+h1.section-subtitle, h2.section-subtitle, h3.section-subtitle,
+h4.section-subtitle, h5.section-subtitle, h6.section-subtitle {
+  margin-top: 0.4em }
+
+h1.title {
+  text-align: center }
+
+h2.subtitle {
+  text-align: center }
+
+hr.docutils {
+  width: 75% }
+
+img.align-left, .figure.align-left, object.align-left, table.align-left {
+  clear: left ;
+  float: left ;
+  margin-right: 1em }
+
+img.align-right, .figure.align-right, object.align-right, table.align-right {
+  clear: right ;
+  float: right ;
+  margin-left: 1em }
+
+img.align-center, .figure.align-center, object.align-center {
+  display: block;
+  margin-left: auto;
+  margin-right: auto;
+}
+
+table.align-center {
+  margin-left: auto;
+  margin-right: auto;
+}
+
+.align-left {
+  text-align: left }
+
+.align-center {
+  clear: both ;
+  text-align: center }
+
+.align-right {
+  text-align: right }
+
+/* reset inner alignment in figures */
+div.align-right {
+  text-align: inherit }
+
+/* div.align-center * { */
+/*   text-align: left } */
+
+.align-top    {
+  vertical-align: top }
+
+.align-middle {
+  vertical-align: middle }
+
+.align-bottom {
+  vertical-align: bottom }
+
+ol.simple, ul.simple {
+  margin-bottom: 1em }
+
+ol.arabic {
+  list-style: decimal }
+
+ol.loweralpha {
+  list-style: lower-alpha }
+
+ol.upperalpha {
+  list-style: upper-alpha }
+
+ol.lowerroman {
+  list-style: lower-roman }
+
+ol.upperroman {
+  list-style: upper-roman }
+
+p.attribution {
+  text-align: right ;
+  margin-left: 50% }
+
+p.caption {
+  font-style: italic }
+
+p.credits {
+  font-style: italic ;
+  font-size: smaller }
+
+p.label {
+  white-space: nowrap }
+
+p.rubric {
+  font-weight: bold ;
+  font-size: larger ;
+  color: maroon ;
+  text-align: center }
+
+p.sidebar-title {
+  font-family: sans-serif ;
+  font-weight: bold ;
+  font-size: larger }
+
+p.sidebar-subtitle {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+p.topic-title {
+  font-weight: bold }
+
+pre.address {
+  margin-bottom: 0 ;
+  margin-top: 0 ;
+  font: inherit }
+
+pre.literal-block, pre.doctest-block, pre.math, pre.code {
+  margin-left: 2em ;
+  margin-right: 2em }
+
+pre.code .ln { color: grey; } /* line numbers */
+pre.code, code { background-color: #eeeeee }
+pre.code .comment, code .comment { color: #5C6576 }
+pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
+pre.code .literal.string, code .literal.string { color: #0C5404 }
+pre.code .name.builtin, code .name.builtin { color: #352B84 }
+pre.code .deleted, code .deleted { background-color: #DEB0A1}
+pre.code .inserted, code .inserted { background-color: #A3D289}
+
+span.classifier {
+  font-family: sans-serif ;
+  font-style: oblique }
+
+span.classifier-delimiter {
+  font-family: sans-serif ;
+  font-weight: bold }
+
+span.interpreted {
+  font-family: sans-serif }
+
+span.option {
+  white-space: nowrap }
+
+span.pre {
+  white-space: pre }
+
+span.problematic {
+  color: red }
+
+span.section-subtitle {
+  /* font-size relative to parent (h1..h6 element) */
+  font-size: 80% }
+
+table.citation {
+  border-left: solid 1px gray;
+  margin-left: 1px }
+
+table.docinfo {
+  margin: 2em 4em }
+
+table.docutils {
+  margin-top: 0.5em ;
+  margin-bottom: 0.5em }
+
+table.footnote {
+  border-left: solid 1px black;
+  margin-left: 1px }
+
+table.docutils td, table.docutils th,
+table.docinfo td, table.docinfo th {
+  padding-left: 0.5em ;
+  padding-right: 0.5em ;
+  vertical-align: top }
+
+table.docutils th.field-name, table.docinfo th.docinfo-name {
+  font-weight: bold ;
+  text-align: left ;
+  white-space: nowrap ;
+  padding-left: 0 }
+
+/* "booktabs" style (no vertical lines) */
+table.docutils.booktabs {
+  border: 0px;
+  border-top: 2px solid;
+  border-bottom: 2px solid;
+  border-collapse: collapse;
+}
+table.docutils.booktabs * {
+  border: 0px;
+}
+table.docutils.booktabs th {
+  border-bottom: thin solid;
+  text-align: left;
+}
+
+h1 tt.docutils, h2 tt.docutils, h3 tt.docutils,
+h4 tt.docutils, h5 tt.docutils, h6 tt.docutils {
+  font-size: 100% }
+
+ul.auto-toc {
+  list-style-type: none }
+
+</style>
+</head>
+<body>
+<div class="document" id="stock-account-inventory-discrepancy">
+<h1 class="title">Stock Account Inventory Discrepancy</h1>
+
+<!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+!! This file is generated by oca-gen-addon-readme !!
+!! changes will be overwritten.                   !!
+!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
+<p><a class="reference external" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/tree/12.0/stock_account_inventory_discrepancy"><img alt="OCA/stock-logistics-warehouse" src="https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github" /></a> <a class="reference external" href="https://translation.odoo-community.org/projects/stock-logistics-warehouse-12-0/stock-logistics-warehouse-12-0-stock_account_inventory_discrepancy"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external" href="https://runbot.odoo-community.org/runbot/153/12.0"><img alt="Try me on Runbot" src="https://img.shields.io/badge/runbot-Try%20me-875A7B.png" /></a></p>
+<p>Extends <cite>stock_inventory_discrepancy</cite> module to also consider cost
+discrepancies. In other words, this module adds the capability to show the
+cost discrepancy of every line in an inventory adjustment and to block the
+inventory adjustment validation (setting it as ‘Pending to Approve’) when
+the discrepancy is greater than an user defined amount threshold.</p>
+<p><strong>Table of contents</strong></p>
+<div class="contents local topic" id="contents">
+<ul class="simple">
+<li><a class="reference internal" href="#configuration" id="id1">Configuration</a></li>
+<li><a class="reference internal" href="#bug-tracker" id="id2">Bug Tracker</a></li>
+<li><a class="reference internal" href="#credits" id="id3">Credits</a><ul>
+<li><a class="reference internal" href="#authors" id="id4">Authors</a></li>
+<li><a class="reference internal" href="#contributors" id="id5">Contributors</a></li>
+<li><a class="reference internal" href="#maintainers" id="id6">Maintainers</a></li>
+</ul>
+</li>
+</ul>
+</div>
+<div class="section" id="configuration">
+<h1><a class="toc-backref" href="#id1">Configuration</a></h1>
+<ol class="arabic simple">
+<li>Go to “Inventory &gt; Warehouse Management” &gt; Warehouses” or to “Inventory &gt;
+Warehouse Management” &gt; Locations”.</li>
+<li>Modify the “Maximum Discrepancy Amount Threshold” either in a Warehouse or
+in a location. If set to 0.0 in both the threshold is disabled.</li>
+</ol>
+</div>
+<div class="section" id="bug-tracker">
+<h1><a class="toc-backref" href="#id2">Bug Tracker</a></h1>
+<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues">GitHub Issues</a>.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed
+<a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_account_inventory_discrepancy%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<p>Do not contact contributors directly about support or help with technical issues.</p>
+</div>
+<div class="section" id="credits">
+<h1><a class="toc-backref" href="#id3">Credits</a></h1>
+<div class="section" id="authors">
+<h2><a class="toc-backref" href="#id4">Authors</a></h2>
+<ul class="simple">
+<li>ForgeFlow</li>
+</ul>
+</div>
+<div class="section" id="contributors">
+<h2><a class="toc-backref" href="#id5">Contributors</a></h2>
+<ul class="simple">
+<li>Lois Rilo &lt;<a class="reference external" href="mailto:lois.rilo&#64;forgeflow.com">lois.rilo&#64;forgeflow.com</a>&gt;</li>
+</ul>
+</div>
+<div class="section" id="maintainers">
+<h2><a class="toc-backref" href="#id6">Maintainers</a></h2>
+<p>This module is maintained by the OCA.</p>
+<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
+<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/stock-logistics-warehouse/tree/12.0/stock_account_inventory_discrepancy">OCA/stock-logistics-warehouse</a> project on GitHub.</p>
+<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
+</div>
+</div>
+</div>
+</body>
+</html>

stock_account_inventory_discrepancy/tests/__init__.py

@@ -0,0 +1 @@
+from . import test_inventory_discrepancy

stock_account_inventory_discrepancy/tests/test_inventory_discrepancy.py

@@ -0,0 +1,200 @@
+# Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
+
+from odoo.exceptions import except_orm
+from odoo.tests.common import TransactionCase
+
+
+class TestInventoryDiscrepancy(TransactionCase):
+    def setUp(self, *args, **kwargs):
+        super().setUp(*args, **kwargs)
+        self.obj_wh = self.env["stock.warehouse"]
+        self.obj_location = self.env["stock.location"]
+        self.obj_inventory = self.env["stock.inventory"]
+        self.obj_product = self.env["product.product"]
+        self.obj_warehouse = self.env["stock.warehouse"]
+        self.obj_upd_qty_wizard = self.env["stock.change.product.qty"]
+
+        self.product1 = self.obj_product.create(
+            {
+                "name": "Test Product 1",
+                "type": "product",
+                "default_code": "PROD1",
+                "standard_price": 110.0,
+            }
+        )
+        self.product2 = self.obj_product.create(
+            {
+                "name": "Test Product 2",
+                "type": "product",
+                "default_code": "PROD2",
+                "standard_price": 150.0,
+            }
+        )
+        self.test_loc = self.obj_location.create(
+            {
+                "name": "Test Location",
+                "usage": "internal",
+                "discrepancy_amount_threshold": 100,
+            }
+        )
+        self.test_wh = self.obj_warehouse.create(
+            {"name": "Test WH", "code": "T", "discrepancy_amount_threshold": 300}
+        )
+        self.obj_location._parent_store_compute()
+
+        # Create Stock manager able to force validation on inventories.
+        group_stock_man = self.env.ref("stock.group_stock_manager")
+        group_inventory_all = self.env.ref(
+            "stock_inventory_discrepancy." "group_stock_inventory_validation_always"
+        )
+        self.manager = self.env["res.users"].create(
+            {
+                "name": "Test Manager",
+                "login": "manager",
+                "email": "test.manager@example.com",
+                "groups_id": [(6, 0, [group_stock_man.id, group_inventory_all.id])],
+            }
+        )
+        group_stock_user = self.env.ref("stock.group_stock_user")
+        self.user = self.env["res.users"].create(
+            {
+                "name": "Test User",
+                "login": "user",
+                "email": "test.user@example.com",
+                "groups_id": [(6, 0, [group_stock_user.id])],
+            }
+        )
+
+        starting_inv = self.obj_inventory.create(
+            {
+                "name": "Starting inventory",
+                "line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product1.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 2.0,
+                            "location_id": self.test_loc.id,
+                        },
+                    ),
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product2.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 4.0,
+                            "location_id": self.test_loc.id,
+                        },
+                    ),
+                ],
+            }
+        )
+        starting_inv.action_force_done()
+
+    def test_compute_discrepancy(self):
+        """Tests if the amount discrepancy is correctly computed.
+        """
+        inventory = self.obj_inventory.create(
+            {
+                "name": "Test Discrepancy Computation",
+                "location_ids": [(6, 0, self.test_loc.ids)],
+                "line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product1.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 3.0,
+                            "location_id": self.test_loc.id,
+                        },
+                    ),
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product2.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 3.0,
+                            "location_id": self.test_loc.id,
+                        },
+                    ),
+                ],
+            }
+        )
+        self.assertEqual(inventory.line_ids[0].discrepancy_amount, 110.0)
+        self.assertEqual(inventory.line_ids[1].discrepancy_amount, -150.0)
+
+    def test_amount_discrepancy_validation(self):
+        """Tests the workflow with amount threshold."""
+        inventory = self.obj_inventory.create(
+            {
+                "name": "Test Forcing Validation Method",
+                "location_ids": [(6, 0, self.test_loc.ids)],
+                "line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product1.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 3.0,
+                            "location_id": self.test_loc.id,
+                        },
+                    ),
+                ],
+            }
+        )
+        self.assertEqual(inventory.state, "draft")
+        inventory.action_start()
+        self.assertEqual(inventory.line_ids.discrepancy_amount_threshold, 100)
+        self.assertTrue(inventory.line_ids[0].has_over_discrepancy)
+        inventory.with_user(self.user).with_context(
+            {"normal_view": True}
+        ).action_validate()
+        self.assertEqual(inventory.over_discrepancy_line_count, 1)
+        self.assertEqual(inventory.state, "pending")
+
+    def test_warehouse_amount_threshold(self):
+        """Tests the behaviour if the threshold is set on the WH."""
+        inventory = self.obj_inventory.create(
+            {
+                "name": "Test Threshold Defined in WH",
+                "location_ids": [(6, 0, self.test_wh.view_location_id.ids)],
+                "line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": self.product1.id,
+                            "product_uom_id": self.env.ref("uom.product_uom_unit").id,
+                            "product_qty": 3.0,
+                            "location_id": self.test_wh.lot_stock_id.id,
+                        },
+                    ),
+                ],
+            }
+        )
+        self.assertEqual(inventory.line_ids.discrepancy_amount_threshold, 300)
+
+    def test_update_qty_user_error_amount(self):
+        """Test if a user error raises when a stock user tries to update the
+        qty for a product and the correction is a discrepancy over the
+        threshold."""
+        upd_qty = self.obj_upd_qty_wizard.with_user(self.user).create(
+            {
+                "product_id": self.product1.id,
+                "product_tmpl_id": self.product1.product_tmpl_id.id,
+                "new_quantity": 10.0,
+            }
+        )
+        # Since v13, stock users are not allowed to update product qty
+        # (AccessError, standard) but if access are modified to allow them,
+        # they will not be able to surpass the threshold (UserError
+        # added in this module).
+        with self.assertRaises(except_orm):
+            upd_qty.change_product_qty()

stock_account_inventory_discrepancy/views/stock_inventory_view.xml

@@ -0,0 +1,19 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="stock_inventory_line_tree2" model="ir.ui.view">
+        <field
+            name="name"
+        >stock.inventory.line.tree2 - stock_account_inventory_discrepancy</field>
+        <field name="model">stock.inventory.line</field>
+        <field name="inherit_id" ref="stock.stock_inventory_line_tree2" />
+        <field name="arch" type="xml">
+            <field name="product_qty" position="after">
+                <field name="discrepancy_amount" />
+                <field name="discrepancy_amount_threshold" />
+                <field name="company_currency_id" invisible="1" readonly="1" />
+            </field>
+        </field>
+    </record>
+</odoo>

stock_account_inventory_discrepancy/views/stock_location_view.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="view_location_form" model="ir.ui.view">
+        <field name="name">Location form - stock_account_inventory_discrepancy</field>
+        <field name="model">stock.location</field>
+        <field name="inherit_id" ref="stock.view_location_form" />
+        <field name="arch" type="xml">
+            <field name="return_location" position="after">
+                <label for="discrepancy_amount_threshold" />
+                <div>
+                    <field name="discrepancy_amount_threshold" class="oe_inline" />
+                    <field
+                        name="discrepancy_amount_threshold_currency_id"
+                        invisible="1"
+                    />
+                </div>
+            </field>
+        </field>
+    </record>
+</odoo>

stock_account_inventory_discrepancy/views/stock_warehouse_view.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<!-- Copyright 2021 ForgeFlow S.L. (https://www.forgeflow.com)
+     License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
+<odoo>
+    <record id="view_warehouse" model="ir.ui.view">
+        <field name="name">stock.warehouse - stock_account_inventory_discrepancy</field>
+        <field name="model">stock.warehouse</field>
+        <field name="inherit_id" ref="stock.view_warehouse" />
+        <field name="arch" type="xml">
+            <field name="partner_id" position="after">
+                <label for="discrepancy_amount_threshold" />
+                <div>
+                    <field name="discrepancy_amount_threshold" />
+                    <field
+                        name="discrepancy_amount_threshold_currency_id"
+                        invisible="1"
+                    />
+                </div>
+            </field>
+        </field>
+    </record>
+</odoo>