[RFC] Models descriptions and other fixes

pms/i18n/es.po

@@ -2207,7 +2207,7 @@ msgstr "Asistente del Folio"
 
 #. module: pms
 #: model:ir.actions.act_window,name:pms.pms_partner_folios
-#: model:ir.model.fields,field_description:pms.field_account_bank_statement_line__statement_folio_ids
+#: model:ir.model.fields,field_description:pms.field_account_bank_statement_line_folio_ids
 #: model:ir.model.fields,field_description:pms.field_account_move_line__folio_ids
 #: model:ir.model.fields,field_description:pms.field_pms_property__folios_count
 #: model:ir.model.fields,field_description:pms.field_res_partner__folios_count

pms/models/account_bank_statement.py

@@ -3,17 +3,14 @@ from odoo import fields, models
 
 class AccountBankStatement(models.Model):
     _inherit = "account.bank.statement"
-    _check_pms_properties_auto = True
 
     pms_property_id = fields.Many2one(
         string="Property",
         help="Properties with access to the element",
         copy=False,
         comodel_name="pms.property",
-        check_pms_properties=True,
     )
     company_id = fields.Many2one(
         string="Company",
         help="The company for Account Bank Statement",
-        check_pms_properties=True,
     )

pms/models/account_bank_statement_line.py

@@ -4,31 +4,31 @@ from odoo import api, fields, models
 class AccountBankStatementLine(models.Model):
     _inherit = "account.bank.statement.line"
 
-    statement_folio_ids = fields.Many2many(
+    folio_ids = fields.Many2many(
         string="Folios",
         comodel_name="pms.folio",
         ondelete="cascade",
-        relation="account_bank_statement_statement_folio_ids_rel",
+        relation="account_bank_statement_folio_rel",
         column1="account_journal_id",
-        column2="statement_folio_ids_id",
+        column2="folio_id",
     )
     reservation_ids = fields.Many2many(
         string="Reservations",
         help="Reservations in which the Account Bank Statement Lines are included",
         comodel_name="pms.reservation",
         ondelete="cascade",
-        relation="account_bank_statement_reservation_ids_rel",
+        relation="account_bank_statement_reservation_rel",
         column1="account_bank_statement_id",
-        column2="reservation_ids_id",
+        column2="reservation_id",
     )
     service_ids = fields.Many2many(
         string="Services",
         help="Services in which the Account Bank Statement Lines are included",
         comodel_name="pms.service",
         ondelete="cascade",
-        relation="account_bank_statement_service_ids_rel",
+        relation="account_bank_statement_service_rel",
         column1="account_bank_statement_id",
-        column2="service_ids_id",
+        column2="service_id",
     )
 
     @api.model
@@ -36,11 +36,11 @@ class AccountBankStatementLine(models.Model):
         line_vals_list = super(
             AccountBankStatementLine, self
         )._prepare_move_line_default_vals(counterpart_account_id)
-        if self.statement_folio_ids:
+        if self.folio_ids:
             for line in line_vals_list:
                 line.update(
                     {
-                        "folio_ids": [(6, 0, self.statement_folio_ids.ids)],
+                        "folio_ids": [(6, 0, self.folio_ids.ids)],
                     }
                 )
         return line_vals_list

pms/models/account_journal.py

@@ -3,7 +3,6 @@ from odoo import fields, models
 
 class AccountJournal(models.Model):
     _inherit = "account.journal"
-    _check_pms_properties_auto = True
 
     pms_property_ids = fields.Many2many(
         string="Properties",
@@ -14,7 +13,6 @@ class AccountJournal(models.Model):
         relation="account_journal_pms_property_rel",
         column1="account_journal_id",
         column2="pms_property_id",
-        check_pms_properties=True,
     )
     company_id = fields.Many2one(
         string="Company",

pms/models/pms_folio.py

@@ -1326,7 +1326,7 @@ class PmsFolio(models.Model):
             .search(
                 [
                     ("journal_id", "=", journal.id),
-                    ("property_id", "=", property_folio_id[0]),
+                    ("pms_property_id", "=", property_folio_id[0]),
                     ("state", "=", "open"),
                 ]
             )
@@ -1338,7 +1338,7 @@ class PmsFolio(models.Model):
             st_values = {
                 "journal_id": journal.id,
                 "user_id": self.env.user.id,
-                "property_id": property_folio_id[0],
+                "pms_property_id": property_folio_id[0],
                 "name": str(fields.Datetime.now()),
             }
             statement = (
@@ -1351,7 +1351,7 @@ class PmsFolio(models.Model):
             "date": date,
             "amount": amount,
             "partner_id": partner.id if partner else False,
-            "statement_folio_ids": [(6, 0, folios.ids)],
+            "folio_ids": [(6, 0, folios.ids)],
             "reservation_ids": [(6, 0, reservation_ids)],
             "service_ids": [(6, 0, service_ids)],
             "payment_ref": folios.mapped("name"),

pms/models/pms_reservation_line.py

@@ -64,6 +64,7 @@ class PmsReservationLine(models.Model):
         string="State",
         help="State of the reservation line.",
         related="reservation_id.state",
+        store=True,
     )
     price = fields.Float(
         string="Price",

pms/wizards/wizard_folio.py

@@ -5,10 +5,7 @@ from odoo import api, fields, models
 
 class FolioWizard(models.TransientModel):
     _name = "pms.folio.wizard"
-    _description = (
-        "Wizard to check availability by room type and pricelist &"
-        " creation of folios with its reservations"
-    )
+    _description = "Booking engine"
     _check_pms_properties_auto = True
 
     start_date = fields.Date(
@@ -56,7 +53,7 @@ class FolioWizard(models.TransientModel):
         check_pms_properties=True,
     )
     availability_results = fields.One2many(
-        strign="Availability Results",
+        string="Availability Results",
         help="Availability Results",
         readonly=False,
         store=True,

pms/wizards/wizard_folio_availability.py

@@ -5,7 +5,9 @@ from odoo import api, fields, models
 
 class NumRoomsSelectionModel(models.TransientModel):
     _name = "pms.num.rooms.selection"
+    _description = "Dinamic Selection based on avails room"
     _rec_name = "value"
+
     value = fields.Integer()
     room_type_id = fields.Char()
     folio_wizard_id = fields.One2many(
@@ -16,6 +18,7 @@ class NumRoomsSelectionModel(models.TransientModel):
 
 class AvailabilityWizard(models.TransientModel):
     _name = "pms.folio.availability.wizard"
+    _description = "Room type line in Booking Engine"
     _check_pms_properties_auto = True
 
     folio_wizard_id = fields.Many2one(
@@ -50,7 +53,6 @@ class AvailabilityWizard(models.TransientModel):
         readonly=False,
         store=True,
         comodel_name="pms.num.rooms.selection",
-        inverse_name="folio_wizard_id",
         domain="[('value', '<=', num_rooms_available), "
         "('room_type_id', '=', room_type_id)]",
         compute="_compute_num_rooms_selected",

pms/wizards/wizard_payment_folio.py

@@ -38,7 +38,7 @@ class WizardPaymentFolio(models.TransientModel):
         compute="_compute_allowed_method_ids",
     )
     amount = fields.Float(string="Amount", digits=("Product Price"))
-    date = fields.Date(String="Date", required=True, default=fields.Date.context_today)
+    date = fields.Date(string="Date", required=True, default=fields.Date.context_today)
     partner_id = fields.Many2one(string="Partner", comodel_name="res.partner")
 
     @api.depends("folio_id")

pms/wizards/wizard_split_join_swap_reservation.py

@@ -6,6 +6,7 @@ from odoo.exceptions import UserError
 
 class ReservationSplitJoinSwapWizard(models.TransientModel):
     _name = "pms.reservation.split.join.swap.wizard"
+    _description = "Operations in reservations"
 
     operation = fields.Selection(
         string="Operation",
@@ -308,6 +309,7 @@ class ReservationSplitJoinSwapWizard(models.TransientModel):
 
 class ReservationLinesToSplit(models.TransientModel):
     _name = "pms.wizard.reservation.lines.split"
+    _decription = "Lines available to split"
 
     reservation_wizard_id = fields.Many2one(
         string="Reservation Wizard",