mrp_production_request: add tests.

mrp_production_request/models/mrp_production_request.py

@@ -42,7 +42,7 @@ class MrpProductionRequest(models.Model):
         return res
 
     @api.onchange('product_id')
-    def _onchange_product_uom(self):
+    def _onchange_product_id(self):
         self.product_uom = self.product_id.uom_id
         self.bom_id = self.env['mrp.bom']._bom_find(
             product_id=self.product_id.id, properties=[])

mrp_production_request/tests/__init__.py

@@ -0,0 +1,5 @@
+# -*- coding: utf-8 -*-
+# Copyright 2017 Eficent Business and IT Consulting Services S.L.
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from . import test_mrp_production_request

mrp_production_request/tests/test_mrp_production_request.py

@@ -0,0 +1,115 @@
+# -*- coding: utf-8 -*-
+# Copyright 2017 Eficent Business and IT Consulting Services S.L.
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from openerp.tests.common import TransactionCase
+from openerp import fields
+from openerp.exceptions import UserError
+
+
+class TestMrpProductionRequest(TransactionCase):
+    def setUp(self, *args, **kwargs):
+        super(TestMrpProductionRequest, self).setUp(*args, **kwargs)
+        self.production_model = self.env['mrp.production']
+        self.request_model = self.env['mrp.production.request']
+        self.wiz_model = self.env['mrp.production.request.create.mo']
+        self.bom_model = self.env['mrp.bom']
+
+        self.product = self.env.ref('product.product_product_3')
+        self.product.mrp_production_request = True
+
+        self.test_user = self.env['res.users'].create({
+            'name': 'John',
+            'login': 'test',
+        })
+
+    def create_procurement(self, name):
+        values = {
+            'name': name,
+            'date_planned': fields.Datetime.now(),
+            'product_id': self.product.id,
+            'product_qty': 4.0,
+            'product_uom': self.product.uom_id.id,
+            'warehouse_id': self.env.ref('stock.warehouse0').id,
+            'location_id': self.env.ref('stock.stock_location_stock').id,
+            'route_ids': [
+                (4, self.env.ref('mrp.route_warehouse0_manufacture').id, 0)],
+        }
+        return self.env['procurement.order'].create(values)
+
+    def test_manufacture_request(self):
+        """Tests manufacture request workflow."""
+        proc = self.create_procurement('TEST/01')
+        request = proc.mrp_production_request_id
+        request.button_to_approve()
+        request.button_draft()
+        request.button_to_approve()
+        request.button_approved()
+        self.assertEqual(request.pending_qty, 4.0)
+        wiz = self.wiz_model.create({
+            'mrp_production_request_id': request.id,
+        })
+        wiz.compute_product_line_ids()
+        wiz.mo_qty = 4.0
+        wiz.create_mo()
+        mo = self.production_model.search([
+            ('mrp_production_request_id', '=', request.id)])
+        self.assertTrue(mo, "No MO created.")
+        self.assertEqual(request.pending_qty, 0.0)
+        mo.action_confirm()
+        request.button_done()
+
+    def test_cancellation_from_request(self):
+        """Tests propagation of cancel to procurements from manufacturing
+        request and not from manufacturing order."""
+        proc = self.create_procurement('TEST/02')
+        request = proc.mrp_production_request_id
+        wiz = self.wiz_model.create({
+            'mrp_production_request_id': request.id,
+        })
+        wiz.mo_qty = 4.0
+        wiz.create_mo()
+        mo = self.production_model.search([
+            ('mrp_production_request_id', '=', request.id)])
+        mo.action_cancel()
+        self.assertNotEqual(proc.state, 'cancel')
+        request.button_cancel()
+        self.assertEqual(proc.state, 'cancel')
+
+    def test_cancellation_from_proc(self):
+        """Tests cancelation from procurement."""
+        proc = self.create_procurement('TEST/03')
+        request = proc.mrp_production_request_id
+        self.assertNotEqual(request.state, 'cancel')
+        proc.cancel()
+        self.assertEqual(request.state, 'cancel')
+
+    def test_assignation(self):
+        """Tests assignation of manufacturing requests."""
+        randon_bom_id = self.bom_model.search([], limit=1).id
+        request = self.request_model.create({
+            'assigned_to': self.test_user.id,
+            'product_id': self.product.id,
+            'product_qty': 5.0,
+            'bom_id': randon_bom_id,
+        })
+        request._onchange_product_id()
+        self.assertEqual(
+            request.bom_id.product_tmpl_id, self.product.product_tmpl_id,
+            "Wrong Bill of Materials.")
+        request.write({
+            'assigned_to': self.uid,
+        })
+        self.assertTrue(request.message_follower_ids,
+                        "Followers not added correctly.")
+
+    def test_raise_errors(self):
+        """Tests user errors raising properly."""
+        proc = self.create_procurement('TEST/05')
+        request = proc.mrp_production_request_id
+        request.button_to_approve()
+        proc.write({'state': 'done'})
+        with self.assertRaises(UserError):
+            request.button_cancel()
+        with self.assertRaises(UserError):
+            request.button_draft()

mrp_production_request/views/mrp_production_request_view.xml

@@ -13,7 +13,7 @@
                         states="to_approve,approved,cancel,done"
                         string="Reset"
                         type="object"
-                        groups="purchase_request.group_purchase_request_manager"/>
+                        groups="mrp_production_request.group_mrp_production_request_manager"/>
                 <button name="button_to_approve" states="draft"
                         string="Request approval" type="object"
                         class="oe_highlight"/>
@@ -183,7 +183,7 @@
         <field name="context">{"search_default_pending":1}</field>
         <field name="help" type="html">
           <p class="oe_view_nocontent_create">
-            Click to start a new purchase request process.
+            Click to start a new manufacturing request process.
           </p><p>
             A Manufacturing Request is an instruction to production to produce
             a certain quantity of a given product.

mrp_production_request/wizards/mrp_production_request_create_mo.py

@@ -2,9 +2,8 @@
 # Copyright 2017 Eficent Business and IT Consulting Services S.L.
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from openerp import api, fields, models, _
+from openerp import api, fields, models
 import openerp.addons.decimal_precision as dp
-from openerp.exceptions import UserError
 
 
 class MrpProductionRequestCreateMo(models.TransientModel):
@@ -35,9 +34,6 @@ class MrpProductionRequestCreateMo(models.TransientModel):
         bom_obj = self.env['mrp.bom']
         uom_obj = self.env['product.uom']
         bom_point = self.bom_id
-        if not bom_point:
-            raise UserError(_("Manufacture Request does not have a Bill of "
-                              "Materials defined."))
         factor = uom_obj._compute_qty(
             self.mrp_production_request_id.product_uom.id, self.pending_qty,
             bom_point.product_uom.id)