audrius/contract
1
0
Fork 1
mirror of https://github.com/OCA/contract.git synced 2025-02-13 17:57:24 +02:00
Code Issues Packages Projects Releases Wiki Activity
220 Commits 13 Branches 0 Tags
ea83dfa27702276a2b9d3321f26f968f2d763c2c
Go to file
Clone
Open with VS Code Open with VSCodium Open with Intellij IDEA
Download ZIP Download TAR.GZ Download BUNDLE
Jairo Llopis ea83dfa277 [FIX] contract: do not die if modified partner has contracts in several companies 
In a multicompany scenario where a contact belongs to a company and has contracts in several companies, if the user goes to the contact to edit anything, when saving, it will trigger the recomputation of the `commercial_partner_id` field, which gets populated to all the related contracts, and will undeniably fail with an `AccessError`.

A simple test is provided that, without the fix, fails like this:

```
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: ERROR: test_multicompany_partner_edited (odoo.addons.contract.tests.test_contract.TestContract)
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: ` Editing a partner with contracts in several companies works.
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: Traceback (most recent call last):
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/auto/addons/contract/tests/test_contract.py", line 2513, in test_multicompany_partner_edited
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: `     'parent_id': parent_partner.id,
2020-06-25 07:21:24,859 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/auto/addons/partner_autocomplete/models/res_partner.py", line 183, in write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     res = super(ResPartner, self).write(values)
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/res_partner.py", line 570, in write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     result = result and super(Partner, self).write(vals)
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/auto/addons/mail/models/mail_thread.py", line 321, in write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     result = super(MailThread, self).write(values)
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/auto/addons/mail/models/mail_activity.py", line 613, in write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     return super(MailActivityMixin, self).write(vals)
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3381, in write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     self.recompute()
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 5308, in recompute
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     target._write(dict(vals))
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3433, in _write
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     self.check_access_rule('write')
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `   File "/opt/odoo/custom/src/odoo/odoo/models.py", line 3081, in check_access_rule
2020-06-25 07:21:24,860 33 ERROR devel odoo.addons.contract.tests.test_contract: `     + ' - ({} {}, {} {})'.format(_('Records:'), invalid.ids[:6], _('User:'), self._uid)
2020-06-25 07:21:24,861 33 ERROR devel odoo.addons.contract.tests.test_contract: ` odoo.exceptions.AccessError: ('The requested operation cannot be completed due to security restrictions. Please contact your system administrator.\n\n(Document type: Contract, Operation: write) - (Records: [101], User: 12)', None)
```

@Tecnativa TT24482
2020-07-14 11:53:19 +02:00
contract
[FIX] contract: do not die if modified partner has contracts in several companies
2020-07-14 11:53:19 +02:00
.editorconfig
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
.eslintrc.yml
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
.flake8
pre-commit, black, isort [ci skip]
2019-10-12 11:59:36 +02:00
.gitignore
[MIG] Add metafiles
2019-09-29 23:31:26 +02:00
.isort.cfg
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
.pre-commit-config.yaml
[UPD] pin flake8 version [ci skip]
2020-05-13 13:52:25 +02:00
.prettierrc.yml
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
.pylintrc
pre-commit, black, isort [ci skip]
2019-10-12 11:59:36 +02:00
.pylintrc-mandatory
pre-commit, black, isort [ci skip]
2019-10-12 11:59:36 +02:00
.travis.yml
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
CONTRIBUTING.md
pre-commit update [ci skip]
2020-03-14 11:55:15 +01:00
LICENSE
pre-commit, black, isort [ci skip]
2019-10-12 11:59:36 +02:00
README.md
pre-commit, black, isort [ci skip]
2019-10-12 11:59:36 +02:00

README.md

Runbot Status Build Status Coverage Status

Contracts

Odoo Contracts are special types of Analytic Accounts. This repository provides features extending Contracts.

Dependencies on Project features should not be required. For Project related extensions please see the OCA/Project repository.

Translation Status

Translation Status

Reference in New Issue View Git Blame Copy Permalink
Description
No description provided
erphacktoberfestodoopython
Readme 66 MiB
Languages
Python 60.4%
HTML 39%
JavaScript 0.4%
SCSS 0.2%