audrius/bank-statement-import
1
0
Fork 1
mirror of https://github.com/OCA/bank-statement-import.git synced 2025-01-20 12:37:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] account_statement_import_camt: pre-commit auto fixes

Browse Source
This commit is contained in:
Holger Brunn
2024-04-22 13:59:19 +02:00
parent 6fa2ff562a
commit 7a62a01080
13 changed files with 79 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
account_statement_import_camt/README.rst
View File

@@ -17,13 +17,13 @@ CAMT Format Bank Statements Import
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github
:target: https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt
:target: https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt
:alt: OCA/bank-statement-import
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt
:target: https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_camt
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&target_branch=16.0
:target: https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&target_branch=17.0
:alt: Try me on Runboat
|badge1| |badge2| |badge3| |badge4| |badge5|
@@ -41,7 +41,7 @@ Bug Tracker
Bugs are tracked on `GitHub Issues <https://github.com/OCA/bank-statement-import/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
`feedback <https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
Do not contact contributors directly about support or help with technical issues.
@@ -49,30 +49,37 @@ Credits
=======
Authors
~~~~~~~
-------
* Therp BV
Contributors
~~~~~~~~~~~~
------------
* Holger Brunn <hbrunn@therp.nl>
* Stefan Rijnhart <stefan.rijnhart@opener.amsterdam>
* Ronald Portier <rportier@therp.nl>
* Andrea Stirpe <a.stirpe@onestein.nl>
* Maxence Groine <mgroine@fiefmanage.ch>
* Iryna Vyshnevska <i.vyshnevska@mobilunity.com>
* `Trobz <https://trobz.com>`_:
- Holger Brunn <hbrunn@therp.nl>
* Son Ho <sonhd@trobz.com>
- Stefan Rijnhart <stefan.rijnhart@opener.amsterdam>
- Ronald Portier <rportier@therp.nl>
- Andrea Stirpe <a.stirpe@onestein.nl>
- Maxence Groine <mgroine@fiefmanage.ch>
- Iryna Vyshnevska <i.vyshnevska@mobilunity.com>
- `Trobz <https://trobz.com>`__:
- Son Ho <sonhd@trobz.com>
Other credits
~~~~~~~~~~~~~
-------------
The migration of this module from 15.0 to 16.0 was financially supported by Camptocamp
The migration of this module from 15.0 to 16.0 was financially supported
by Camptocamp
Maintainers
~~~~~~~~~~~
-----------
This module is maintained by the OCA.
@@ -84,6 +91,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.
This module is part of the `OCA/bank-statement-import <https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt>`_ project on GitHub.
This module is part of the `OCA/bank-statement-import <https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt>`_ project on GitHub.
You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

1
account_statement_import_camt/models/account_bank_statement_line.py
View File

@@ -4,7 +4,6 @@ from odoo import models
class AccountBankStatementLine(models.Model):
_inherit = "account.bank.statement.line"
def write(self, vals):

4
account_statement_import_camt/models/account_journal.py
View File

@@ -8,8 +8,6 @@ class AccountJournal(models.Model):
_inherit = "account.journal"
def _get_bank_statements_available_import_formats(self):
res = super(
AccountJournal, self
)._get_bank_statements_available_import_formats()
res = super()._get_bank_statements_available_import_formats()
res.extend([_("camt.053.001.02"), _("camt.054.001.02")])
return res

1
account_statement_import_camt/models/bank_statement.py
View File

@@ -4,7 +4,6 @@ from odoo import models
class AccountBankStatement(models.Model):
_inherit = "account.bank.statement"
def reconciliation_widget_preprocess(self):

21
account_statement_import_camt/models/parser.py
View File

@@ -39,7 +39,7 @@ class CamtParser(models.AbstractModel):
If xpath_str is a list (or iterable), it will be seen as a series
of search path's in order of preference. The first item that results
in a found node will be used to set a value."""
if not isinstance(xpath_str, (list, tuple)):
if not isinstance(xpath_str, list | tuple):
xpath_str = [xpath_str]
for search_str in xpath_str:
found_node = node.xpath(search_str, namespaces={"ns": ns})
@@ -246,20 +246,23 @@ class CamtParser(models.AbstractModel):
def generate_narration(self, transaction):
# this block ensure compatibility with v13
transaction["narration"] = {
"%s (RltdPties/Nm)"
% _("Partner Name"): transaction.get("partner_name", ""),
"%s (RltdPties/Acct)"
% _("Partner Account Number"): transaction.get("account_number", ""),
"%s (BookgDt)" % _("Transaction Date"): transaction.get("date", ""),
"{} (RltdPties/Nm)".format(_("Partner Name")): transaction.get(
"partner_name", ""
),
"{} (RltdPties/Acct)".format(_("Partner Account Number")): transaction.get(
"account_number", ""
),
"{} (BookgDt)".format(_("Transaction Date")): transaction.get("date", ""),
_("Reference"): transaction.get("ref", ""),
_("Communication"): transaction.get("name", ""),
"%s (BkTxCd)"
% _("Transaction Type"): transaction.get("transaction_type", ""),
"{} (BkTxCd)".format(_("Transaction Type")): transaction.get(
"transaction_type", ""
),
**transaction["narration"],
}
transaction["narration"] = "\n".join(
["%s: %s" % (key, val) for key, val in transaction["narration"].items()]
[f"{key}: {val}" for key, val in transaction["narration"].items()]
)
def parse_entry(self, ns, node):

3
account_statement_import_camt/pyproject.toml Normal file
View File

@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"

15
account_statement_import_camt/readme/CONTRIBUTORS.md Normal file
View File

@@ -0,0 +1,15 @@
- Holger Brunn \<<hbrunn@therp.nl>\>
- Stefan Rijnhart \<<stefan.rijnhart@opener.amsterdam>\>
- Ronald Portier \<<rportier@therp.nl>\>
- Andrea Stirpe \<<a.stirpe@onestein.nl>\>
- Maxence Groine \<<mgroine@fiefmanage.ch>\>
- Iryna Vyshnevska \<<i.vyshnevska@mobilunity.com>\>
- [Trobz](https://trobz.com):
> - Son Ho \<<sonhd@trobz.com>\>

9
account_statement_import_camt/readme/CONTRIBUTORS.rst
View File

@@ -1,9 +0,0 @@
* Holger Brunn <hbrunn@therp.nl>
* Stefan Rijnhart <stefan.rijnhart@opener.amsterdam>
* Ronald Portier <rportier@therp.nl>
* Andrea Stirpe <a.stirpe@onestein.nl>
* Maxence Groine <mgroine@fiefmanage.ch>
* Iryna Vyshnevska <i.vyshnevska@mobilunity.com>
* `Trobz <https://trobz.com>`_:
* Son Ho <sonhd@trobz.com>

3
account_statement_import_camt/readme/CREDITS.rst → account_statement_import_camt/readme/CREDITS.md
View File

@@ -1 +1,2 @@
The migration of this module from 15.0 to 16.0 was financially supported by Camptocamp
The migration of this module from 15.0 to 16.0 was financially supported
by Camptocamp

0
account_statement_import_camt/readme/DESCRIPTION.rst → account_statement_import_camt/readme/DESCRIPTION.md
View File

21
account_statement_import_camt/static/description/index.html
View File

@@ -1,3 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
@@ -8,10 +9,11 @@
/*
:Author: David Goodger (goodger@python.org)
:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
:Copyright: This stylesheet has been placed in the public domain.
Default cascading style sheet for the HTML output of Docutils.
Despite the name, some widely supported CSS2 features are used.
See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
customize this style sheet.
@@ -274,7 +276,7 @@ pre.literal-block, pre.doctest-block, pre.math, pre.code {
margin-left: 2em ;
margin-right: 2em }
pre.code .ln { color: grey; } /* line numbers */
pre.code .ln { color: gray; } /* line numbers */
pre.code, code { background-color: #eeeeee }
pre.code .comment, code .comment { color: #5C6576 }
pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +302,7 @@ span.option {
span.pre {
white-space: pre }
span.problematic {
span.problematic, pre.problematic {
color: red }
span.section-subtitle {
@@ -368,7 +370,7 @@ ul.auto-toc {
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:6af9753752cdfa39f3d971e084ed946578dc75aafbbc9a600aeb0b8b06b4427b
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt"><img alt="OCA/bank-statement-import" src="https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt"><img alt="OCA/bank-statement-import" src="https://img.shields.io/badge/github-OCA%2Fbank--statement--import-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/bank-statement-import-17-0/bank-statement-import-17-0-account_statement_import_camt"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/bank-statement-import&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
<p>Module to import SEPA CAMT.053 and CAMT.054 Format bank statement files.</p>
<p><strong>Table of contents</strong></p>
<div class="contents local topic" id="contents">
@@ -388,7 +390,7 @@ ul.auto-toc {
<p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/bank-statement-import/issues">GitHub Issues</a>.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
<a class="reference external" href="https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<a class="reference external" href="https://github.com/OCA/bank-statement-import/issues/new?body=module:%20account_statement_import_camt%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
<p>Do not contact contributors directly about support or help with technical issues.</p>
</div>
<div class="section" id="credits">
@@ -425,16 +427,19 @@ If you spotted it first, help us to smash it by providing a detailed and welcome
</div>
<div class="section" id="other-credits">
<h2><a class="toc-backref" href="#toc-entry-5">Other credits</a></h2>
<p>The migration of this module from 15.0 to 16.0 was financially supported by Camptocamp</p>
<p>The migration of this module from 15.0 to 16.0 was financially supported
by Camptocamp</p>
</div>
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
<p>This module is maintained by the OCA.</p>
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
<a class="reference external image-reference" href="https://odoo-community.org">
<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
</a>
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/bank-statement-import/tree/16.0/account_statement_import_camt">OCA/bank-statement-import</a> project on GitHub.</p>
<p>This module is part of the <a class="reference external" href="https://github.com/OCA/bank-statement-import/tree/17.0/account_statement_import_camt">OCA/bank-statement-import</a> project on GitHub.</p>
<p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
</div>
</div>

2
account_statement_import_camt/tests/test_import_bank_statement.py
View File

@@ -53,7 +53,7 @@ class TestParserCommon(TransactionCase):
with open(get_module_resource(*inputfile_path.parts), "rb") as inputf:
res = self.parser.parse(inputf.read())
# Read the output file, store the expected imported values
with open(get_module_resource(*goldenfile_path.parts), "r") as goldf:
with open(get_module_resource(*goldenfile_path.parts)) as goldf:
gold_name, gold_lines = goldf.name, goldf.readlines()
# Save the imported values in a tmp file to compare them w/ the expected values
with tempfile.NamedTemporaryFile(mode="w+", suffix=".pydata") as tempf:

11
account_statement_import_file/static/description/index.html
View File

@@ -8,10 +8,11 @@
/*
:Author: David Goodger (goodger@python.org)
:Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $
:Id: $Id: html4css1.css 9511 2024-01-13 09:50:07Z milde $
:Copyright: This stylesheet has been placed in the public domain.
Default cascading style sheet for the HTML output of Docutils.
Despite the name, some widely supported CSS2 features are used.
See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to
customize this style sheet.
@@ -274,7 +275,7 @@ pre.literal-block, pre.doctest-block, pre.math, pre.code {
margin-left: 2em ;
margin-right: 2em }
pre.code .ln { color: grey; } /* line numbers */
pre.code .ln { color: gray; } /* line numbers */
pre.code, code { background-color: #eeeeee }
pre.code .comment, code .comment { color: #5C6576 }
pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold }
@@ -300,7 +301,7 @@ span.option {
span.pre {
white-space: pre }
span.problematic {
span.problematic, pre.problematic {
color: red }
span.section-subtitle {
@@ -448,7 +449,9 @@ If you spotted it first, help us to smash it by providing a detailed and welcome
<div class="section" id="maintainers">
<h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
<p>This module is maintained by the OCA.</p>
<a class="reference external image-reference" href="https://odoo-community.org"><img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" /></a>
<a class="reference external image-reference" href="https://odoo-community.org">
<img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
</a>
<p>OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.</p>