[MIG] account_bank_statement_import_online_paypal: Migration to 13.0

account_bank_statement_import_online_paypal/__manifest__.py

@@ -1,17 +1,17 @@
 # Copyright 2019 Brainbean Apps (https://brainbeanapps.com)
-# Copyright 2020 CorporateHub (https://corporatehub.eu)
+# Copyright 2020-2021 CorporateHub (https://corporatehub.eu)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 {
     "name": "Online Bank Statements: PayPal.com",
-    "version": "12.0.1.1.0",
-    "author": "CorporateHub, " "Odoo Community Association (OCA)",
+    "version": "13.0.1.0.0",
+    "author": "CorporateHub, Odoo Community Association (OCA)",
     "maintainers": ["alexey-pelykh"],
     "website": "https://github.com/OCA/bank-statement-import/",
     "license": "AGPL-3",
     "category": "Accounting",
     "summary": "Online bank statements for PayPal.com",
-    "depends": ["account_bank_statement_import_online",],
-    "data": ["views/online_bank_statement_provider.xml",],
+    "depends": ["account_bank_statement_import_online"],
+    "data": ["views/online_bank_statement_provider.xml"],
     "installable": True,
 }

account_bank_statement_import_online_paypal/models/online_bank_statement_provider_paypal.py

@@ -1,4 +1,5 @@
 # Copyright 2019-2020 Brainbean Apps (https://brainbeanapps.com)
+# Copyright 2021 CorporateHub (https://corporatehub.eu)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
 
 import itertools
@@ -175,7 +176,6 @@ class OnlineBankStatementProviderPayPal(models.Model):
             ("paypal", "PayPal.com"),
         ]
 
-    @api.multi
     def _obtain_statement_data(self, date_since, date_until):
         self.ensure_one()
         if self.service != "paypal":
@@ -206,7 +206,7 @@ class OnlineBankStatementProviderPayPal(models.Model):
         )
         if not transactions:
             balance = self._paypal_get_balance(token, currency, date_since)
-            return [], {"balance_start": balance, "balance_end_real": balance,}
+            return [], {"balance_start": balance, "balance_end_real": balance}
 
         # Normalize transactions, sort by date, and get lines
         transactions = list(
@@ -249,7 +249,7 @@ class OnlineBankStatementProviderPayPal(models.Model):
             )
         balance_end = self._paypal_get_transaction_ending_balance(last_transaction)
 
-        return lines, {"balance_start": balance_start, "balance_end_real": balance_end,}
+        return lines, {"balance_start": balance_start, "balance_end_real": balance_end}
 
     @api.model
     def _paypal_preparse_transaction(self, transaction):
@@ -301,9 +301,7 @@ class OnlineBankStatementProviderPayPal(models.Model):
             "alternate_full_name"
         )
         if payer_full_name:
-            line.update(
-                {"partner_name": payer_full_name,}
-            )
+            line.update({"partner_name": payer_full_name})
         lines = [line]
         if fee_amount:
             lines += [
@@ -318,13 +316,12 @@ class OnlineBankStatementProviderPayPal(models.Model):
             ]
         return lines
 
-    @api.multi
     def _paypal_get_token(self):
         self.ensure_one()
         data = self._paypal_retrieve(
             (self.api_base or PAYPAL_API_BASE) + "/v1/oauth2/token",
             (self.username, self.password),
-            data=urlencode({"grant_type": "client_credentials",}).encode("utf-8"),
+            data=urlencode({"grant_type": "client_credentials"}).encode("utf-8"),
         )
         if "scope" not in data or TRANSACTIONS_SCOPE not in data["scope"]:
             raise UserError(_("PayPal App features are configured incorrectly!"))
@@ -334,14 +331,12 @@ class OnlineBankStatementProviderPayPal(models.Model):
             raise UserError(_("Failed to acquire token using Client ID and Secret!"))
         return data["access_token"]
 
-    @api.multi
     def _paypal_get_balance(self, token, currency, as_of_timestamp):
         self.ensure_one()
         url = (
             self.api_base or PAYPAL_API_BASE
         ) + "/v1/reporting/balances?currency_code={}&as_of_time={}".format(
-            currency,
-            as_of_timestamp.isoformat() + "Z",
+            currency, as_of_timestamp.isoformat() + "Z",
         )
         data = self._paypal_retrieve(url, token)
         available_balance = data["balances"][0].get("available_balance")
@@ -349,7 +344,6 @@ class OnlineBankStatementProviderPayPal(models.Model):
             return Decimal()
         return Decimal(available_balance["value"])
 
-    @api.multi
     def _paypal_get_transaction(self, token, transaction_id, timestamp):
         self.ensure_one()
         transaction_date = timestamp.isoformat() + "Z"
@@ -367,7 +361,6 @@ class OnlineBankStatementProviderPayPal(models.Model):
             return transaction
         return None
 
-    @api.multi
     def _paypal_get_transactions(self, token, currency, since, until):
         self.ensure_one()
         # NOTE: Not more than 31 days in a row
@@ -507,7 +500,8 @@ class OnlineBankStatementProviderPayPal(models.Model):
                 "Authorization",
                 "Basic %s"
                 % str(
-                    b64encode(("{}:{}".format(auth[0], auth[1])).encode("utf-8")), "utf-8"
+                    b64encode(("{}:{}".format(auth[0], auth[1])).encode("utf-8")),
+                    "utf-8",
                 ),
             )
         elif isinstance(auth, str):

account_bank_statement_import_online_paypal/tests/test_account_bank_statement_import_online_paypal.py

@@ -1,4 +1,5 @@
 # Copyright 2019 Brainbean Apps (https://brainbeanapps.com)
+# Copyright 2021 CorporateHub (https://corporatehub.eu)
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
 import json
@@ -25,6 +26,7 @@ class FakeHTTPError(HTTPError):
     def __init__(self, content):
         self.content = content
 
+    # pylint: disable=method-required-super
     def read(self):
         return self.content.encode("utf-8")
 
@@ -37,9 +39,10 @@ class UrlopenRetValMock:
     def __enter__(self):
         return self
 
-    def __exit__(self, type, value, tb):
+    def __exit__(self, exc_type, exc_value, traceback):
         pass
 
+    # pylint: disable=method-required-super
     def read(self):
         if self.throw:
             raise FakeHTTPError(self.content)
@@ -246,7 +249,7 @@ class TestAccountBankAccountStatementImportOnlinePayPal(common.TransactionCase):
                 test_account_bank_statement_import_online_paypal_monday=True,
             )._obtain_statement_data(self.now - relativedelta(hours=1), self.now,)
 
-        self.assertEqual(data, ([], {"balance_start": 0.75, "balance_end_real": 0.75,}))
+        self.assertEqual(data, ([], {"balance_start": 0.75, "balance_end_real": 0.75}))
 
     def test_error_handling_1(self):
         journal = self.AccountJournal.create(
@@ -360,7 +363,7 @@ class TestAccountBankAccountStatementImportOnlinePayPal(common.TransactionCase):
                 self.now - relativedelta(hours=1), self.now,
             )
 
-        self.assertEqual(data, ([], {"balance_start": 0.75, "balance_end_real": 0.75,}))
+        self.assertEqual(data, ([], {"balance_start": 0.75, "balance_end_real": 0.75}))
 
     def test_ancient_pull(self):
         journal = self.AccountJournal.create(
@@ -536,7 +539,7 @@ class TestAccountBankAccountStatementImportOnlinePayPal(common.TransactionCase):
                 "unique_import_id": "1234567890-1564617600-FEE",
             },
         )
-        self.assertEqual(data[1], {"balance_start": 0.0, "balance_end_real": 900.0,})
+        self.assertEqual(data[1], {"balance_start": 0.0, "balance_end_real": 900.0})
 
     def test_transaction_parse_1(self):
         lines = self.paypal_parse_transaction(