audrius/bank-payment
1
0
Fork 1
mirror of https://github.com/OCA/bank-payment.git synced 2025-02-02 10:37:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] do not attempt to create transfer moves for payment lines without associated ar/ap move line

Browse Source 
Otherwise, it is not possible to execute such payment order if the
payment mode has a transfer account. And I can't see how it could
make sense if the transfer move cannot be reconciled in the first place.
This commit is contained in:
Stéphane Bidoul
2014-09-29 22:06:15 +02:00
parent 424c4067cb
commit cbb0f41426
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
account_banking_payment_transfer/model/account_payment.py
View File

@@ -207,12 +207,7 @@ class payment_order(orm.Model):
self, cr, uid, order, line, vals, context=None):
vals.update({
'partner_id': line.partner_id.id,
'account_id': (line.move_line_id
and line.move_line_id.account_id.id
or False),
# if not line.move_line_id, the field 'account_id' must be set by
# another module that inherit this function, like for example in
# the module purchase_payment_order
'account_id': line.move_line_id.account_id.id,
'credit': (order.payment_order_type == 'debit'
and line.amount or 0.0),
'debit': (order.payment_order_type == 'payment'
@@ -242,8 +237,10 @@ class payment_order(orm.Model):
or not order.mode.transfer_account_id:
continue
for line in order.line_ids:
if not line.move_line_id:
continue
# basic checks
if line.move_line_id and line.move_line_id.reconcile_id:
if line.move_line_id.reconcile_id:
raise orm.except_orm(
_('Error'),
_('Move line %s has already been paid/reconciled')