audrius/bank-payment
1
0
Fork 1
mirror of https://github.com/OCA/bank-payment.git synced 2025-02-02 10:37:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] Banking Mandate: set reference at creation if falsy value in dict

Browse Source
This commit is contained in:
Thomas Binsfeld
2019-05-08 09:48:31 +02:00
committed by Stefan Rijnhart
parent a9dd3a3d80
commit 74ddffa498
2 changed files with 73 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
account_banking_mandate/models/account_banking_mandate.py
View File

@@ -186,7 +186,8 @@ class AccountBankingMandate(models.Model):
@api.model
def create(self, vals=None):
if vals.get('unique_mandate_reference', 'New') == 'New':
unique_mandate_reference = vals.get('unique_mandate_reference')
if not unique_mandate_reference or unique_mandate_reference == 'New':
vals['unique_mandate_reference'] = \
self.env['ir.sequence'].next_by_code(
'account.banking.mandate') or 'New'

71
account_banking_mandate/tests/test_mandate.py
View File

@@ -125,6 +125,77 @@ class TestMandate(TransactionCase):
with self.assertRaises(ValidationError):
bank_account.mandate_ids += mandate
def test_mandate_reference_01(self):
"""
Test case: create a mandate with no reference
Expected result: the reference of the created mandate is not empty
"""
bank_account = self.env.ref('account_payment_mode.res_partner_12_iban')
mandate = self.env['account.banking.mandate'].create({
'partner_bank_id': bank_account.id,
'signature_date': '2015-01-01',
'company_id': self.company.id,
})
self.assertTrue(mandate.unique_mandate_reference)
def test_mandate_reference_02(self):
"""
Test case: create a mandate with "ref01" as reference
Expected result: the reference of the created mandate is "ref01"
"""
bank_account = self.env.ref('account_payment_mode.res_partner_12_iban')
mandate = self.env['account.banking.mandate'].create({
'partner_bank_id': bank_account.id,
'signature_date': '2015-01-01',
'company_id': self.company.id,
'unique_mandate_reference': "ref01",
})
self.assertEqual(mandate.unique_mandate_reference, "ref01")
def test_mandate_reference_03(self):
"""
Test case: create a mandate with "New" as reference
Expected result: the reference of the created mandate is not empty and
is not "New"
"""
bank_account = self.env.ref('account_payment_mode.res_partner_12_iban')
mandate = self.env['account.banking.mandate'].create({
'partner_bank_id': bank_account.id,
'signature_date': '2015-01-01',
'company_id': self.company.id,
'unique_mandate_reference': "New",
})
self.assertTrue(mandate.unique_mandate_reference)
self.assertNotEqual(mandate.unique_mandate_reference, "New")
def test_mandate_reference_05(self):
"""
Test case: create a mandate with False as reference
Expected result: the reference of the created mandate is not empty
"""
bank_account = self.env.ref('account_payment_mode.res_partner_12_iban')
mandate = self.env['account.banking.mandate'].create({
'partner_bank_id': bank_account.id,
'signature_date': '2015-01-01',
'company_id': self.company.id,
'unique_mandate_reference': False,
})
self.assertTrue(mandate.unique_mandate_reference)
def test_mandate_reference_06(self):
"""
Test case: create a mandate with a empty string as reference
Expected result: the reference of the created mandate is not empty
"""
bank_account = self.env.ref('account_payment_mode.res_partner_12_iban')
mandate = self.env['account.banking.mandate'].create({
'partner_bank_id': bank_account.id,
'signature_date': '2015-01-01',
'company_id': self.company.id,
'unique_mandate_reference': '',
})
self.assertTrue(mandate.unique_mandate_reference)
def setUp(self):
res = super(TestMandate, self).setUp()
# Company