[FIX] account_banking: invalid definition of method

[FIX] account_banking: removed unused configuration class
[IMP] account_banking_nl_multibank: added sanity check on columns parsed

account_banking/account_banking.py

@@ -64,25 +64,6 @@ from tools.translate import _
 from wizard.banktools import get_or_create_bank
 import pooler
 
-class account_banking_settings(osv.osv):
-    '''Settings for the account_banking module'''
-    _name = 'account.banking.settings'
-    _description = __doc__
-    _columns = {
-        'use_online': fields.boolean('Online Sources',
-                                     help=('Select this if you want to be '
-                                           'able to use the online banking '
-                                           'resources from the internet '
-                                           'to auto complete account and '
-                                           'bank info.')
-                                    ),
-    }
-    _defaults = {
-        'use_online': lambda *a: True,
-    }
-
-account_banking_settings()
-
 class account_banking_account_settings(osv.osv):
     '''Default Journal for Bank Account'''
     _name = 'account.banking.account.settings'

account_banking/wizard/bank_import.py

@@ -99,7 +99,7 @@ class banking_import(wizard.interface):
     def _fill_results(self, *args, **kwargs):
         return {'log': self._log}
 
-    def _get_move_info(cursor, uid, move_line):
+    def _get_move_info(self, cursor, uid, move_line):
         reconcile_obj = self.pool.get('account.bank.statement.reconcile')
         type_map = {
             'out_invoice': 'customer',

account_banking_nl_multibank/multibank.py

@@ -69,6 +69,10 @@ class transaction_message(object):
         '''
         Initialize own dict with attributes and coerce values to right type
         '''
+        if len(self.attrnames) != len(values):
+            raise ValueError, \
+                    _('Invalid transaction line: expected %d columns, found %d') \
+                    % (len(self.attrnames), len(values))
         self.__dict__.update(dict(zip(self.attrnames, values)))
         #self.local_account = self.clean_account(self.local_account)
         #self.remote_account = self.clean_account(self.remote_account)