[FIX] account_banking_pain_base: Proper condition for AdrLine

Steps to reproduce the problem:

- Have a partner with no zip code and no city.
- Include it in a payment order.
- Generate the SEPA XML file.

Current behavior: The file couldn't be generated because there's an
empty <AdrLine> element.

We put properly parenthesis in the conditions for this to no happen.

TT43260
This commit is contained in:
Pedro M. Baeza
2022-12-20 15:53:24 +01:00
parent 4e329d6c77
commit 04a76604a9
2 changed files with 2 additions and 3 deletions

View File

@@ -7,7 +7,7 @@
{
"name": "Account Banking PAIN Base Module",
"summary": "Base module for PAIN file generation",
"version": "15.0.2.0.1",
"version": "15.0.2.0.2",
"license": "AGPL-3",
"author": "Akretion, Noviat, Tecnativa, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/bank-payment",

View File

@@ -523,8 +523,7 @@ class AccountPaymentOrder(models.Model):
if (
gen_args.get("pain_flavor").startswith("pain.001.001.")
or gen_args.get("pain_flavor").startswith("pain.008.001.")
and (partner.zip or partner.city)
):
) and (partner.zip or partner.city):
adrline2 = etree.SubElement(postal_address, "AdrLine")
if partner.zip:
val = self._prepare_field(