audrius/account-reconcile
1
0
Fork 1
mirror of https://github.com/OCA/account-reconcile.git synced 2025-01-20 12:27:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] account_move_so_import: simplify methods

Browse Source
This commit is contained in:
Hai Lang
2021-12-10 16:27:16 +07:00
committed by clementmbr
parent b0db768161
commit 2668f822a1
1 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
account_move_so_import/models/account_move.py
View File

@@ -39,20 +39,7 @@ class AccountMoveCompletionRule(models.Model):
...}
"""
res = {}
so_obj = self.env["sale.order"]
orders = so_obj.search([("name", "=", line.name)])
if len(orders) > 1:
raise ErrorTooManyPartner(
_(
'Line named "%s" was matched by more '
"than one partner while looking on SO by ref."
)
% line.name
)
if len(orders) == 1:
res["partner_id"] = orders[0].partner_id.id
return res
return self._get_from_name_and_so_generic(line, "name")
# Should be private but data are initialized with no update XML
def get_from_name_and_so_payment_ref(self, line):
@@ -68,13 +55,16 @@ class AccountMoveCompletionRule(models.Model):
...}
"""
return self._get_from_name_and_so_generic(line, "reference")
def _get_from_name_and_so_generic(self, line, search_by):
res = {}
so_obj = self.env["sale.order"]
orders = so_obj.search([("reference", "=", line.name)])
orders = so_obj.search([(search_by, "=", line.name)])
if len(orders) > 1:
raise ErrorTooManyPartner(
_(
'Line named "%s" was matched by more '
'Line named "%s" was matched by more '
"than one partner while looking on SO by ref."
)
% line.name