[FIX] account_credit_control: Test if invoice have credit control line in non draft state before deleting it

This commit is contained in:
Vincent Renaville
2013-09-12 16:39:17 +02:00
committed by Pedro M. Baeza
parent 59cd274f80
commit 7f6fcc5625
6 changed files with 85 additions and 0 deletions

View File

@@ -27,3 +27,4 @@ from . import policy
from . import company
from . import wizard
from . import report
from . import invoice

View File

@@ -363,6 +363,14 @@ msgstr ""
msgid "Lines marker"
msgstr "Lines marker"
#. module: account_credit_control
#: code:addons/account_credit_control/invoice.py:35
#, python-format
msgid "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
msgstr "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
#. module: account_credit_control
#: field:credit.control.printer,state:0
msgid "state"

View File

@@ -363,6 +363,14 @@ msgstr ""
msgid "Lines marker"
msgstr "Lines marker"
#. module: account_credit_control
#: code:addons/account_credit_control/invoice.py:35
#, python-format
msgid "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
msgstr "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
#. module: account_credit_control
#: field:credit.control.printer,state:0
msgid "state"

View File

@@ -368,6 +368,12 @@ msgstr "Lines marker"
msgid "state"
msgstr "state"
#. module: account_credit_control
#: code:addons/account_credit_control/invoice.py:35
#, python-format
msgid "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
msgstr "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
#. module: account_credit_control
#: field:credit.control.run,report:0
msgid "Report"

View File

@@ -345,6 +345,13 @@ msgstr ""
msgid "Lines marker"
msgstr "Traiter les lignes"
#. module: account_credit_control
#: code:addons/account_credit_control/invoice.py:35
#, python-format
msgid "You cannot cancel this invoice ! A payment reminder has already been sent to the customer.You must create a credit note and raise a new invoice."
msgstr "Vous ne pouvez pas annuler cette facture ! Une lettre de relance a été envoyé au client. Vous devez créer un avoir et établir une nouvelle facture."
#. module: account_credit_control
#: field:credit.control.printer,state:0
msgid "state"

View File

@@ -0,0 +1,55 @@
# -*- coding: utf-8 -*-
##############################################################################
#
# Author: Vincent Renaville
# Copyright 2013 Camptocamp SA
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as
# published by the Free Software Foundation, either version 3 of the
# License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU Affero General Public License for more details.
#
# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
#
##############################################################################
from openerp.osv import orm, fields
from openerp.tools.translate import _
class AccountInvoice(orm.Model):
"""Check on cancelling of an invoice"""
_inherit = 'account.invoice'
def action_cancel(self, cr, uid, ids, context=None):
# We will search if this invoice is linked with credit
credit_control_line_obj = self.pool.get('credit.control.line')
for invoice_id in ids:
credit_control_line_ids_nondraft = credit_control_line_obj.search(cr,
uid,
[('invoice_id', '=', invoice_id),
('state', '<>', 'draft')],context=context)
if credit_control_line_ids_nondraft:
raise orm.except_orm(_('Error!'),
_('You cannot cancel this invoice ! '
'A payment reminder has already been '
'sent to the customer.'
'You must create a credit note and raise a new invoice.'))
credit_control_line_ids_draft = credit_control_line_obj.search(cr,
uid,
[('invoice_id', '=', invoice_id),
('state', '=', 'draft')],context=context)
if credit_control_line_ids_draft:
credit_control_line_obj.unlink(cr,
uid,
credit_control_line_ids_draft,
context=context)
return super(AccountInvoice, self).action_cancel(cr,
uid,
ids,
context=context)