Finish 12.0 migration of account_asset_management

* account_asset: Do not loop on all the lines to search for one linked asset

Before this change, the use of `mapped` on self did loop on all the move
lines that are included in self to get the assets, what could be very
costly for a simple write on a lot of move lines. As the goal is to raise
an error only if at least one move is linked to an asset, we break the
loop if the condition is fulfilled.

* performance improvement

* [RMV] - Remove useless dependency

In 12.0 account_fiscal_year is a standard feature no need to depend on oca
module account_fiscal_year

account_asset_management/__manifest__.py

@@ -6,7 +6,7 @@
     'version': '12.0.1.0.0',
     'license': 'AGPL-3',
     'depends': [
-        'account_fiscal_year',
+        'account',
     ],
     'excludes': ['account_asset'],
     'author': "Noviat,Odoo Community Association (OCA)",

account_asset_management/models/account_move.py

@@ -116,15 +116,19 @@ class AccountMoveLine(models.Model):
     @api.multi
     def write(self, vals):
         if (
-            self.mapped('asset_id') and
             set(vals).intersection(FIELDS_AFFECTS_ASSET_MOVE_LINE) and
             not (
                 self.env.context.get('allow_asset_removal') and
                 list(vals.keys()) == ['asset_id'])
         ):
-            raise UserError(
-                _("You cannot change an accounting item "
-                  "linked to an asset depreciation line."))
+            # Check if at least one asset is linked to a move
+            linked_asset = False
+            for move in self:
+                linked_asset = move.asset_id
+                if linked_asset:
+                    raise UserError(
+                        _("You cannot change an accounting item "
+                          "linked to an asset depreciation line."))
         if vals.get('asset_id'):
             raise UserError(
                 _("You are not allowed to link "