[IMP] account_asset_management: Refinements

account_asset_management/models/account_asset.py

@@ -303,7 +303,7 @@ class AccountAsset(models.Model):
 
     @api.depends("profile_id")
     def _compute_group_ids(self):
-        for asset in self:
+        for asset in self.filtered("profile_id"):
             asset.group_ids = asset.profile_id.group_ids
 
     @api.depends("profile_id")

account_asset_management/models/account_asset_line.py

@@ -63,7 +63,8 @@ class AccountAssetLine(models.Model):
 
     @api.depends("amount", "previous_id", "type")
     def _compute_values(self):
-        processed_lines = self.browse()
+        self.depreciated_value = 0.0
+        self.remaining_value = 0.0
         dlines = self
         if self.env.context.get("no_compute_asset_line_ids"):
             # skip compute for lines in unlink
@@ -81,7 +82,6 @@ class AccountAssetLine(models.Model):
         grouped_dlines = []
         for asset in asset_ids:
             grouped_dlines.append(dlines.filtered(lambda l: l.asset_id.id == asset.id))
-
         for dlines in grouped_dlines:
             for i, dl in enumerate(dlines):
                 if i == 0:
@@ -94,11 +94,6 @@ class AccountAssetLine(models.Model):
                     remaining_value -= dl.amount
                 dl.depreciated_value = depreciated_value
                 dl.remaining_value = remaining_value
-                processed_lines |= dl
-        # Set unprocessed lines values
-        for line in self - processed_lines:
-            line.depreciated_value = 0.0
-            line.remaining_value = 0.0
 
     @api.depends("move_id")
     def _compute_move_check(self):

account_asset_management/models/account_asset_profile.py

@@ -178,9 +178,7 @@ class AccountAssetProfile(models.Model):
 
     @api.constrains("method", "method_time")
     def _check_method(self):
-        if self.filtered(
-            lambda a: a.method == "degr-linear" and a.method_time != "year"
-        ):
+        if any(a.method == "degr-linear" and a.method_time != "year" for a in self):
             raise UserError(
                 _("Degressive-Linear is only supported for Time Method = Year.")
             )