From a2e801a4409d908a71aed3216c483507f07758bb Mon Sep 17 00:00:00 2001 From: Sylvain LE GAL Date: Fri, 11 Dec 2020 11:28:52 +0100 Subject: [PATCH] [FIX] web_pwa_oca : do not raise an error if service workers is disabled (only log). Otherwise, odoo is unavailable in private mode with Firefox Browser --- web_pwa_oca/readme/ROADMAP.rst | 1 + web_pwa_oca/static/src/js/pwa_manager.js | 10 ++++++---- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/web_pwa_oca/readme/ROADMAP.rst b/web_pwa_oca/readme/ROADMAP.rst index d267ce12c..aa58b7b05 100644 --- a/web_pwa_oca/readme/ROADMAP.rst +++ b/web_pwa_oca/readme/ROADMAP.rst @@ -33,3 +33,4 @@ doesn't send the cookie and web manifest returns 404. * Evaluate to support 'require' system. * Firefox can't detect 'standalone' mode. See https://bugzilla.mozilla.org/show_bug.cgi?id=1285858 +* Firefox disable service worker in private mode. See https://bugzilla.mozilla.org/show_bug.cgi?id=1601916 diff --git a/web_pwa_oca/static/src/js/pwa_manager.js b/web_pwa_oca/static/src/js/pwa_manager.js index 72b6df020..143d5b9d9 100644 --- a/web_pwa_oca/static/src/js/pwa_manager.js +++ b/web_pwa_oca/static/src/js/pwa_manager.js @@ -17,11 +17,13 @@ odoo.define("web_pwa_oca.PWAManager", function (require) { init: function () { this._super.apply(this, arguments); if (!('serviceWorker' in navigator)) { - throw new Error( - _t("Service workers are not supported! Maybe you are not using HTTPS?")); + console.error( + _t("Service workers are not supported! Maybe you are not using HTTPS or you work in private mode.")); + } + else { + this._service_worker = navigator.serviceWorker; + this.registerServiceWorker('/service-worker.js'); } - this._service_worker = navigator.serviceWorker; - this.registerServiceWorker('/service-worker.js'); }, /**