audrius/web
1
0
Fork 1
mirror of https://github.com/OCA/web.git synced 2025-02-22 13:21:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

[IMP] web_drop_target: Avoid errors for undefined elements

Browse Source 
This changes are done to avoid errors in dms_field. This error is
found using this other PR: https://github.com/OCA/dms/pull/310

The steps to reproduce the error are:
1. Create a directory or a file without using drag and drop
2. Drag and drop a file into a folder and you will see the error
This commit is contained in:
Carlos Roca
2024-03-08 14:20:23 +01:00
parent dac33645f2
commit 81fcf6cce1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web_drop_target/static/src/js/web_drop_target.js
View File

@@ -155,7 +155,7 @@ odoo.define("web_drop_target", function (require) {
const abstractAction = this.findAncestor(function (ancestor) { const abstractAction = this.findAncestor(function (ancestor) {
return ancestor instanceof AbstractAction; return ancestor instanceof AbstractAction;
}); });
const controller = abstractAction.currentDialogController; const controller = abstractAction && abstractAction.currentDialogController;
if ( if (
_.isEmpty(this._get_drop_items(ev)) && _.isEmpty(this._get_drop_items(ev)) &&
this._checkDragOver() && this._checkDragOver() &&
@@ -186,7 +186,9 @@ odoo.define("web_drop_target", function (require) {
*/ */
_onBodyFileDrop: function (ev) { _onBodyFileDrop: function (ev) {
ev.preventDefault(); ev.preventDefault();
if (this._drop_overlay) {
this._drop_overlay.addClass("d-none"); this._drop_overlay.addClass("d-none");
}
}, },
/** /**