From ba01afa4982f0bfa87c1d52945312b6b2cbdc16f Mon Sep 17 00:00:00 2001 From: Jared Kipe Date: Tue, 1 Feb 2022 14:03:44 -0800 Subject: [PATCH] [FIX] hr_commission: filter to sales invoices Additionally, don't require salesperson (e.g. commission structure or timesheets) --- hr_commission/models/commission.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hr_commission/models/commission.py b/hr_commission/models/commission.py index 0343b6a8..24a2c287 100644 --- a/hr_commission/models/commission.py +++ b/hr_commission/models/commission.py @@ -99,7 +99,7 @@ class Commission(models.Model): return super(Commission, self).unlink() def _filter_source_moves_for_creation(self, moves): - return moves.filtered(lambda i: i.user_id and not i.commission_ids) + return moves.filtered(lambda i: i.is_sale_document() and not i.commission_ids) def _commissions_to_confirm(self, moves): commissions = moves.mapped('commission_ids') @@ -120,7 +120,7 @@ class Commission(models.Model): if commission_structure: commission_structure.create_for_source_move(move, move_amount) - else: + elif move.user_id: employee = employee_obj.search([('user_id', '=', move.user_id.id)], limit=1) contract = employee.contract_id if all((employee, contract, contract.commission_rate)):