From aaa31092ee8684f6e8cab4519c58b0152689b7e1 Mon Sep 17 00:00:00 2001
From: Jared Kipe <jared@hibou.io>
Date: Tue, 22 Mar 2022 17:01:12 +0000
Subject: [PATCH] [FIX] hr_commission,hr_payroll_commission: fix linking
 commission payment

Additionally `hr_commission`: test archive contracts in case someone moves one to running
---
 hr_commission/tests/test_commission.py | 2 ++
 hr_commission/views/account_views.xml  | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hr_commission/tests/test_commission.py b/hr_commission/tests/test_commission.py
index 1d15ef70..021652e7 100644
--- a/hr_commission/tests/test_commission.py
+++ b/hr_commission/tests/test_commission.py
@@ -10,6 +10,8 @@ class TestCommission(common.TransactionCase):
         super().setUp()
         self.user = self.browse_ref('base.user_demo')
         self.employee = self.browse_ref('hr.employee_qdp')  # This is the employee associated with above user.
+        # arcive all current contracts
+        self.employee.contract_ids.write({'active': False})
 
     def _createUser(self):
         return self.env['res.users'].create({
diff --git a/hr_commission/views/account_views.xml b/hr_commission/views/account_views.xml
index ec9e4836..a0a100d9 100644
--- a/hr_commission/views/account_views.xml
+++ b/hr_commission/views/account_views.xml
@@ -20,8 +20,8 @@
         <field name="model">account.journal</field>
         <field name="inherit_id" ref="account.view_account_journal_form"/>
         <field name="arch" type="xml">
-            <xpath expr="//field[@name='default_account_id' and @attrs=&quot;{'required': [('type', '=', 'purchase')], 'invisible': [('type', '!=', 'purchase')]}&quot;]" position="attributes">
-                <attribute name="attrs">{'required': [('type', '=', 'purchase')], 'invisible': [('type', 'not in', ('purchase', 'general'))]}</attribute>
+            <xpath expr="//field[@name='default_account_type']" position="after">
+                <field name="default_account_id" string="Default Account" attrs="{'invisible': [('type', '!=', 'general')]}" groups="account.group_account_readonly"/>
             </xpath>
         </field>
     </record>