From a2953c59a7d868e1c1d6d217757fde598ee34652 Mon Sep 17 00:00:00 2001
From: Jorge Che <jorge@hibou.pe>
Date: Fri, 7 Oct 2022 23:59:56 +0000
Subject: [PATCH] [FIX] hr_commission: refactor readonly logic for
 no_commission field

H11044
---
 hr_commission/models/product_template.py |  6 ------
 hr_commission/views/product_views.xml    | 19 +++++++++++++++----
 2 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/hr_commission/models/product_template.py b/hr_commission/models/product_template.py
index 9a8ca77e..6278552b 100644
--- a/hr_commission/models/product_template.py
+++ b/hr_commission/models/product_template.py
@@ -5,9 +5,3 @@ class ProductTemplate(models.Model):
     _inherit = 'product.template'
 
     no_commission = fields.Boolean('Exclude from Commissions')
-    can_edit_no_commission = fields.Boolean(compute='_compute_can_edit_no_commission')
-
-    def _compute_can_edit_no_commission(self):
-        can_edit = self.env.user.has_group('account.group_account_user')
-        for template in self:
-            template.can_edit_no_commission = can_edit
diff --git a/hr_commission/views/product_views.xml b/hr_commission/views/product_views.xml
index 656f8f0f..7839df65 100644
--- a/hr_commission/views/product_views.xml
+++ b/hr_commission/views/product_views.xml
@@ -7,11 +7,22 @@
         <field name="inherit_id" ref="product.product_template_form_view"/>
         <field name="arch" type="xml">
             <xpath expr="//div[@name='options']" position="inside">
-                <field name="can_edit_no_commission" invisible="1"/>
                 <span class="d-inline-block">
-                            <field name="no_commission" attrs="{'readonly': [('can_edit_no_commission', '=', False)]}"/>
-                            <label for="no_commission"/>
-                        </span>
+                    <field name="no_commission" readonly="1"/>
+                    <label for="no_commission"/>
+                </span>
+            </xpath>
+        </field>
+    </record>
+
+    <record id="product_template_form_view_manager" model="ir.ui.view">
+        <field name="name">product.template.common.form.inherit.manager</field>
+        <field name="model">product.template</field>
+        <field name="inherit_id" ref="product.product_template_form_view"/>
+        <field name="groups_id" eval="[(4, ref('account.group_account_user'))]"/>
+        <field name="arch" type="xml">
+            <xpath expr="//field[@name='no_commission']" position="attributes">
+                <attribute name="readonly">0</attribute>
             </xpath>
         </field>
     </record>