From 287e873da8d07f4672fdb0e1cfe08f52bfcd4849 Mon Sep 17 00:00:00 2001 From: Jared Kipe Date: Sun, 1 Aug 2021 16:57:36 -0700 Subject: [PATCH 1/2] [IMP] connector_opencart: only service products have empty shipping details --- connector_opencart/models/sale_order/importer.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/connector_opencart/models/sale_order/importer.py b/connector_opencart/models/sale_order/importer.py index 839eab49..3423da00 100644 --- a/connector_opencart/models/sale_order/importer.py +++ b/connector_opencart/models/sale_order/importer.py @@ -287,6 +287,10 @@ class SaleOrderImporter(Component): def _import_addresses(self): partner_values = self._get_partner_values() + # If they only buy services, then the shipping details will be empty + if not partner_values['name'] == 'Undefined': + partner_values = self._get_partner_values(info_string='payment_') + partners = self.env['res.partner'].search([ ('email', '=ilike', partner_values['email']), '|', ('active', '=', False), ('active', '=', True), From 4fd6ba05a3133898e5a02b55e0fe1b84eb19befb Mon Sep 17 00:00:00 2001 From: Jared Kipe Date: Sun, 1 Aug 2021 17:15:57 -0700 Subject: [PATCH 2/2] [FIX] connector_opencart: incorrect boolean --- connector_opencart/models/sale_order/importer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/connector_opencart/models/sale_order/importer.py b/connector_opencart/models/sale_order/importer.py index 3423da00..312e9e11 100644 --- a/connector_opencart/models/sale_order/importer.py +++ b/connector_opencart/models/sale_order/importer.py @@ -288,7 +288,7 @@ class SaleOrderImporter(Component): def _import_addresses(self): partner_values = self._get_partner_values() # If they only buy services, then the shipping details will be empty - if not partner_values['name'] == 'Undefined': + if partner_values.get('name', 'Undefined') == 'Undefined': partner_values = self._get_partner_values(info_string='payment_') partners = self.env['res.partner'].search([