From 6a5f47fc4abc7ea57691b672726aeb6b292034b1 Mon Sep 17 00:00:00 2001
From: Milan <milan@hibou.io>
Date: Tue, 5 Nov 2024 02:20:02 +0100
Subject: [PATCH] [MIG] maintenance_repair: migrate to 17.0

---
 maintenance_repair/__manifest__.py            |  2 +-
 maintenance_repair/models/maintenance.py      | 26 +++++++++----------
 .../views/maintenance_views.xml               | 14 +++++-----
 3 files changed, 20 insertions(+), 22 deletions(-)

diff --git a/maintenance_repair/__manifest__.py b/maintenance_repair/__manifest__.py
index ef6320f8..58faf7a4 100644
--- a/maintenance_repair/__manifest__.py
+++ b/maintenance_repair/__manifest__.py
@@ -1,6 +1,6 @@
 {
     'name': 'Equipment Repair',
-    'version': '16.0.1.0.0',
+    'version': '17.0.1.0.0',
     'author': 'Hibou Corp. <hello@hibou.io>',
     'category': 'Human Resources',
     'summary': 'Consume products on Maintenance Requests',
diff --git a/maintenance_repair/models/maintenance.py b/maintenance_repair/models/maintenance.py
index dc7ebade..0bd4be13 100644
--- a/maintenance_repair/models/maintenance.py
+++ b/maintenance_repair/models/maintenance.py
@@ -28,9 +28,9 @@ class MaintenanceRequest(models.Model):
         ], string='Repair Status', compute='_get_repaired', store=True, readonly=True)
     repair_location_id = fields.Many2one('stock.location', string='Source Location')
     repair_location_dest_id = fields.Many2one('stock.location', string='Destination Location')
-    total_lst_price = fields.Float(string='Total Price', compute='_compute_repair_totals', stored=True)
-    total_standard_price = fields.Float(string='Total Est. Cost', compute='_compute_repair_totals', stored=True)
-    total_cost = fields.Float(string='Total Cost', compute='_compute_repair_totals', stored=True)
+    total_lst_price = fields.Float(string='Total Price', compute='_compute_repair_totals', store=True)
+    total_standard_price = fields.Float(string='Total Est. Cost', compute='_compute_repair_totals', store=True)
+    total_cost = fields.Float(string='Total Cost', compute='_compute_repair_totals', store=True)
 
     @api.depends('repair_line_ids.lst_price', 'repair_line_ids.standard_price', 'repair_line_ids.cost')
     def _compute_repair_totals(self):
@@ -64,23 +64,20 @@ class MaintenanceRequest(models.Model):
 
 class MaintenanceRequestRepairLine(models.Model):
     _name = 'maintenance.request.repair.line'
+    _description = 'Maintenance Request Repair Lines'
 
     request_id = fields.Many2one('maintenance.request', copy=False)
-    product_id = fields.Many2one('product.product', 'Product', required=True,
-                                 states={'done': [('readonly', True)]})
-    product_uom_qty = fields.Float('Quantity', default=1.0,
-                                   digits=dp.get_precision('Product Unit of Measure'), required=True,
-                                   states={'done': [('readonly', True)]})
-    product_uom_id = fields.Many2one('uom.uom', 'Product Unit of Measure', required=True,
-                                     states={'done': [('readonly', True)]})
+    product_id = fields.Many2one('product.product', 'Product', required=True)
+    product_uom_qty = fields.Float('Quantity', default=1.0, digits='Product Unit of Measure', required=True)
+    product_uom_id = fields.Many2one('uom.uom', 'Product Unit of Measure', required=True)
     state = fields.Selection([
         ('draft', 'Draft'),
         ('done', 'Done'),
     ], string='State', copy=False, default='draft')
     move_id = fields.Many2one('stock.move', string='Stock Move')
-    lst_price = fields.Float(string='Sale Price', states={'done': [('readonly', True)]})
-    standard_price = fields.Float(string='Est. Cost', states={'done': [('readonly', True)]})
-    cost = fields.Float(string='Cost', compute='_compute_actual_cost', stored=True)
+    lst_price = fields.Float(string='Sale Price')
+    standard_price = fields.Float(string='Est. Cost')
+    cost = fields.Float(string='Cost', compute='_compute_actual_cost', store=True)
     
     def unlink(self):
         if self.filtered(lambda l: l.state == 'done'):
@@ -129,7 +126,8 @@ class MaintenanceRequestRepairLine(models.Model):
             if move.state != 'assigned':
                 raise ValidationError(_('Unable to reserve inventory.'))
 
-            move.quantity_done = line.product_uom_qty
+            move.quantity = line.product_uom_qty
+            move.picked = True
             move._action_done()
             if move.state != 'done':
                 raise ValidationError(_('Unable to move inventory.'))
diff --git a/maintenance_repair/views/maintenance_views.xml b/maintenance_repair/views/maintenance_views.xml
index b875f5f5..adb8332e 100644
--- a/maintenance_repair/views/maintenance_views.xml
+++ b/maintenance_repair/views/maintenance_views.xml
@@ -20,7 +20,7 @@
             <xpath expr="//button[@name='archive_equipment_request']" position="before">
                 <field name="repair_status" invisible="1"/>
                 <button type="object" name="action_complete_repair" string="Complete Repair" class="oe_highlight"
-                        attrs="{'invisible': [('repair_status', '!=', 'to repair')]}"/>
+                        invisible="repair_status != 'to repair'"/>
             </xpath>
         </field>
     </record>
@@ -45,14 +45,14 @@
                     <field name="repair_line_ids">
                         <tree editable="bottom" string="Part Operations" colors="blue:state=='draft'">
                             <field name="state" invisible="1"/>
-                            <field name="product_id" domain="[('type', 'in', ['product', 'consu'])]"/>
-                            <field name="product_uom_id"/>
-                            <field name="product_uom_qty"/>
-                            <field name="lst_price"/>
-                            <field name="standard_price" groups="account.group_account_user"/>
+                            <field name="product_id" domain="[('type', 'in', ['product', 'consu'])]" readonly="state == 'done'"/>
+                            <field name="product_uom_id" readonly="state == 'done'"/>
+                            <field name="product_uom_qty" readonly="state == 'done'"/>
+                            <field name="lst_price" readonly="state == 'done'"/>
+                            <field name="standard_price" groups="account.group_account_user" readonly="state == 'done'"/>
                             <field name="cost" groups="account.group_account_user"/>
                             <button type="object" name="action_complete" string="Complete" class="oe_highlight"
-                                    attrs="{'invisible': [('state', '=', 'done')]}"/>
+                                    invisible="state == 'done'"/>
                         </tree>
                     </field>