From 50da6a7bbb1ca8dcc3c1425e9bd5420ce391e616 Mon Sep 17 00:00:00 2001
From: Jared Kipe <jared@hibou.io>
Date: Wed, 15 Aug 2018 13:35:20 -0700
Subject: [PATCH] Guard against 0 New Jersey WorkForce rate. Remove broken New
 York test.

---
 l10n_us_nj_hr_payroll/data/rules_2018.xml         |  3 +++
 .../tests/test_us_ny_payslip_2018.py              | 15 ---------------
 2 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/l10n_us_nj_hr_payroll/data/rules_2018.xml b/l10n_us_nj_hr_payroll/data/rules_2018.xml
index 0641e08f..c581bd9a 100755
--- a/l10n_us_nj_hr_payroll/data/rules_2018.xml
+++ b/l10n_us_nj_hr_payroll/data/rules_2018.xml
@@ -201,6 +201,9 @@ else:
         <field name="amount_python_compute">
 result_rate = -contract.nj_wf_rate(2018)
 result = categories.NJ_WF_WAGES
+
+if result_rate == 0.0:
+  result = 0.0
         </field>
         <field name="register_id" ref="contrib_register_njdor_wf"/>
         <field name="appears_on_payslip" eval="False"/>
diff --git a/l10n_us_ny_hr_payroll/tests/test_us_ny_payslip_2018.py b/l10n_us_ny_hr_payroll/tests/test_us_ny_payslip_2018.py
index 48271fc3..5c650b91 100755
--- a/l10n_us_ny_hr_payroll/tests/test_us_ny_payslip_2018.py
+++ b/l10n_us_ny_hr_payroll/tests/test_us_ny_payslip_2018.py
@@ -150,18 +150,3 @@ class TestUsNYPayslip(TestUsPayslip):
 
         self.assertPayrollEqual(cats['NY_WITHHOLD'], wh)
 
-    def test_tax_exempt(self):
-        schedule_pay = 'monthly'
-
-        wh = 0.0
-
-        employee = self._createEmployee()
-
-        contract = self._createContract(employee,
-                                        salary,
-                                        struct_id=self.ref(
-                                            'l10n_us_ny_hr_payroll.hr_payroll_salary_structure_us_ny_employee'),
-                                        schedule_pay=schedule_pay)
-        contract.ny_it2104_filing_status = 'exempt'
-
-        self.assertPayrollEqual(cats['NY_WITHHOLD'], wh)