Commit Graph

24 Commits

Author SHA1 Message Date
Joan Sisquella
fad3ab7a79 [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2023-05-30 17:39:08 +02:00
Lois Rilo
d62bcca3ec [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2023-02-21 14:59:36 +01:00
Stefan Rijnhart
cdafac7a61 [IMP] rma: prevent the creation of zero qty moves 2022-07-11 09:11:05 +02:00
Christopher Ormaza
07645ab72b [IMP] write method replaced for backported implementation 2022-03-07 08:23:17 -05:00
Lois Rilo
7b7a8b4f2b [FIX] rma: do not force reservation on supplier RMA deliveries 2022-03-07 07:44:40 -05:00
Lois Rilo
6275b23ceb [UPD] pre-commit 2022-02-10 13:46:46 +01:00
Christopher Ormaza
13e3a4bf77 [FIX] rma: add lot to pickings created from wizard on RMA lines 2022-02-10 13:40:20 +01:00
hveficent
74052f4dd8 RMA as an APP 2020-01-20 12:46:08 +01:00
ahenriquez
f3c1a1c438 [MIG] rma: Migration to 13.0 2020-01-17 18:03:43 +01:00
ahenriquez
1ae40ec4d3 [IMP] : black, isort 2020-01-14 16:36:03 +01:00
mreficent
6f6f5d7b32 [FIX] default_gets: avoid using shadowname 'fields' 2020-01-14 16:35:27 +01:00
Adrià Gil Sorribes
4395bc3b1f [12.0][MIG] Migrate rma module to v12.0 2020-01-14 16:35:27 +01:00
aheficent
1ba0c77f0c [MIG]rma v110.0.2.0.0 2020-01-14 16:35:27 +01:00
Bhavesh Odedra
f45ccd1688 [FIX] TypeError: unhashable type: 'list' 2020-01-14 16:35:26 +01:00
Jordi Ballester
e3de350b91 multiple fixes 2020-01-14 16:35:26 +01:00
Maxime Chambreuil
0f0558b88f [FIX] Errors from tests 2020-01-14 16:35:26 +01:00
Maxime Chambreuil
854d9ec537 [MIG] Migrate configuration and cleanup 2020-01-14 16:35:26 +01:00
Maxime Chambreuil
94135ff5fa [FIX] Permissions and remove (en)coding 2020-01-14 16:35:26 +01:00
Bhavesh Odedra
ae0a75499a [11.0] MIG: RMA module 2020-01-14 16:35:26 +01:00
Nikul Chaudhary
e161a9c57a [IMP] Improved Unit Test Case and Fixed Travis 2020-01-14 16:35:26 +01:00
aheficent
31ebd47872 [MIG]rma v10 2020-01-14 16:35:26 +01:00
lreficent
a82f603497 [9.0][REW] rma: workflow centralized on rma.order.line and the use of rma.order is optional. 2020-01-14 16:35:26 +01:00
lreficent
539be323ef [9.0][FIX] rma:
* fix assignment of moves.
* default qty in rma lines.
* remove account dependency.
* test and flake8 fixes.
2020-01-14 16:35:26 +01:00
Jordi Ballester
8939fc8c7a init branch 2020-01-14 16:35:26 +01:00