Commit Graph

61 Commits

Author SHA1 Message Date
Christopher Ormaza
ea4386f51e [14.0][FIX] rma, add support to handle package used on customer moves 2024-05-23 10:58:27 -05:00
Christopher Ormaza
95a312fcda [FIX] quants can be more than one on _gather function result 2023-10-30 15:20:28 +01:00
BernatPForgeFlow
1461115608 [IMP] rma: Auto-calculate package for serial products
When returning or delivering a serial product from a RMA, we will calculate by default its package. Later, it can be modyfied by the user.
2023-10-30 15:20:28 +01:00
ChrisOForgeFlow
c4f9912425 [14.0][IMP] added default operation on rma group, easy setup before rma lines created (#452)
* [14.0][IMP] added default operation on rma group, easy setup before rma lines created

* [IMP] added fields for default route created by wizard on rma group

* fix: get right price after create rma order line
2023-10-27 12:41:54 +00:00
Joan Sisquella
6764221ee2 [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2023-05-29 16:32:42 +02:00
Lois Rilo
9f145d7d31 [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2023-02-21 11:31:47 +01:00
DavidJForgeFlow
508210e178 [14.0][FIX] rma: add stock move in supplier group 2023-02-01 13:15:04 +01:00
Lois Rilo
f1f69f6335 [IMP] rma: add description to rma order and copy it over to new lines 2023-01-03 08:34:02 +01:00
Lois Rilo
42422798ae [IMP] rma: rma group supplier form view as a inherited view.
The goal is to simplify view defintion and do not duplicate
things, requiring to do view changes in two places.

The same change was done from rma lines some time ago.
2023-01-02 10:27:25 +01:00
Lois Rilo
f88c92be0a [FIX] rma: Ensure that configuration on the operation is applied
Without this, some policies are not being copied from the
operation selected when creating new rma line from a rma group.

In v16 this patch and the usage of such onchange can be removed
in favor of (pre)computed stored editable fields for all policies
and configuration in the RMA operation.
2022-12-28 13:11:19 +01:00
Jordi Ballester Alomar
dd29c431e9 [FIX] fix rma management using multi step routes 2022-11-24 18:04:05 +01:00
Jordi Ballester Alomar
6eccbbbaab Merge pull request #291 from ForgeFlow/14.0-fp-264
[14.0][IMP] rma: prevent the creation of zero qty moves
2022-07-26 18:29:38 +02:00
Lois Rilo
94380a16b4 Merge pull request #283 from akretion/14-rma-line-simple-view
[14.0][IMP] Make rma order line view cleaner for user
2022-07-15 11:34:30 +02:00
Stefan Rijnhart
54887ed141 [IMP] rma: prevent the creation of zero qty moves 2022-07-11 09:26:49 +02:00
Stefan Rijnhart
2abf2f08d3 [FIX] rma: improve check on rule selection during procurement
Fixes #274

Thanks to @florian-dacosta for suggesting this approach.
2022-06-24 13:44:21 +02:00
Florian da Costa
a248d56c8d [IMP] Make rma order view cleaner for user
Hide button and fields depending on the policy chosen on the rma line
2022-06-24 10:56:42 +02:00
Stefan Rijnhart
e8b7c07718 [FIX] rma: prevent against warehouse mismatch or missing rules
When creating pickings, ensure that the applied stock rule was taken from
the operation's routes. Otherwise, the default procurement rules for a
warehouse may kick in, creating incoming customer goods not from the customer
location but from the resupply warehouse.
2022-06-16 11:26:03 +02:00
Lois Rilo
68cceda783 [IMP] rma: add rma lines to group selecting serial numbers 2022-05-25 10:49:52 +02:00
Florian da Costa
d88c27097f [FIX] Remove useless/bad wiz_id field in rma_make_picking.wizard item preparation 2022-05-03 10:06:43 +02:00
Lois Rilo
3d416d3a05 [FIX] rma: do not force reservation on supplier RMA deliveries
* remove code call to unexisting `force_asign`.
* only one model per model file and rename as appropriate.
2022-03-04 12:45:45 +01:00
Christopher Ormaza
f0e912c348 [FIX] rma: add lot to pickings created from wizard on RMA lines 2022-02-10 13:30:52 +01:00
Christopher Ormaza
f58aeeae21 [IMP] rma, rma_sale: added select all, messages for UX 2022-02-03 14:29:01 +01:00
Christopher Ormaza
0ee79c30ed [IMP] rma: Added serial/lot selection on from stock move wizard on rma groups
- added restriction to approve rma with product tracking on serial, should be only one to receive
2022-02-03 14:28:29 +01:00
Lois Rilo
669d9e24a4 [14.0][MIG] rma*: ir.actions.act_window has different access
right in v14. Actions that read those records need to use
`sudo` to allow non-admin users to be able to use these actions.
2021-04-16 13:07:38 +02:00
Lois Rilo
c800b0a444 [IMP] rma: Do not highlight all action buttons and simplify
rma.line views, supplier view is an extension of customer one.

This makes easier to edit common elements in both views and ease
maintenance.
2021-03-26 11:59:59 +01:00
Mateu Griful
c37acc939d [FIX] rma: Create rma supplier action 2021-01-18 09:29:25 +01:00
Mateu Griful
b823731f84 [MIG] rma: Migration to 14.0 - fix 2021-01-13 09:49:14 +01:00
Mateu Griful
cd88128ca4 [MIG] rma: Migration to 14.0 - fix 2021-01-12 18:13:54 +01:00
Mateu Griful
ca605a5bbd [MIG] rma: Migration to 14.0 - fix 2021-01-12 16:54:43 +01:00
Mateu Griful
165191168d [MIG] rma: Migration to 14.0 2020-12-28 12:25:51 +01:00
Mateu Griful
a301a4f454 [IMP] rma: black, isort, prettier 2020-12-24 16:59:14 +01:00
HviorForgeFlow
8b6020a325 [IMP] Update pre-commit lints according with OCA ones 2020-12-24 16:59:14 +01:00
hveficent
5601b90701 RMA as an APP 2020-12-24 16:59:14 +01:00
ahenriquez
b3e5f67086 [MIG] rma: Migration to 13.0 2020-12-24 16:59:14 +01:00
ahenriquez
0cfa4e14a5 [IMP] : black, isort 2020-12-24 16:59:14 +01:00
mreficent
443a1a351b [FIX] default_gets: avoid using shadowname 'fields' 2020-12-24 16:59:14 +01:00
Aaron Henriquez
e93b621c33 [FIX]wizard to create pickings, not to show rma groups if rma groups are not activated 2020-12-24 16:59:14 +01:00
Akim Juillerat
bb69f197d8 [FIX] Remove picking_id from default_get as model does not define it 2020-12-24 16:59:14 +01:00
Akim Juillerat
4cd6d547c1 rma: Fix stock_location res.groups 2020-12-24 16:59:14 +01:00
Adrià Gil Sorribes
5a2ca634c2 [12.0][MIG] Migrate rma module to v12.0 2020-12-24 16:59:14 +01:00
aheficent
121c038c2b [FIX]text on create supplier rma button 2020-12-24 16:59:14 +01:00
aheficent
c67dd31159 [IMP] add group to manage rma groups 2020-12-24 16:59:14 +01:00
aheficent
d5b201d5dc [FIX]views rma 2020-12-24 16:59:14 +01:00
aheficent
99d4651453 [MIG]rma v110.0.2.0.0 2020-12-24 16:59:14 +01:00
Bhavesh Odedra
2883b275fe [FIX] TypeError: unhashable type: 'list' 2020-12-24 16:59:14 +01:00
Bhavesh Odedra
c47f6f7521 [IMP] Various improvements 2020-12-24 16:59:14 +01:00
Jordi Ballester
e8ddd7b31f multiple fixes 2020-12-24 16:59:14 +01:00
Maxime Chambreuil
7ffc1b77a3 [FIX] Errors from tests 2020-12-24 16:59:14 +01:00
Maxime Chambreuil
5fb6c8e1f3 [MIG] Migrate configuration and cleanup 2020-12-24 16:59:14 +01:00
Maxime Chambreuil
13edda084a [FIX] Permissions and remove (en)coding 2020-12-24 16:59:14 +01:00