Commit Graph

39 Commits

Author SHA1 Message Date
Florian da Costa
f05e4037f2 [IMP] rma : propagate cancelation
When canceling a rma order line, it will also cancel the previous (orig) steps.
Following steps (dest) can be managed with the propagate cancel option of the stock rules.
This commit also avoid canceling a whole picking which is problematic in case of the use of RMA groups
2024-09-26 11:30:32 +02:00
chafique.delli
c683e32b34 [16.0][IMP] rma: rma group state 2024-04-16 09:42:56 +02:00
Joan Sisquella
2feb96db80 [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2023-05-30 15:49:37 +02:00
DavidJForgeFlow
f64804dfed [FIX] rma: deprecated test warning fix 2023-02-22 15:25:47 +01:00
Florian da Costa
2559cb4660 [16.0][MIG] Migrate rma module to v16 2022-11-28 16:24:49 +01:00
DavidJForgeFlow
284891c09b [15.0][FIX] rma_sale: fixup of procurement 2022-11-28 16:11:02 +01:00
Stefan Rijnhart
60a9d6decb [IMP] rma: prevent the creation of zero qty moves 2022-11-28 16:11:02 +01:00
DavidJForgeFlow
41ab6e0d52 [FIX]rma: remove test_rma dependency to Account 2022-11-28 16:11:02 +01:00
Stefan Rijnhart
cddf72d6c0 [FIX] rma: prevent against warehouse mismatch or missing rules
When creating pickings, ensure that the applied stock rule was taken from
the operation's routes. Otherwise, the default procurement rules for a
warehouse may kick in, creating incoming customer goods not from the customer
location but from the resupply warehouse.
2022-11-28 16:11:02 +01:00
DavidFIB
d328e17e6f [14.0][FIX/IMP] Make RMA Operation settings company dependent 2022-11-28 16:11:02 +01:00
Andrea
06c7a1d01e [13.0][FIX/IMP] Make RMA Operation settings company dependent 2022-11-28 16:11:02 +01:00
AaronHForgeFlow
e632e0faf7 [15.0][IMP] Tests for stock valuation
[FIX] rma: rma_custmer_user has no write permissions in partner, so compute method fails.
[IMP] rma: use rma user in tests
[FIX] rma_account: move_line_id field string
[IMP] rma, rma_account, rma_sale, rma_purchase: tests for stock valuation
[FIX] account_move_line_rma_order_line: minor lint, make auto-install
2022-11-28 16:11:02 +01:00
AaronHForgeFlow
df52ec86f6 [IMP] COPIER UPDATE: black, isort, prettier 2022-11-28 16:11:02 +01:00
Jordi Ballester
3c51940502 [FIX] rma: compute out_shipment_count correctly. Add test cases 2022-11-28 16:11:02 +01:00
Jasmin Solanki
7bc8ca36b1 [MIG] rma: Migration to 15.0 2022-11-28 16:11:02 +01:00
Mateu Griful
b40700573b [MIG] rma_account: Migration to 14.0 2022-11-28 16:11:02 +01:00
Mateu Griful
c8d492814b [MIG] rma: Migration to 14.0 - fix 2022-11-28 16:11:02 +01:00
Mateu Griful
b7c138f31b [MIG] rma: Migration to 14.0 - fix 2022-11-28 16:11:02 +01:00
Mateu Griful
8c1d65614b [MIG] rma: Migration to 14.0 2022-11-28 16:11:02 +01:00
ahenriquez
8b202f9b97 [MIG] rma: Migration to 13.0 2022-11-28 16:11:02 +01:00
ahenriquez
e0c8c99df4 [IMP] : black, isort 2022-11-28 16:11:02 +01:00
mreficent
5509ab6bcb [FIX] tests 2022-11-28 16:11:02 +01:00
Adrià Gil Sorribes
6716a34b7b [12.0][MIG] Migrate rma module to v12.0 2022-11-28 16:11:02 +01:00
aheficent
6603cae01e [FIX]rma test 2022-11-28 16:11:02 +01:00
aheficent
2fd985f591 [FIX]views rma 2022-11-28 16:11:02 +01:00
Lois Rilo
5606be6d2d [9.0][IMP] rma: tests moved to Savedpointcase and optimized (66% time reduction) 2022-11-28 16:11:02 +01:00
Jordi Ballester
bcb9122649 multiple fixes 2022-11-28 16:11:02 +01:00
Maxime Chambreuil
3c74ad1414 [FIX] Errors from tests 2022-11-28 16:11:02 +01:00
Maxime Chambreuil
7171fabb30 [MIG] Migrate configuration and cleanup 2022-11-28 16:11:02 +01:00
Maxime Chambreuil
6e787bc3e0 [FIX] Permissions and remove (en)coding 2022-11-28 16:11:02 +01:00
Bhavesh Odedra
178e2e6bae [11.0] MIG: RMA module 2022-11-28 16:11:02 +01:00
Nikul Chaudhary
55bfe2c212 [IMP] Improved Code. 2022-11-28 16:11:02 +01:00
Nikul Chaudhary
5cd5c94d2d [MIG] Migrated UT & Fixed Travis 2022-11-28 16:11:02 +01:00
aheficent
1be900caf3 [FIX]various fixes 2022-11-28 16:11:02 +01:00
Nikul Chaudhary
2f1fba7594 [IMP] Improved Unit Test Case and Fixed Travis 2022-11-28 16:11:02 +01:00
aheficent
ca540457d6 [MIG]rma v10 2022-11-28 16:11:02 +01:00
aheficent
fdd243623f [IMP] default operation in product and product_categ for customer and supplier
[IMP]Separate menus for customer and supplier operations
* Add active field to rma operation
* Added tests
* Fix travis
* Fix create supplier rma from customer rma
2022-11-28 16:11:02 +01:00
lreficent
0d4c438e26 [9.0][FIX] rma:
* fix assignment of moves.
* default qty in rma lines.
* remove account dependency.
* test and flake8 fixes.
2022-11-28 16:11:02 +01:00
Jordi Ballester
51d233bca8 init branch 2022-11-28 16:11:02 +01:00