Commit Graph

155 Commits

Author SHA1 Message Date
Lois Rilo
37088edc47 [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2023-02-21 15:06:38 +01:00
Lois Rilo
54ebbedf83 Merge pull request #372 from ForgeFlow/16.0-fp-367
[16.0][FIX] rma: add stock move in supplier group
2023-02-21 14:51:35 +01:00
Lois Rilo
41541b4f10 Merge pull request #339 from akretion/16.0-fix-migration
[16][FIX] rma: Refactor onchange fields to computed fields (partial)
2023-02-17 09:39:26 +01:00
Florian da Costa
71df4774e8 [FIX] Move some field from onchange to compute fields to avoid issues in views 2023-02-17 09:29:11 +01:00
DavidJForgeFlow
00730ce592 [14.0][FIX] rma: add stock move in supplier group 2023-02-10 11:52:42 +01:00
Lois Rilo
88cf15ffba [FIX] rma: remove "Add new line" in RMA group.
This was not the intended way to add RMA lines to a group.
Users are supposed to use the wizards to do so (add from stock
move, add from serial, etc.). Having the option to use "add
new line" was only leading to errors and confusion.
2023-01-09 17:19:51 +01:00
Lois Rilo
b15c796dcb [IMP] rma: print serial/lot number in RMA group report 2023-01-09 17:19:43 +01:00
Lois Rilo
76f57a08c9 [IMP] rma: order by id desc 2023-01-09 17:19:34 +01:00
Lois Rilo
79e1c5c2eb [IMP] rma: add description to rma order and copy it over to new lines 2023-01-09 17:19:24 +01:00
Lois Rilo
15f5819a8f [IMP] rma: rma group supplier form view as a inherited view.
The goal is to simplify view defintion and do not duplicate
things, requiring to do view changes in two places.

The same change was done from rma lines some time ago.
2023-01-09 17:19:13 +01:00
Lois Rilo
c975fb1464 [FIX] rma: Ensure that configuration on the operation is applied
Without this, some policies are not being copied from the
operation selected when creating new rma line from a rma group.

In v16 this patch and the usage of such onchange can be removed
in favor of (pre)computed stored editable fields for all policies
and configuration in the RMA operation.
2023-01-02 08:55:59 +01:00
Florian da Costa
f3958f33fc [FIX] count produced products going to customer as out pickings 2022-12-27 17:32:41 +01:00
DavidJForgeFlow
f7c37239f8 [14.0][IMP] rma: add lot/serial in report 2022-12-27 09:57:11 +01:00
Lois Rilo
56330c13fc Merge pull request #332 from ForgeFlow/16.0-fp-330
[16.0][IMP] rma: pass product in create lot
2022-12-27 09:18:49 +01:00
AnnaPForgeFlow
6fc4a0e759 [IMP] rma: add translations 2022-12-27 09:04:32 +01:00
Jordi Ballester Alomar
5c423eddcb [FIX] fix empty parter on rma picking 2022-11-30 16:54:54 +01:00
DavidJForgeFlow
2a815d1f31 [14.0][IMP] rma: pass product in create lot 2022-11-30 13:25:51 +01:00
Florian da Costa
2559cb4660 [16.0][MIG] Migrate rma module to v16 2022-11-28 16:24:49 +01:00
Jordi Ballester Alomar
d991e034cb [IMP] centralize the logic to get the correct cost of the RMA. 2022-11-28 16:11:02 +01:00
Jordi Ballester Alomar
577ded734a [FIX] include anglo-saxon price unit calculation in refunds.
Otherwise the anglo saxon entries won't be correct.
For example, the Interim (Delivered) account should balance
after receiving and triggering a refund on a customer rma.
2022-11-28 16:11:02 +01:00
Jordi Ballester
35681709e8 [IMP] rma_sale: introduce new config settings.
- auto_confirm_rma_sale
- free_of_charge_rma_sale
2022-11-28 16:11:02 +01:00
DavidJForgeFlow
284891c09b [15.0][FIX] rma_sale: fixup of procurement 2022-11-28 16:11:02 +01:00
Stefan Rijnhart
60a9d6decb [IMP] rma: prevent the creation of zero qty moves 2022-11-28 16:11:02 +01:00
Florian da Costa
c778c1db67 [IMP] Make rma order view cleaner for user
Hide button and fields depending on the policy chosen on the rma line
2022-11-28 16:11:02 +01:00
Florian da Costa
b933569cae Hide smart button when empty 2022-11-28 16:11:02 +01:00
Stefan Rijnhart
a4e20f6abb [FIX] rma: improve check on rule selection during procurement
Fixes #274

Thanks to @florian-dacosta for suggesting this approach.
2022-11-28 16:11:02 +01:00
DavidJForgeFlow
41ab6e0d52 [FIX]rma: remove test_rma dependency to Account 2022-11-28 16:11:02 +01:00
Cas Vissers
91f2cf0c2c [IMP] Improve multi-company record rules 2022-11-28 16:11:02 +01:00
Stefan Rijnhart
cddf72d6c0 [FIX] rma: prevent against warehouse mismatch or missing rules
When creating pickings, ensure that the applied stock rule was taken from
the operation's routes. Otherwise, the default procurement rules for a
warehouse may kick in, creating incoming customer goods not from the customer
location but from the resupply warehouse.
2022-11-28 16:11:02 +01:00
Lois Rilo
83de39e65e [IMP] rma: add rma lines to group selecting serial numbers 2022-11-28 16:11:02 +01:00
Lois Rilo
8e4bea529e [IMP] rma: add RMA reference to delivery slip report 2022-11-28 16:11:02 +01:00
Lois Rilo
63106b76e7 [FIX] rma: missing migration scripts and version bump
Those are needed after making some fields company dependent
2022-11-28 16:11:02 +01:00
DavidFIB
125d3ebda2 [15.0][FIX/IMP] Make RMA Operation settings company dependent 2022-11-28 16:11:02 +01:00
DavidFIB
d328e17e6f [14.0][FIX/IMP] Make RMA Operation settings company dependent 2022-11-28 16:11:02 +01:00
Andrea
06c7a1d01e [13.0][FIX/IMP] Make RMA Operation settings company dependent 2022-11-28 16:11:02 +01:00
AaronHForgeFlow
e632e0faf7 [15.0][IMP] Tests for stock valuation
[FIX] rma: rma_custmer_user has no write permissions in partner, so compute method fails.
[IMP] rma: use rma user in tests
[FIX] rma_account: move_line_id field string
[IMP] rma, rma_account, rma_sale, rma_purchase: tests for stock valuation
[FIX] account_move_line_rma_order_line: minor lint, make auto-install
2022-11-28 16:11:02 +01:00
Jordi Ballester
33398c0add [IMP] rma: Refactor all rma modules in order to consider using the correct price unit in moves
Otherwise the inventory accounting will be completely wrong.
2022-11-28 16:11:02 +01:00
Florian da Costa
0c6126c661 Add missing fields in rma line editable tree in rma group 2022-11-28 16:11:02 +01:00
Florian da Costa
6bb73225f2 [FIX] Remove useless/bad wiz_id field in rma_make_picking.wizard item preparation 2022-11-28 16:11:02 +01:00
AaronHForgeFlow
df52ec86f6 [IMP] COPIER UPDATE: black, isort, prettier 2022-11-28 16:11:02 +01:00
Christopher Ormaza
ac420c786b [14.0][FIX] rma: separate stock.move by rma_line_id to fix picking association 2022-11-28 16:11:02 +01:00
Lois Rilo
c2d491ede6 [FIX] rma: do not force reservation on supplier RMA deliveries
* remove code call to unexisting `force_asign`.
* only one model per model file and rename as appropriate.
2022-11-28 16:11:02 +01:00
Jasmin Solanki
6fda8128dd [IMP] rma: Fix Route View 2022-11-28 16:11:02 +01:00
Christopher Ormaza
a9360fe4e6 [15.0][ADD] Mass action for request approval RMA order line 2022-11-28 16:11:02 +01:00
Christopher Ormaza
3b3675501f [FIX] rma: add lot to pickings created from wizard on RMA lines 2022-11-28 16:11:02 +01:00
Christopher Ormaza
bcd4d337dd [IMP] rma, rma_sale: added select all, messages for UX 2022-11-28 16:11:02 +01:00
Christopher Ormaza
f1581f1ba4 [IMP] rma: Added serial/lot selection on from stock move wizard on rma groups
- added restriction to approve rma with product tracking on serial, should be only one to receive
2022-11-28 16:11:02 +01:00
Jordi Ballester
3c51940502 [FIX] rma: compute out_shipment_count correctly. Add test cases 2022-11-28 16:11:02 +01:00
Jordi Ballester
d077fffcbf [fix] rma: improve logic to count in and out pickings
In the scenario where we use a 2 or 3 step receipts or pickings
we want to make sure that we correctly count and classify the pickings.
2022-11-28 16:11:02 +01:00
Jordi Ballester
ff0e4fb214 [fix] rma: when using 2 step receipt or delivery, don't count double 2022-11-28 16:11:02 +01:00