Commit Graph

58 Commits

Author SHA1 Message Date
Joan Sisquella
f752049a2f [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2023-05-30 15:49:27 +02:00
Lois Rilo
73b215b25c [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2023-02-21 15:01:31 +01:00
DavidJForgeFlow
cabb2a80d4 [14.0][FIX] rma: add stock move in supplier group 2023-02-01 13:55:40 +01:00
Lois Rilo
b8c088687e [IMP] rma: add description to rma order and copy it over to new lines 2023-01-09 16:57:10 +01:00
Lois Rilo
6dcc76ca68 [IMP] rma: rma group supplier form view as a inherited view.
The goal is to simplify view defintion and do not duplicate
things, requiring to do view changes in two places.

The same change was done from rma lines some time ago.
2023-01-09 16:56:32 +01:00
Lois Rilo
54b1cfd68e [FIX] rma: Ensure that configuration on the operation is applied
Without this, some policies are not being copied from the
operation selected when creating new rma line from a rma group.

In v16 this patch and the usage of such onchange can be removed
in favor of (pre)computed stored editable fields for all policies
and configuration in the RMA operation.
2023-01-02 08:50:14 +01:00
Jordi Ballester Alomar
3626075960 Merge pull request #292 from ForgeFlow/15.0-fp-264
[15.0][IMP] rma: prevent the creation of zero qty moves
2022-07-26 18:29:24 +02:00
DavidJForgeFlow
c54d2337c5 [15.0][FIX] rma_sale: fixup of procurement 2022-07-11 10:35:04 +02:00
Stefan Rijnhart
0acd4e7b4c [IMP] rma: prevent the creation of zero qty moves 2022-07-11 10:04:12 +02:00
Florian da Costa
9ce5e22e97 [IMP] Make rma order view cleaner for user
Hide button and fields depending on the policy chosen on the rma line
2022-07-01 13:53:14 +02:00
Stefan Rijnhart
8a484ed3b9 [FIX] rma: improve check on rule selection during procurement
Fixes #274

Thanks to @florian-dacosta for suggesting this approach.
2022-06-24 12:08:40 +02:00
Stefan Rijnhart
6e6189d093 [FIX] rma: prevent against warehouse mismatch or missing rules
When creating pickings, ensure that the applied stock rule was taken from
the operation's routes. Otherwise, the default procurement rules for a
warehouse may kick in, creating incoming customer goods not from the customer
location but from the resupply warehouse.
2022-06-15 17:35:17 +02:00
Lois Rilo
730156ab1d [IMP] rma: add rma lines to group selecting serial numbers 2022-05-27 09:18:01 +02:00
Florian da Costa
2bd84fd4a1 [FIX] Remove useless/bad wiz_id field in rma_make_picking.wizard item preparation 2022-05-12 17:02:04 +02:00
AaronHForgeFlow
b39efac5db [IMP] COPIER UPDATE: black, isort, prettier 2022-04-25 09:09:12 +02:00
Lois Rilo
7c307c8d3d [FIX] rma: do not force reservation on supplier RMA deliveries
* remove code call to unexisting `force_asign`.
* only one model per model file and rename as appropriate.
2022-03-07 07:57:29 -05:00
Christopher Ormaza
3b68e993f0 [FIX] rma: add lot to pickings created from wizard on RMA lines 2022-02-10 13:48:36 +01:00
Christopher Ormaza
9a91869525 [IMP] rma, rma_sale: added select all, messages for UX 2022-02-10 13:37:18 +01:00
Christopher Ormaza
75d595a22b [IMP] rma: Added serial/lot selection on from stock move wizard on rma groups
- added restriction to approve rma with product tracking on serial, should be only one to receive
2022-02-10 13:36:49 +01:00
Jasmin Solanki
59c8804a9d [MIG] rma: Migration to 15.0 2022-01-07 16:37:59 +05:30
Lois Rilo
1fc3c775aa [14.0][MIG] rma*: ir.actions.act_window has different access
right in v14. Actions that read those records need to use
`sudo` to allow non-admin users to be able to use these actions.
2022-01-06 15:44:33 +05:30
Lois Rilo
7f855ffc88 [IMP] rma: Do not highlight all action buttons and simplify
rma.line views, supplier view is an extension of customer one.

This makes easier to edit common elements in both views and ease
maintenance.
2022-01-06 15:44:33 +05:30
Mateu Griful
facb1189a4 [FIX] rma: Create rma supplier action 2022-01-06 15:44:33 +05:30
Mateu Griful
0d5626fe89 [MIG] rma: Migration to 14.0 - fix 2022-01-06 15:44:33 +05:30
Mateu Griful
8381461308 [MIG] rma: Migration to 14.0 - fix 2022-01-06 15:44:33 +05:30
Mateu Griful
87a59a1aad [MIG] rma: Migration to 14.0 - fix 2022-01-06 15:44:33 +05:30
Mateu Griful
bf2c5d00db [MIG] rma: Migration to 14.0 2022-01-06 15:44:33 +05:30
Mateu Griful
a472442913 [IMP] rma: black, isort, prettier 2022-01-06 15:44:33 +05:30
HviorForgeFlow
6a669f218b [IMP] Update pre-commit lints according with OCA ones 2022-01-06 15:44:33 +05:30
hveficent
bab77f8b0e RMA as an APP 2022-01-06 15:44:33 +05:30
ahenriquez
932c5b2416 [MIG] rma: Migration to 13.0 2022-01-06 15:44:33 +05:30
ahenriquez
d1daf2cd52 [IMP] : black, isort 2022-01-06 15:44:33 +05:30
mreficent
b41ea0f35b [FIX] default_gets: avoid using shadowname 'fields' 2022-01-06 15:44:33 +05:30
Aaron Henriquez
dca239f699 [FIX]wizard to create pickings, not to show rma groups if rma groups are not activated 2022-01-06 15:44:33 +05:30
Akim Juillerat
def4df4234 [FIX] Remove picking_id from default_get as model does not define it 2022-01-06 15:44:33 +05:30
Akim Juillerat
6272f31ff3 rma: Fix stock_location res.groups 2022-01-06 15:44:33 +05:30
Adrià Gil Sorribes
316732686e [12.0][MIG] Migrate rma module to v12.0 2022-01-06 15:44:33 +05:30
aheficent
9f5f9ecdbd [FIX]text on create supplier rma button 2022-01-06 15:44:33 +05:30
aheficent
ab47d54462 [IMP] add group to manage rma groups 2022-01-06 15:44:33 +05:30
aheficent
b3f7f530b0 [FIX]views rma 2022-01-06 15:44:33 +05:30
aheficent
db5359b0eb [MIG]rma v110.0.2.0.0 2022-01-06 15:44:33 +05:30
Bhavesh Odedra
d9358ccbb8 [FIX] TypeError: unhashable type: 'list' 2022-01-06 15:44:33 +05:30
Bhavesh Odedra
43559a5882 [IMP] Various improvements 2022-01-06 15:44:33 +05:30
Jordi Ballester
2c6a3e6aa9 multiple fixes 2022-01-06 15:44:33 +05:30
Maxime Chambreuil
91365f3c0b [FIX] Errors from tests 2022-01-06 15:44:33 +05:30
Maxime Chambreuil
9f9fdddcf8 [MIG] Migrate configuration and cleanup 2022-01-06 15:44:33 +05:30
Maxime Chambreuil
93cf80ed14 [FIX] Permissions and remove (en)coding 2022-01-06 15:44:33 +05:30
Bhavesh Odedra
e1c2bd2935 [11.0] MIG: RMA module 2022-01-06 15:44:33 +05:30
Nikul Chaudhary
a662040da0 [IMP] Improved Unit Test Case and Fixed Travis 2022-01-06 15:44:33 +05:30
aheficent
3d63397d3f [MIG]rma v10 2022-01-06 15:44:33 +05:30