Commit Graph

38 Commits

Author SHA1 Message Date
Carlos Vallés Fuster
a73d695719 [MIG] rma: migration to 17.0
[IMP] rma: test fixes
2024-03-25 11:32:30 +01:00
CarlosVForgeFlow
56b82eff1a Revert "[17.0][MIG] rma" 2024-03-12 14:03:17 +01:00
Carlos Vallés Fuster
775b51915b [MIG] rma: Migration to 17.0 2024-03-12 09:41:16 +01:00
Carlos Vallés Fuster
46fa1f6283 [IMP] rma: pre-commit auto fixes 2024-03-06 08:32:41 +01:00
Florian da Costa
b9f0b7a60d [FIX] Delete rma_picking_wizard_item on cascade to avoid failure 2024-03-06 08:31:44 +01:00
Joan Sisquella
23da1ccb94 [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2024-03-06 08:31:44 +01:00
DavidJForgeFlow
0fa5fa17b0 [FIX] rma: dropship from vendor as outgoing 2024-03-06 08:31:44 +01:00
DavidJForgeFlow
010bdc5070 [FIX] rma: make picking product_uom_qty 2024-03-06 08:31:44 +01:00
DavidJForgeFlow
0422852a88 [FIX] rma: product_uom_qty not in move_line_ids 2024-03-06 08:31:44 +01:00
Lois Rilo
2a5952e147 [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2024-03-06 08:31:44 +01:00
Florian da Costa
0bb07d5e01 [16.0][MIG] Migrate rma module to v16 2024-03-06 08:31:44 +01:00
DavidJForgeFlow
d91868ff4d [15.0][FIX] rma_sale: fixup of procurement 2024-03-06 08:31:44 +01:00
Stefan Rijnhart
84ee05edcc [IMP] rma: prevent the creation of zero qty moves 2024-03-06 08:31:44 +01:00
Stefan Rijnhart
b96eff7aac [FIX] rma: improve check on rule selection during procurement
Fixes #274

Thanks to @florian-dacosta for suggesting this approach.
2024-03-06 08:31:44 +01:00
Stefan Rijnhart
5abc94ae3c [FIX] rma: prevent against warehouse mismatch or missing rules
When creating pickings, ensure that the applied stock rule was taken from
the operation's routes. Otherwise, the default procurement rules for a
warehouse may kick in, creating incoming customer goods not from the customer
location but from the resupply warehouse.
2024-03-06 08:31:44 +01:00
Florian da Costa
37ec3958c8 [FIX] Remove useless/bad wiz_id field in rma_make_picking.wizard item preparation 2024-03-06 08:31:44 +01:00
Lois Rilo
a15d7b9266 [FIX] rma: do not force reservation on supplier RMA deliveries
* remove code call to unexisting `force_asign`.
* only one model per model file and rename as appropriate.
2024-03-06 08:31:44 +01:00
Christopher Ormaza
58c6f344dc [FIX] rma: add lot to pickings created from wizard on RMA lines 2024-03-06 08:31:44 +01:00
Jasmin Solanki
79816ca944 [MIG] rma: Migration to 15.0 2024-03-06 08:31:44 +01:00
Mateu Griful
28fcd8efbe [MIG] rma: Migration to 14.0 - fix 2024-03-06 08:31:44 +01:00
Mateu Griful
3efe41ed86 [MIG] rma: Migration to 14.0 - fix 2024-03-06 08:31:44 +01:00
hveficent
a1b48af954 RMA as an APP 2024-03-06 08:31:44 +01:00
ahenriquez
d2d7487fee [MIG] rma: Migration to 13.0 2024-03-06 08:31:44 +01:00
ahenriquez
c7720d32f0 [IMP] : black, isort 2024-03-06 08:31:44 +01:00
mreficent
bcb3a40b63 [FIX] default_gets: avoid using shadowname 'fields' 2024-03-06 08:31:44 +01:00
Adrià Gil Sorribes
3dc6c67542 [12.0][MIG] Migrate rma module to v12.0 2024-03-06 08:31:44 +01:00
aheficent
f7f3e960a1 [MIG]rma v110.0.2.0.0 2024-03-06 08:31:44 +01:00
Bhavesh Odedra
4571901891 [FIX] TypeError: unhashable type: 'list' 2024-03-06 08:31:44 +01:00
Jordi Ballester
216891b1a9 multiple fixes 2024-03-06 08:31:44 +01:00
Maxime Chambreuil
3367ce78e4 [FIX] Errors from tests 2024-03-06 08:31:44 +01:00
Maxime Chambreuil
0844d0cebd [MIG] Migrate configuration and cleanup 2024-03-06 08:31:44 +01:00
Maxime Chambreuil
5bfa9d1323 [FIX] Permissions and remove (en)coding 2024-03-06 08:31:44 +01:00
Bhavesh Odedra
c663cd2db2 [11.0] MIG: RMA module 2024-03-06 08:31:44 +01:00
Nikul Chaudhary
5ea392345a [IMP] Improved Unit Test Case and Fixed Travis 2024-03-06 08:31:44 +01:00
aheficent
ae8548d234 [MIG]rma v10 2024-03-06 08:31:44 +01:00
lreficent
3c0e629f57 [9.0][REW] rma: workflow centralized on rma.order.line and the use of rma.order is optional. 2024-03-06 08:31:44 +01:00
lreficent
3139292069 [9.0][FIX] rma:
* fix assignment of moves.
* default qty in rma lines.
* remove account dependency.
* test and flake8 fixes.
2024-03-06 08:31:44 +01:00
Jordi Ballester
8088c3a829 init branch 2024-03-06 08:31:44 +01:00