122 Commits

Author SHA1 Message Date
Joan Sisquella
fad3ab7a79 [FIX] rma: procurement origin
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
2023-05-30 17:39:08 +02:00
DavidJForgeFlow
afb0533a7d [IMP] rma: limit state statusbar 2023-02-21 15:14:32 +01:00
Lois Rilo
d62bcca3ec [FIX] rma: in multi step routes, only reserve first step
We shoul not force reservation on next steps on a multi step
route, oherwise a inconsistency is generated and the transfers
cannot be processed or cancel so the user gets stuck ("it is
not possible to unreserve more products that you have in stock"
error).
2023-02-21 14:59:36 +01:00
Lois Rilo
243fb06b5b Merge pull request #368 from ForgeFlow/13.0-bp-367
[13.0][FIX] rma: add stock move in supplier group
2023-02-21 14:51:08 +01:00
DavidJForgeFlow
7c414b9ff5 [IMP] rma: cancel rma_lines 2023-02-20 20:20:35 +01:00
DavidJForgeFlow
f7641a4ab5 [14.0][FIX] rma: add stock move in supplier group 2023-02-01 13:05:30 +01:00
Lois Rilo
52a33a7648 Merge pull request #336 from ForgeFlow/13.0-fp-288
[13.0][FIX] fix empty parter on rma picking
2022-12-27 09:23:09 +01:00
Lois Rilo
30a8bfaeaa Merge pull request #272 from ForgeFlow/13.0-bp-269
[13.0][FIX]rma: remove test_rma dependency to Account
2022-12-27 09:13:16 +01:00
Dariusz Kubiak
44bffbe49a [12.0][FIX] fix empty parter on rma picking 2022-12-01 10:50:15 +01:00
Jordi Ballester Alomar
dcc307f730 Merge pull request #282 from ForgeFlow/13.0-bp-266
[13.0][IMP] Improve multi-company record rules
2022-07-26 18:30:54 +02:00
Jordi Ballester Alomar
17950147dc Merge pull request #290 from ForgeFlow/13.0-fp-264
[13.0][IMP] rma: prevent the creation of zero qty moves
2022-07-26 18:29:54 +02:00
Jordi Ballester Alomar
ef796829b1 Merge pull request #293 from ForgeFlow/13.0-bp-273
[13.0] Hide smart button when empty
2022-07-26 18:29:08 +02:00
Florian da Costa
aa7253dc30 [IMP] Make rma order view cleaner for user
Hide button and fields depending on the policy chosen on the rma line
2022-07-18 10:25:52 +02:00
Florian da Costa
20a758082b Hide smart button when empty 2022-07-18 09:45:45 +02:00
Stefan Rijnhart
cdafac7a61 [IMP] rma: prevent the creation of zero qty moves 2022-07-11 09:11:05 +02:00
Cas Vissers
866e623f6a [IMP] Improve multi-company record rules 2022-06-28 09:39:13 +02:00
DavidJForgeFlow
a875f0f67a [FIX]rma: remove test_rma dependency to Account 2022-06-28 09:30:28 +02:00
Lois Rilo
58e43ae0e3 [IMP] rma: add rma lines to group selecting serial numbers 2022-05-27 10:19:24 +02:00
Lois Rilo
51fba11626 [IMP] rma: add RMA reference to delivery slip report 2022-05-27 09:43:03 +02:00
Lois Rilo
a7b99765dd [FIX] rma: missing migration scripts and version bump
Those are needed after making some fields company dependent
2022-05-25 17:57:40 +02:00
DavidFIB
cefbecca9e [FIX]rma: test05 fixed 2022-05-18 10:20:36 +02:00
Andrea
259d95da06 [13.0][FIX/IMP] Make RMA Operation settings company dependent 2022-05-17 17:36:02 +02:00
Christopher Ormaza
07645ab72b [IMP] write method replaced for backported implementation 2022-03-07 08:23:17 -05:00
Christopher Ormaza
4a4d9d8ec8 [14.0][FIX] rma: separate stock.move by rma_line_id to fix picking association 2022-03-07 07:45:00 -05:00
Lois Rilo
7b7a8b4f2b [FIX] rma: do not force reservation on supplier RMA deliveries 2022-03-07 07:44:40 -05:00
Jasmin Solanki
31d3c9fa21 [IMP] rma: Fix Route View 2022-02-23 17:29:00 +05:30
Christopher Ormaza
2d3cbd05ae [13.0][ADD] Mass action for request approval RMA order line 2022-02-11 11:19:14 -05:00
Lois Rilo
6275b23ceb [UPD] pre-commit 2022-02-10 13:46:46 +01:00
Christopher Ormaza
13e3a4bf77 [FIX] rma: add lot to pickings created from wizard on RMA lines 2022-02-10 13:40:20 +01:00
Christopher Ormaza
844db3b93c [IMP] rma, rma_sale: added select all, messages for UX 2022-02-10 13:40:13 +01:00
Christopher Ormaza
5684133be4 [IMP] rma: Added serial/lot selection on from stock move wizard on rma groups
- added restriction to approve rma with product tracking on serial, should be only one to receive
2022-02-10 13:39:58 +01:00
Jordi Ballester
741ac0052b [FIX] rma: compute out_shipment_count correctly. Add test cases 2022-02-08 09:36:59 +01:00
Jordi Ballester
f4b8a5060c [fix] rma: improve logic to count in and out pickings
In the scenario where we use a 2 or 3 step receipts or pickings
we want to make sure that we correctly count and classify the pickings.
2022-02-03 16:29:27 +01:00
Jordi Ballester
acffe8c5e2 [fix] rma: when using 2 step receipt or delivery, don't count double 2022-02-03 16:27:08 +01:00
AaronHForgeFlow
19d321b89d [IMP] black, isort, prettier 2020-12-23 17:15:51 +01:00
Bhavesh Odedra
cc89fbd805 [FIX] External ID not found in the system: account.res_partner_action_supplier 2020-12-17 11:24:17 +01:00
HviorForgeFlow
08752350a8 [IMP] Update pre-commit lints according with OCA ones 2020-05-29 17:35:24 +02:00
ahenriquez
8b945f4194 [FIX]rma report templates group 2020-05-29 17:32:24 +02:00
ahenriquez
c3afb525c0 [ENH]rma_sale traceability 2020-03-09 14:59:57 +01:00
ahenriquez
b82295206d [IMP]rma enable invoicing from settings 2020-02-14 13:14:45 +01:00
ahenriquez
61160cf08d [FIX]rma_account refund creation 2020-02-14 12:48:08 +01:00
ahenriquez
517943f3a2 [IMP]rma master data menus 2020-02-14 12:42:47 +01:00
hveficent
74052f4dd8 RMA as an APP 2020-01-20 12:46:08 +01:00
ahenriquez
f3c1a1c438 [MIG] rma: Migration to 13.0 2020-01-17 18:03:43 +01:00
ahenriquez
1ae40ec4d3 [IMP] : black, isort 2020-01-14 16:36:03 +01:00
ahenriquez
efd131b334 [UPT]rma group report to v12 2020-01-14 16:35:27 +01:00
Chafique
331e51d40e [10.0][IMP]add report for rma group 2020-01-14 16:35:27 +01:00
mreficent
6f6f5d7b32 [FIX] default_gets: avoid using shadowname 'fields' 2020-01-14 16:35:27 +01:00
ahenriquez
4d92265726 [FIX]UsreError to Validation Error 2020-01-14 16:35:27 +01:00
ahenriquez
36b8423819 [FIX]move constraint from the rma order to the line 2020-01-14 16:35:27 +01:00