[IMP] rma_account: black, isort, prettier

rma_account/__manifest__.py

@@ -8,7 +8,7 @@
     "category": "RMA",
     "summary": "Integrates RMA with Invoice Processing",
     "author": "ForgeFlow",
-    "website": "https://github.com/ForgeFlow/stock-rma",
+    "website": "https://github.com/OCA/account-budgeting",
     "depends": ["stock_account", "rma"],
     "data": [
         "security/ir.model.access.csv",

rma_account/views/account_move_view.xml

@@ -17,11 +17,7 @@
                         icon="fa-eject"
                         groups="rma.group_rma_customer_user,rma.group_rma_supplier_user"
                     >
-                        <field
+                        <field name="rma_count" widget="statinfo" string="RMA" />
-                            name="rma_count"
-                            widget="statinfo"
-                            string="RMA"
-                        />
                     </button>
                 </div>
             </field>
@@ -39,9 +35,7 @@
                 <field name="name" position="after">
                     <field name="rma_line_count" invisible="1" />
                     <field name="rma_line_id" string="RMA line originated" />
-                    <notebook
+                    <notebook attrs="{'invisible': [('rma_line_count', '=', 0)]}">
-                        attrs="{'invisible': [('rma_line_count', '=', 0)]}"
-                    >
                         <page string="RMA Lines">
                             <field name="rma_line_ids" />
                         </page>

rma_account/views/rma_account_menu.xml

@@ -3,10 +3,7 @@
      License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl-3.0) -->
 <odoo>
 
-    <record
+    <record id="action_rma_account_customer_lines" model="ir.actions.act_window">
-        id="action_rma_account_customer_lines"
-        model="ir.actions.act_window"
-    >
         <field name="name">Customer RMA</field>
         <field name="res_model">rma.order.line</field>
         <field name="domain">[('type','=', 'customer')]</field>
@@ -18,9 +15,7 @@
         <field name="name">Supplier RMA</field>
         <field name="res_model">rma.order.line</field>
         <field name="domain">[('type','=', 'supplier')]</field>
-        <field
+        <field name="context">{"search_default_to_refund":1, "supplier":1}</field>
-            name="context"
-        >{"search_default_to_refund":1, "supplier":1}</field>
         <field name="view_mode">tree,form</field>
         <field name="view_id" ref="rma.view_rma_line_supplier_tree" />
     </record>

rma_account/views/rma_order_line_view.xml

@@ -21,11 +21,7 @@
                     icon="fa-pencil-square-o"
                     groups="account.group_account_user"
                 >
-                        <field
+                        <field name="refund_count" widget="statinfo" string="Refunds" />
-                        name="refund_count"
-                        widget="statinfo"
-                        string="Refunds"
-                    />
                     </button>
             </button>
             <group name="main_info" position="inside">
@@ -82,11 +78,7 @@
                     icon="fa-pencil-square-o"
                     groups="account.group_account_user"
                 >
-                        <field
+                        <field name="refund_count" widget="statinfo" string="Refunds" />
-                        name="refund_count"
-                        widget="statinfo"
-                        string="Refunds"
-                    />
                     </button>
             </button>
             <group name="main_info" position="inside">

rma_account/views/rma_order_view.xml

@@ -26,11 +26,7 @@
                     icon="fa-pencil-square-o"
                     groups="account.group_account_user"
                 >
-                    <field
+                    <field name="invoice_count" widget="statinfo" string="Origin Inv" />
-                        name="invoice_count"
-                        widget="statinfo"
-                        string="Origin Inv"
-                    />
                 </button>
             </button>
             <!--

rma_account/wizards/rma_add_account_move.xml

@@ -22,10 +22,7 @@
                     <tree string="Invoice Lines">
                         <field name="move_id" />
                         <field name="name" />
-                        <field
+                        <field name="account_id" groups="account.group_account_user" />
-                            name="account_id"
-                            groups="account.group_account_user"
-                        />
                         <field name="quantity" />
                         <field name="product_id" />
                         <field name="product_uom_id" />
@@ -75,10 +72,7 @@
                     <tree string="Invoice Lines">
                         <field name="move_id" />
                         <field name="name" />
-                        <field
+                        <field name="account_id" groups="account.group_account_user" />
-                            name="account_id"
-                            groups="account.group_account_user"
-                        />
                         <field name="quantity" />
                         <field name="product_id" />
                         <field name="product_uom_id" />
@@ -114,16 +108,10 @@
         <field name="view_mode">form</field>
         <field name="target">new</field>
         <field name="view_id" ref="view_rma_add_account_move" />
-        <field
+        <field name="groups_id" eval="[(4, ref('rma.group_rma_customer_user'))]" />
-            name="groups_id"
-            eval="[(4, ref('rma.group_rma_customer_user'))]"
-        />
     </record>
 
-    <record
+    <record id="action_rma_add_account_move_supplier" model="ir.actions.act_window">
-        id="action_rma_add_account_move_supplier"
-        model="ir.actions.act_window"
-    >
         <field name="name">Add Invoice</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">rma_add_account_move</field>
@@ -131,10 +119,7 @@
         <field name="view_mode">form</field>
         <field name="target">new</field>
         <field name="view_id" ref="view_rma_add_account_move_supplier" />
-        <field
+        <field name="groups_id" eval="[(4, ref('rma.group_rma_supplier_user'))]" />
-            name="groups_id"
-            eval="[(4, ref('rma.group_rma_supplier_user'))]"
-        />
     </record>
 
     <record id="view_rma_add_account_move_form" model="ir.ui.view">

rma_account/wizards/rma_refund.xml

@@ -32,11 +32,7 @@
                         type="object"
                         class="btn-primary"
                     />
-                    <button
+                    <button string="Cancel" class="btn-default" special="cancel" />
-                        string="Cancel"
-                        class="btn-default"
-                        special="cancel"
-                    />
                 </footer>
            </form>
         </field>
@@ -48,10 +44,7 @@
         <field name="view_mode">tree,form</field>
         <field name="view_id" ref="view_rma_refund" />
         <field name="binding_model_id" ref="rma.model_rma_order_line" />
-        <field
+        <field name="groups_id" eval="[(4, ref('account.group_account_invoice'))]" />
-            name="groups_id"
-            eval="[(4, ref('account.group_account_invoice'))]"
-        />
         <field name="target">new</field>
     </record>