From 9971faa07053e5df5b3215c5e4bad438a8c04410 Mon Sep 17 00:00:00 2001 From: ahenriquez Date: Mon, 6 Apr 2020 13:18:53 +0200 Subject: [PATCH 1/4] [UPT]allow to deliver rmas after repair even when not paid --- rma_repair/__manifest__.py | 2 +- rma_repair/models/rma_order_line.py | 3 +-- rma_repair/tests/test_rma_repair.py | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/rma_repair/__manifest__.py b/rma_repair/__manifest__.py index ff01690c..aff5ec3c 100644 --- a/rma_repair/__manifest__.py +++ b/rma_repair/__manifest__.py @@ -3,7 +3,7 @@ { "name": "RMA Repair", - "version": "12.0.1.2.0", + "version": "12.0.1.2.1", "license": "LGPL-3", "category": "RMA", "summary": "Links RMA with Repairs.", diff --git a/rma_repair/models/rma_order_line.py b/rma_repair/models/rma_order_line.py index 4f577ddd..f1134c83 100644 --- a/rma_repair/models/rma_order_line.py +++ b/rma_repair/models/rma_order_line.py @@ -142,6 +142,5 @@ class RmaOrderLine(models.Model): def _compute_qty_to_deliver(self): res = super(RmaOrderLine, self)._compute_qty_to_deliver() for rec in self.filtered(lambda l: l.delivery_policy == 'repair'): - rec.qty_to_deliver = rec.qty_repaired - rec.qty_delivered - \ - rec.qty_to_pay + rec.qty_to_deliver = rec.qty_repaired - rec.qty_delivered return res diff --git a/rma_repair/tests/test_rma_repair.py b/rma_repair/tests/test_rma_repair.py index a1b2a537..a36661a4 100644 --- a/rma_repair/tests/test_rma_repair.py +++ b/rma_repair/tests/test_rma_repair.py @@ -242,7 +242,7 @@ class TestRmaRepair(common.SingleTransactionCase): repair.action_repair_invoice_create() self.assertEqual(rma.qty_repaired, 1.0) repair.invoice_id.action_invoice_open() - self.assertEqual(rma.qty_to_deliver, 0.0) + self.assertEqual(rma.qty_to_deliver, 1.0) repair.invoice_id.pay_and_reconcile(self.bank_journal, 200.0) self.assertEqual(repair.invoice_status, 'paid') self.assertEqual(rma.qty_to_pay, 0.0) From 3924c701c88067634fd324715eb9093ddcbfe37a Mon Sep 17 00:00:00 2001 From: ahenriquez Date: Mon, 6 Apr 2020 17:21:37 +0200 Subject: [PATCH 2/4] [IMP]allow to invoice repair orders from the rma line --- rma_repair/models/rma_order_line.py | 5 +++++ rma_repair/views/rma_order_line_view.xml | 6 ++++++ 2 files changed, 11 insertions(+) diff --git a/rma_repair/models/rma_order_line.py b/rma_repair/models/rma_order_line.py index f1134c83..a4c3bb44 100644 --- a/rma_repair/models/rma_order_line.py +++ b/rma_repair/models/rma_order_line.py @@ -144,3 +144,8 @@ class RmaOrderLine(models.Model): for rec in self.filtered(lambda l: l.delivery_policy == 'repair'): rec.qty_to_deliver = rec.qty_repaired - rec.qty_delivered return res + + def rma_repair_make_invoice(self): + res = self.env['repair.order.make_invoice'].with_context( + active_ids=self.repair_ids.ids).create({}).make_invoices() + return res diff --git a/rma_repair/views/rma_order_line_view.xml b/rma_repair/views/rma_order_line_view.xml index d9a5f5a2..16ba2a98 100644 --- a/rma_repair/views/rma_order_line_view.xml +++ b/rma_repair/views/rma_order_line_view.xml @@ -45,6 +45,12 @@ string="Create Repair Order" class="oe_highlight" type="action"/> +