audrius/stock-rma
1
0
Fork 0
mirror of https://github.com/ForgeFlow/stock-rma.git synced 2025-01-21 12:57:49 +02:00
Code Issues Packages Projects Releases Wiki Activity

[FIX] rma: procurement origin

Browse Source 
In the current implementation of Odoo's _assign_picking() method in stock.move, there's a conditional check that looks at whether all the moves associated with a picking have the same partner_id and origin. If any move doesn't align with these conditions, the origin of the picking is set to False.

        if any(picking.partner_id.id != m.partner_id.id or
                picking.origin != m.origin for m in moves):
            # If a picking is found, we'll append `move` to its move list and thus its
            # `partner_id` and `ref` field will refer to multiple records. In this
            # case, we chose to  wipe them.
            picking.write({
                'partner_id': False,
                'origin': False,
            })
In the context of RMA when we have multiple moves associated with a picking, each coming from a different RMA order line, we encounter a problem. Each move has its origin set as the name of the RMA orde line (line.name), so as soon as a second move from a different line is appended to the picking, the origin of the picking is wiped, because it doesn't match the origin of the first move.

In order to prevent the partner_id of the picking from being set to False when there are multiple associated moves, I propose that we change the origin of the procurement from the name of the RMA line to the name of the procurement group (group.name). This way, all moves associated with a picking will share the same origin, preserving the origin of the picking and ensuring it doesn't get inadvertently set to False.
This commit is contained in:
Joan Sisquella
2023-05-25 17:53:49 +02:00
committed by Aaron ForgeFlow
parent 4961a2af36
commit 2feb96db80
2 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
rma/tests/test_rma.py
View File

@@ -766,7 +766,9 @@ class TestRma(common.TransactionCase):
wizard._create_picking()
res = self.rma_supplier_id.rma_line_ids.action_view_out_shipments()
self.assertTrue("res_id" in res, "Incorrect number of pickings" "created")
picking = self.env["stock.picking"].browse(res["res_id"])
picking = self.rma_supplier_id.rma_line_ids._get_out_pickings()
partner = picking.partner_id
self.assertTrue(partner, "Partner is not defined or False")
moves = picking.move_ids
self.assertEqual(len(moves), 3, "Incorrect number of moves created")
@@ -886,7 +888,9 @@ class TestRma(common.TransactionCase):
pickings = self.env["stock.picking"].browse(res["res_id"])
self.assertEqual(len(pickings), 1, "Incorrect number of pickings created")
picking_in = pickings[0]
moves = picking_in.move_ids
partner = picking_in.partner_id
self.assertTrue(partner, "Partner is not defined or False")
moves = picking.move_ids
self.assertEqual(len(moves), 3, "Incorrect number of moves created")
lines = self.rma_supplier_id.rma_line_ids
@@ -1064,3 +1068,18 @@ class TestRma(common.TransactionCase):
).create({})
with self.assertRaisesRegex(ValidationError, "No quantity to transfer"):
wizard._create_picking()
def test_08_supplier_rma_single_line(self):
rma_line_id = self.rma_supplier_id.rma_line_ids[0].id
wizard = self.rma_make_picking.with_context(
active_ids=[rma_line_id],
active_model="rma.order.line",
picking_type="outgoing",
active_id=2,
).create({})
wizard._create_picking()
picking = self.rma_supplier_id.rma_line_ids[0]._get_out_pickings()
partner = picking.partner_id
self.assertTrue(partner, "Partner is not defined or False")
moves = picking.move_ids
self.assertEqual(len(moves), 1, "Incorrect number of moves created")