From 8e94a0d266e765a7ab5fae4319c2be48a3b2c90a Mon Sep 17 00:00:00 2001
From: Carlos Serra-Toro <carlos.serra@camptocamp.com>
Date: Fri, 19 Feb 2021 17:19:09 +0100
Subject: [PATCH] [FIX] stock_vertical_lift: skip button is only for pick
 operation

The button to skip an operation is only implemented for the pick
operation (not for the put or for the inventory ones) but it was
shown in the screens for all the operations, yielding to a stack
trace when it was pressed from the wrong operationg. The button
has been moved now to the screen for the pick operation, only.
---
 .../views/vertical_lift_operation_base_views.xml      |  9 ---------
 .../views/vertical_lift_operation_pick_views.xml      | 11 +++++++++++
 2 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/stock_vertical_lift/views/vertical_lift_operation_base_views.xml b/stock_vertical_lift/views/vertical_lift_operation_base_views.xml
index 40c4b405e..079653691 100644
--- a/stock_vertical_lift/views/vertical_lift_operation_base_views.xml
+++ b/stock_vertical_lift/views/vertical_lift_operation_base_views.xml
@@ -65,15 +65,6 @@
                     </div>
                     <div class="o_shuttle_content o_shuttle_content_right">
                         <div>
-                            <button
-                                name="button_skip"
-                                type="object"
-                                string="Skip"
-                                icon="fa-forward"
-                                class="btn-danger"
-                                barcode_trigger="skip"
-                                attrs="{'invisible': [('state', '=', 'noop')]}"
-                            />
                             <!-- will react on barcode 'O-BTN.save' -->
                             <button
                                 name="button_save"
diff --git a/stock_vertical_lift/views/vertical_lift_operation_pick_views.xml b/stock_vertical_lift/views/vertical_lift_operation_pick_views.xml
index 7e9032874..26ec7d4ab 100644
--- a/stock_vertical_lift/views/vertical_lift_operation_pick_views.xml
+++ b/stock_vertical_lift/views/vertical_lift_operation_pick_views.xml
@@ -21,6 +21,17 @@
             <form position="attributes">
                 <attribute name="string">Pick Screen</attribute>
             </form>
+            <button name="button_save" position="before">
+                <button
+                    name="button_skip"
+                    type="object"
+                    string="Skip"
+                    icon="fa-forward"
+                    class="btn-danger"
+                    barcode_trigger="skip"
+                    attrs="{'invisible': [('state', '=', 'noop')]}"
+                />
+            </button>
         </field>
     </record>
 </odoo>