From b73ab16bdf8b0f699046fad18c7094cd9eca2ce5 Mon Sep 17 00:00:00 2001 From: Bhavesh Odedra Date: Wed, 19 Aug 2020 08:55:13 -0700 Subject: [PATCH] [IMP] reason code location set as a scrap location if set --- scrap_reason_code/models/stock_scrap.py | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/scrap_reason_code/models/stock_scrap.py b/scrap_reason_code/models/stock_scrap.py index afa1dd2c8..9b3f90277 100644 --- a/scrap_reason_code/models/stock_scrap.py +++ b/scrap_reason_code/models/stock_scrap.py @@ -25,21 +25,23 @@ class StockScrap(models.Model): def write(self, vals): if "reason_code_id" in vals: - vals.update( - { - "scrap_location_id": self.env["scrap.reason.code"] - .browse(vals.get("reason_code_id")) - .location_id - } + location_id = ( + self.env["scrap.reason.code"] + .browse(vals.get("reason_code_id")) + .location_id ) + if location_id: + vals.update({"scrap_location_id": location_id}) return super(StockScrap, self).write(vals) @api.model def create(self, vals): if "reason_code_id" in vals: - vals["scrap_location_id"] = ( + location_id = ( self.env["scrap.reason.code"] .browse(vals.get("reason_code_id")) - .location_id.id + .location_id ) + if location_id: + vals["scrap_location_id"] = location_id.id return super(StockScrap, self).create(vals)