From 14dd44e48d0edf03e5a79b6419d1556c9d328d71 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?=
 <victor.martinez@tecnativa.com>
Date: Tue, 28 Nov 2023 16:46:22 +0100
Subject: [PATCH] [FIX] stock_request_analytic: Adding the correct groups to
 the views to avoid permissions errors

---
 .../tests/test_stock_request_analytic.py             | 12 +++++++++++-
 stock_request_analytic/views/analytic_views.xml      |  4 ++++
 .../views/stock_request_order_views.xml              |  6 ++++++
 stock_request_analytic/views/stock_request_views.xml |  4 ++++
 4 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/stock_request_analytic/tests/test_stock_request_analytic.py b/stock_request_analytic/tests/test_stock_request_analytic.py
index 8afae2882..18538d34f 100644
--- a/stock_request_analytic/tests/test_stock_request_analytic.py
+++ b/stock_request_analytic/tests/test_stock_request_analytic.py
@@ -4,13 +4,14 @@
 from odoo import fields
 from odoo.exceptions import UserError
 from odoo.tests import Form
+from odoo.tests.common import users
 
 from odoo.addons.stock_request.tests import test_stock_request
 
 
 class TestStockRequestAnalytic(test_stock_request.TestStockRequest):
     def setUp(self):
-        super(TestStockRequestAnalytic, self).setUp()
+        super().setUp()
         self.analytic_model = self.env["account.analytic.account"]
         self.analytic = self.analytic_model.create({"name": "Pizza"})
         self.analytic2 = self.analytic_model.create(
@@ -48,6 +49,14 @@ class TestStockRequestAnalytic(test_stock_request.TestStockRequest):
             }
         )
         self.pizza.route_ids = [(6, 0, self.demand_route.ids)]
+        self.stock_request_user.write(
+            {
+                "groups_id": [
+                    (4, self.env.ref("analytic.group_analytic_accounting").id),
+                    (4, self.env.ref("stock.group_stock_user").id),
+                ]
+            }
+        )
 
     def prepare_order_request_analytic(self, analytic, company, analytic_tags=None):
         expected_date = fields.Datetime.now()
@@ -150,6 +159,7 @@ class TestStockRequestAnalytic(test_stock_request.TestStockRequest):
             )
             self.env["stock.request.order"].create(vals)
 
+    @users("stock_request_user")
     def test_default_analytic(self):
         """
         Create request order with a default analytic
diff --git a/stock_request_analytic/views/analytic_views.xml b/stock_request_analytic/views/analytic_views.xml
index 1f77af7a2..cdcbd0579 100644
--- a/stock_request_analytic/views/analytic_views.xml
+++ b/stock_request_analytic/views/analytic_views.xml
@@ -6,6 +6,10 @@
         <field name="name">analytic.order.form</field>
         <field name="model">account.analytic.account</field>
         <field name="inherit_id" ref="analytic.view_account_analytic_account_form" />
+        <field
+            name="groups_id"
+            eval="[(4, ref('stock_request.group_stock_request_user'))]"
+        />
         <field name="arch" type="xml">
             <xpath expr="//div[@name='button_box']" position="inside">
                 <field name="stock_request_ids" invisible="1" />
diff --git a/stock_request_analytic/views/stock_request_order_views.xml b/stock_request_analytic/views/stock_request_order_views.xml
index c497290ed..02387d50b 100644
--- a/stock_request_analytic/views/stock_request_order_views.xml
+++ b/stock_request_analytic/views/stock_request_order_views.xml
@@ -6,6 +6,10 @@
         <field name="name">stock.request.order.form - stock_request_analytic</field>
         <field name="model">stock.request.order</field>
         <field name="inherit_id" ref="stock_request.stock_request_order_form" />
+        <field
+            name="groups_id"
+            eval="[(4, ref('analytic.group_analytic_accounting')),(4, ref('analytic.group_analytic_tags'))]"
+        />
         <field name="arch" type="xml">
             <div name="button_box" position="inside">
                 <field name="analytic_account_ids" invisible="1" />
@@ -23,6 +27,7 @@
                         name="analytic_count"
                         widget="statinfo"
                         string="Analytic Accounts"
+                        groups="analytic.group_analytic_accounting"
                     />
                 </button>
                 <button
@@ -38,6 +43,7 @@
                         name="analytic_tag_count"
                         widget="statinfo"
                         string="Analytic Tags"
+                        groups="analytic.group_analytic_tags"
                     />
                 </button>
             </div>
diff --git a/stock_request_analytic/views/stock_request_views.xml b/stock_request_analytic/views/stock_request_views.xml
index 4e3b124f2..450af245e 100644
--- a/stock_request_analytic/views/stock_request_views.xml
+++ b/stock_request_analytic/views/stock_request_views.xml
@@ -6,6 +6,10 @@
         <field name="name">stock.request.form</field>
         <field name="model">stock.request</field>
         <field name="inherit_id" ref="stock_request.view_stock_request_form" />
+        <field
+            name="groups_id"
+            eval="[(4, ref('analytic.group_analytic_accounting')),(4, ref('analytic.group_analytic_tags'))]"
+        />
         <field name="arch" type="xml">
             <field name="procurement_group_id" position="after">
                 <field