From 9fc8922b22210529a4ed9400a4c6d93f6d29dd78 Mon Sep 17 00:00:00 2001 From: sergio-teruel Date: Tue, 3 Nov 2020 20:02:27 +0100 Subject: [PATCH] [IMP] stock_secondary_unit: Remove unnecessary code. Always compute as field. TT26606 --- stock_secondary_unit/__manifest__.py | 2 +- stock_secondary_unit/models/product.py | 11 ++--------- stock_secondary_unit/views/product_views.xml | 2 +- 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/stock_secondary_unit/__manifest__.py b/stock_secondary_unit/__manifest__.py index b6a1d41ef..1f1cde1f4 100644 --- a/stock_secondary_unit/__manifest__.py +++ b/stock_secondary_unit/__manifest__.py @@ -3,7 +3,7 @@ { "name": "Stock Secondary Unit", "summary": "Get product quantities in a secondary unit", - "version": "13.0.1.0.1", + "version": "13.0.1.1.0", "development_status": "Production/Stable", "category": "stock", "website": "https://github.com/OCA/stock-logistics-warehouse", diff --git a/stock_secondary_unit/models/product.py b/stock_secondary_unit/models/product.py index 25b35cb84..2387b48a0 100644 --- a/stock_secondary_unit/models/product.py +++ b/stock_secondary_unit/models/product.py @@ -1,6 +1,6 @@ # Copyright 2018 Tecnativa - Sergio Teruel # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). -from odoo import fields, models +from odoo import api, fields, models from odoo.tools.float_utils import float_round @@ -14,6 +14,7 @@ class StockProductSecondaryUnit(models.AbstractModel): digits="Product Unit of Measure", ) + @api.depends("stock_secondary_uom_id") def _compute_secondary_unit_qty_available(self): for product in self: if not product.stock_secondary_uom_id: @@ -35,15 +36,7 @@ class ProductTemplate(models.Model): comodel_name="product.secondary.unit", string="Second unit for inventory" ) - def _compute_quantities(self): - super()._compute_quantities() - self._compute_secondary_unit_qty_available() - class ProductProduct(models.Model): _inherit = ["product.product", "stock.product.secondary.unit"] _name = "product.product" - - def _compute_quantities(self): - super()._compute_quantities() - self._compute_secondary_unit_qty_available() diff --git a/stock_secondary_unit/views/product_views.xml b/stock_secondary_unit/views/product_views.xml index ed014853d..98c89b539 100644 --- a/stock_secondary_unit/views/product_views.xml +++ b/stock_secondary_unit/views/product_views.xml @@ -44,7 +44,7 @@ /> - +