From 88026b977811e23b57b9b1f9b86fef6a86eb596d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Mart=C3=ADnez?= Date: Fri, 17 May 2024 12:14:27 +0200 Subject: [PATCH] [FIX] stock_reserve: Set the correct _default_picking_type_id value Do not use a fixed value because it will not be compatible with multi-company. TT49168 --- stock_reserve/models/stock_reserve.py | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/stock_reserve/models/stock_reserve.py b/stock_reserve/models/stock_reserve.py index 9edcaaf1d..ec81a90a4 100644 --- a/stock_reserve/models/stock_reserve.py +++ b/stock_reserve/models/stock_reserve.py @@ -77,7 +77,17 @@ class StockReservation(models.Model): # If picking_type_id is present and location_id is not, try to find # default value for location_id if not res.get("picking_type_id", None): - res["picking_type_id"] = self._default_picking_type_id() + res["picking_type_id"] = ( + self.env["stock.picking.type"] + .search( + [ + ("code", "=", "outgoing"), + ("company_id", "=", res.get("company_id")), + ], + limit=1, + ) + .id + ) picking_type_id = res.get("picking_type_id") if picking_type_id and not res.get("location_id", False): @@ -105,11 +115,6 @@ class StockReservation(models.Model): location_id = False return location_id - @api.model - def _default_picking_type_id(self): - ref = "stock.picking_type_out" - return self.env.ref(ref, raise_if_not_found=False).id - @api.model def _default_location_dest_id(self): ref = "stock_reserve.stock_location_reservation"