From 7ba8cd18986a5f8d00d1d40d4ec2c7d85a481795 Mon Sep 17 00:00:00 2001
From: Nils Hamerlinck <nils@trobz.com>
Date: Fri, 24 Sep 2021 21:11:48 +0700
Subject: [PATCH] [FIX] stock_request: default value should not depend on
 another field

---
 stock_request/models/stock_request.py | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/stock_request/models/stock_request.py b/stock_request/models/stock_request.py
index 461d063de..34c1f84d5 100644
--- a/stock_request/models/stock_request.py
+++ b/stock_request/models/stock_request.py
@@ -32,13 +32,6 @@ class StockRequest(models.Model):
     def _get_expected_date():
         return fields.Datetime.now()
 
-    def _get_default_expected_date(self):
-        if self.order_id:
-            res = self.order_id.expected_date
-        else:
-            res = self._get_expected_date()
-        return res
-
     name = fields.Char(states={"draft": [("readonly", False)]})
     state = fields.Selection(
         selection=_get_request_states,
@@ -58,7 +51,6 @@ class StockRequest(models.Model):
     )
     expected_date = fields.Datetime(
         "Expected Date",
-        default=lambda s: s._get_default_expected_date(),
         index=True,
         required=True,
         readonly=True,
@@ -371,6 +363,11 @@ class StockRequest(models.Model):
         upd_vals = vals.copy()
         if upd_vals.get("name", "/") == "/":
             upd_vals["name"] = self.env["ir.sequence"].next_by_code("stock.request")
+        if "order_id" in upd_vals:
+            order_id = self.env["stock.request.order"].browse(upd_vals["order_id"])
+            upd_vals["expected_date"] = order_id.expected_date
+        else:
+            upd_vals["expected_date"] = self._get_expected_date()
         return super().create(upd_vals)
 
     def unlink(self):