From 7b19603608f276e76df7ef99aeba8b0db627ded3 Mon Sep 17 00:00:00 2001
From: Enric Tobella <etobella@creublanca.es>
Date: Mon, 15 Jul 2019 13:40:02 +0200
Subject: [PATCH] [FIX] stock_request_purchase: remove sudo

---
 stock_request_purchase/models/stock_request.py             | 2 +-
 stock_request_purchase/models/stock_request_order.py       | 2 +-
 stock_request_purchase/views/purchase_order_views.xml      | 5 +++--
 stock_request_purchase/views/stock_request_order_views.xml | 3 ++-
 stock_request_purchase/views/stock_request_views.xml       | 4 ++--
 5 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/stock_request_purchase/models/stock_request.py b/stock_request_purchase/models/stock_request.py
index b162cf1e6..a3c58888f 100644
--- a/stock_request_purchase/models/stock_request.py
+++ b/stock_request_purchase/models/stock_request.py
@@ -20,7 +20,7 @@ class StockRequest(models.Model):
 
     @api.depends('purchase_line_ids')
     def _compute_purchase_ids(self):
-        for request in self.sudo():
+        for request in self:
             request.purchase_ids = request.purchase_line_ids.mapped('order_id')
             request.purchase_count = len(request.purchase_ids)
 
diff --git a/stock_request_purchase/models/stock_request_order.py b/stock_request_purchase/models/stock_request_order.py
index c752e77d1..74fc25122 100644
--- a/stock_request_purchase/models/stock_request_order.py
+++ b/stock_request_purchase/models/stock_request_order.py
@@ -20,7 +20,7 @@ class StockRequestOrder(models.Model):
 
     @api.depends('stock_request_ids')
     def _compute_purchase_ids(self):
-        for req in self.sudo():
+        for req in self:
             req.purchase_ids = req.stock_request_ids.mapped('purchase_ids')
             req.purchase_line_ids = req.stock_request_ids.mapped(
                 'purchase_line_ids')
diff --git a/stock_request_purchase/views/purchase_order_views.xml b/stock_request_purchase/views/purchase_order_views.xml
index 9a64dcf35..1c088548b 100644
--- a/stock_request_purchase/views/purchase_order_views.xml
+++ b/stock_request_purchase/views/purchase_order_views.xml
@@ -6,6 +6,7 @@
         <field name="name">purchase.order.form</field>
         <field name="model">purchase.order</field>
         <field name="inherit_id" ref="purchase.purchase_order_form"/>
+        <field name="groups_id" eval="[(4, ref('stock_request.group_stock_request_user'))]"/>
         <field name="arch" type="xml">
             <xpath expr="//div[@name='button_box']" position="inside">
                 <button type="object"
@@ -20,8 +21,7 @@
             </xpath>
             <xpath expr="//field[@name='order_line']/form/sheet/notebook"
                    position="inside">
-                <page name="stock_requests" string="Stock Requests"
-                      groups="stock_request.group_stock_request_user">
+                <page name="stock_requests" string="Stock Requests">
                     <field name="stock_request_ids"/>
                 </page>
             </xpath>
@@ -32,6 +32,7 @@
         <field name="name">purchase.order.line.form2</field>
         <field name="model">purchase.order.line</field>
         <field name="inherit_id" ref="purchase.purchase_order_line_form2"/>
+        <field name="groups_id" eval="[(4, ref('stock_request.group_stock_request_user'))]"/>
         <field name="arch" type="xml">
             <field name="name" position="after">
                 <separator string="Stock Requests"/>
diff --git a/stock_request_purchase/views/stock_request_order_views.xml b/stock_request_purchase/views/stock_request_order_views.xml
index 64f870686..a8c3e8776 100644
--- a/stock_request_purchase/views/stock_request_order_views.xml
+++ b/stock_request_purchase/views/stock_request_order_views.xml
@@ -7,6 +7,7 @@
         <field name="name">stock.request.order.form</field>
         <field name="model">stock.request.order</field>
         <field name="inherit_id" ref="stock_request.stock_request_order_form"/>
+        <field name="groups_id" eval="[(4, ref('purchase.group_purchase_user'))]"/>
         <field name="arch" type="xml">
             <div name="button_box" position="inside">
                 <field name="purchase_ids" invisible="1"/>
@@ -15,7 +16,7 @@
                     class="oe_stat_button"
                     icon="fa-truck"
                     attrs="{'invisible': [('purchase_count', '=', 0)]}"
-                        groups="purchase.group_purchase_user">
+                        >
                     <field name="purchase_count" widget="statinfo"
                            string="Purchase"/>
                 </button>
diff --git a/stock_request_purchase/views/stock_request_views.xml b/stock_request_purchase/views/stock_request_views.xml
index a8a62e400..00704ffac 100644
--- a/stock_request_purchase/views/stock_request_views.xml
+++ b/stock_request_purchase/views/stock_request_views.xml
@@ -7,6 +7,7 @@
         <field name="name">stock.request.form</field>
         <field name="model">stock.request</field>
         <field name="inherit_id" ref="stock_request.view_stock_request_form"/>
+        <field name="groups_id" eval="[(4, ref('purchase.group_purchase_user'))]"/>
         <field name="arch" type="xml">
             <div name="button_box" position="inside">
                 <field name="purchase_ids" invisible="1"/>
@@ -14,8 +15,7 @@
                     name="action_view_purchase"
                     class="oe_stat_button"
                     icon="fa-truck"
-                    attrs="{'invisible': [('purchase_count', '=', 0)]}"
-                        groups="purchase.group_purchase_user">
+                    attrs="{'invisible': [('purchase_count', '=', 0)]}">
                     <field name="purchase_count" widget="statinfo"
                            string="Purchase"/>
                 </button>