From 679b2a2c6dde9353ac6fc8c7aadf41dcc57491ff Mon Sep 17 00:00:00 2001 From: "Pedro M. Baeza" Date: Fri, 31 Mar 2017 10:32:38 +0200 Subject: [PATCH] [FIX] stock_mts_mto_rule: Don't fail on renaming WH code There's a traceback when renaming warehouse code (without renaming warehouse name), as name argument is False. --- stock_mts_mto_rule/model/warehouse.py | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/stock_mts_mto_rule/model/warehouse.py b/stock_mts_mto_rule/model/warehouse.py index 7b30aad84..20105f700 100644 --- a/stock_mts_mto_rule/model/warehouse.py +++ b/stock_mts_mto_rule/model/warehouse.py @@ -129,13 +129,14 @@ class Warehouse(models.Model): @api.multi def _update_name_and_code(self, name, code): res = super(Warehouse, self)._update_name_and_code(name, code) - - for warehouse in self: - if warehouse.mts_mto_rule_id: - warehouse.mts_mto_rule_id.name = ( - warehouse.mts_mto_rule_id.name.replace( - warehouse.name, name, 1) + if not name: + return res + for warehouse in self.filtered('mts_mto_rule_id'): + warehouse.mts_mto_rule_id.name = ( + warehouse.mts_mto_rule_id.name.replace( + warehouse.name, name, 1, ) + ) return res def _get_route_name(self, route_type):