From 65ba22cb6ff24750bd390438ea4f12f3b85c08fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Fri, 23 Apr 2021 15:39:27 +0200
Subject: [PATCH 1/6] Zippcube measure update

When the measure update is call from somewhere else than the
device wizard, an exception is raised.
---
 .../components/zippcube_device_component.py                  | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/stock_measuring_device_zippcube/components/zippcube_device_component.py b/stock_measuring_device_zippcube/components/zippcube_device_component.py
index 4c009d41b..6e759412f 100644
--- a/stock_measuring_device_zippcube/components/zippcube_device_component.py
+++ b/stock_measuring_device_zippcube/components/zippcube_device_component.py
@@ -35,5 +35,8 @@ class ZippcubeDevice(Component):
         }
 
     def post_update_packaging_measures(self, measures, packaging, wizard_line):
-        wizard_line.wizard_id._notify(_("Please, press the REFRESH button."))
+        # wizard_line is only set when measurements are made from the measurement
+        # device wizard.
+        if wizard_line:
+            wizard_line.wizard_id._notify(_("Please, press the REFRESH button."))
         packaging._measuring_device_release()

From e8b6914cfeca5ffa252ae28294cbc6a3ee113c79 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Tue, 27 Apr 2021 16:16:58 +0200
Subject: [PATCH 2/6] stock_measuring_device: Only create or update packages
 that have been measured

---
 stock_measuring_device/models/measuring_device.py      | 2 +-
 stock_measuring_device/wizard/measuring_wizard.py      | 2 ++
 stock_measuring_device/wizard/measuring_wizard_line.py | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/stock_measuring_device/models/measuring_device.py b/stock_measuring_device/models/measuring_device.py
index 1ba9b6ed9..93cb0b9d1 100644
--- a/stock_measuring_device/models/measuring_device.py
+++ b/stock_measuring_device/models/measuring_device.py
@@ -87,7 +87,7 @@ class MeasuringDevice(models.Model):
             _logger.warning("No wizard line found for this measure.")
             packaging.write(measures)
         else:
-            measures.update({"scan_requested": False})
+            measures.update({"scan_requested": False, "is_measured": True})
             wizard_line.write(measures)
 
         self._get_measuring_device().post_update_packaging_measures(
diff --git a/stock_measuring_device/wizard/measuring_wizard.py b/stock_measuring_device/wizard/measuring_wizard.py
index f06837fb1..43cb68b10 100644
--- a/stock_measuring_device/wizard/measuring_wizard.py
+++ b/stock_measuring_device/wizard/measuring_wizard.py
@@ -111,6 +111,8 @@ class MeasuringWizard(models.TransientModel):
         packaging_ids_list = []
         for line in self.line_ids:
             packaging_type = line.packaging_type_id
+            if not line.is_measured:
+                continue
             if packaging_type:
                 # Handle lines with packaging
                 vals = {
diff --git a/stock_measuring_device/wizard/measuring_wizard_line.py b/stock_measuring_device/wizard/measuring_wizard_line.py
index 3e3a9d5f2..18e66d0ef 100644
--- a/stock_measuring_device/wizard/measuring_wizard_line.py
+++ b/stock_measuring_device/wizard/measuring_wizard_line.py
@@ -33,6 +33,7 @@ class MeasuringWizardLine(models.TransientModel):
     packaging_type_id = fields.Many2one("product.packaging.type", readonly=True)
     is_unit_line = fields.Boolean(readonly=True)
     required = fields.Boolean(related="packaging_type_id.required", readonly=True)
+    is_measured = fields.Boolean()
 
     @api.depends("lngth", "width", "height")
     def _compute_volume(self):

From b072a3b12ae2f944458921b367a3971b0c77d978 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Wed, 28 Apr 2021 13:07:01 +0200
Subject: [PATCH 3/6] stock_measuring_device: Allow to auto-refresh the
 measuring wizard.

---
 stock_measuring_device/__manifest__.py        |  2 +-
 .../static/src/js/measuring_wizard.js         | 62 +++++++++++++++++++
 stock_measuring_device/views/assets.xml       |  4 ++
 .../wizard/measuring_wizard.py                | 14 +++++
 4 files changed, 81 insertions(+), 1 deletion(-)
 create mode 100644 stock_measuring_device/static/src/js/measuring_wizard.js

diff --git a/stock_measuring_device/__manifest__.py b/stock_measuring_device/__manifest__.py
index d5be9ba5e..e7e43e589 100644
--- a/stock_measuring_device/__manifest__.py
+++ b/stock_measuring_device/__manifest__.py
@@ -15,7 +15,7 @@
         "product_packaging_dimension",
         "product_packaging_type_required",
         "product_dimension",
-        # For the pop-up message to tell the user to refresh.
+        # To refresh wizard screen or pop-up message on the wizard
         "web_notify",
         "web_ir_actions_act_view_reload",
     ],
diff --git a/stock_measuring_device/static/src/js/measuring_wizard.js b/stock_measuring_device/static/src/js/measuring_wizard.js
new file mode 100644
index 000000000..766e6ac7f
--- /dev/null
+++ b/stock_measuring_device/static/src/js/measuring_wizard.js
@@ -0,0 +1,62 @@
+odoo.define("stock_measuring_device.measuring_wizard", function(require) {
+    "use strict";
+
+    var FormController = require("web.FormController");
+
+    FormController.include({
+        init: function() {
+            this._super.apply(this, arguments);
+            if (this.modelName === "measuring.wizard") {
+                this.call(
+                    "bus_service",
+                    "addChannel",
+                    "notify_measuring_wizard_screen"
+                );
+                this.call(
+                    "bus_service",
+                    "on",
+                    "notification",
+                    this,
+                    this.measuring_wizard_bus_notification
+                );
+                this.call("bus_service", "startPolling");
+            }
+        },
+        measuring_wizard_bus_notification: function(notifications) {
+            var self = this;
+            _.each(notifications, function(notification) {
+                var channel = notification[0];
+                var message = notification[1];
+                if (channel === "notify_measuring_wizard_screen") {
+                    switch (message.action) {
+                        case "refresh":
+                            self.measuring_wizard_bus_action_refresh(message.params);
+                            break;
+                    }
+                }
+            });
+        },
+        measuring_wizard_bus_action_refresh: function(params) {
+            var selectedIds = this.getSelectedIds();
+            if (!selectedIds.length) {
+                return;
+            }
+            var currentId = selectedIds[0];
+            if (params.id === currentId && params.model === this.modelName) {
+                this.reload();
+            }
+        },
+        destroy: function() {
+            if (this.modelName === "measuring.wizard") {
+                this.call(
+                    "bus_service",
+                    "deleteChannel",
+                    "notify_measuring_wizard_screen"
+                );
+            }
+            this._super.apply(this, arguments);
+        },
+    });
+
+    return {};
+});
diff --git a/stock_measuring_device/views/assets.xml b/stock_measuring_device/views/assets.xml
index de7d8fba5..8be276756 100644
--- a/stock_measuring_device/views/assets.xml
+++ b/stock_measuring_device/views/assets.xml
@@ -11,6 +11,10 @@
                 type="text/scss"
                 href="/stock_measuring_device/static/src/scss/measuring_wizard.scss"
             />
+            <script
+                type="text/javascript"
+                src="/stock_measuring_device/static/src/js/measuring_wizard.js"
+            />
         </xpath>
     </template>
 </odoo>
diff --git a/stock_measuring_device/wizard/measuring_wizard.py b/stock_measuring_device/wizard/measuring_wizard.py
index 43cb68b10..addcd6e3c 100644
--- a/stock_measuring_device/wizard/measuring_wizard.py
+++ b/stock_measuring_device/wizard/measuring_wizard.py
@@ -165,6 +165,20 @@ class MeasuringWizard(models.TransientModel):
             "type": "ir.actions.act_view_reload",
         }
 
+    def _send_notification_refresh(self):
+        """Send a refresh notification on the wizard.
+        Other notifications can be implemented, they have to be
+        added in static/src/js/measuring_wizard.js and the message
+        must contain an "action" and "params".
+        """
+        self.ensure_one()
+        channel = "notify_measuring_wizard_screen"
+        bus_message = {
+            "action": "refresh",
+            "params": {"model": self._name, "id": self.id},
+        }
+        self.env["bus.bus"].sendone(channel, bus_message)
+
     def _notify(self, message):
         """Show a gentle notification on the wizard
 

From 19381a102fb31b6db1038b53469c9fb174c13d3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Wed, 28 Apr 2021 13:14:27 +0200
Subject: [PATCH 4/6] stock_measuring_device: Auto-refresh zipcube wiz when
 measurement is done

---
 .../static/src/js/measuring_wizard.js                  | 10 ++++------
 stock_measuring_device/wizard/measuring_wizard.py      |  1 +
 .../components/zippcube_device_component.py            |  4 +---
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/stock_measuring_device/static/src/js/measuring_wizard.js b/stock_measuring_device/static/src/js/measuring_wizard.js
index 766e6ac7f..bd9fc40c4 100644
--- a/stock_measuring_device/static/src/js/measuring_wizard.js
+++ b/stock_measuring_device/static/src/js/measuring_wizard.js
@@ -28,21 +28,19 @@ odoo.define("stock_measuring_device.measuring_wizard", function(require) {
                 var channel = notification[0];
                 var message = notification[1];
                 if (channel === "notify_measuring_wizard_screen") {
-                    switch (message.action) {
-                        case "refresh":
-                            self.measuring_wizard_bus_action_refresh(message.params);
-                            break;
+                    if (message.action === "refresh") {
+                        self.measuring_wizard_bus_action_refresh(message.params);
                     }
                 }
             });
         },
         measuring_wizard_bus_action_refresh: function(params) {
             var selectedIds = this.getSelectedIds();
-            if (!selectedIds.length) {
+            if (!selectedIds.length || params.model !== this.modelName) {
                 return;
             }
             var currentId = selectedIds[0];
-            if (params.id === currentId && params.model === this.modelName) {
+            if (params.id === currentId) {
                 this.reload();
             }
         },
diff --git a/stock_measuring_device/wizard/measuring_wizard.py b/stock_measuring_device/wizard/measuring_wizard.py
index addcd6e3c..2ee9bd709 100644
--- a/stock_measuring_device/wizard/measuring_wizard.py
+++ b/stock_measuring_device/wizard/measuring_wizard.py
@@ -167,6 +167,7 @@ class MeasuringWizard(models.TransientModel):
 
     def _send_notification_refresh(self):
         """Send a refresh notification on the wizard.
+
         Other notifications can be implemented, they have to be
         added in static/src/js/measuring_wizard.js and the message
         must contain an "action" and "params".
diff --git a/stock_measuring_device_zippcube/components/zippcube_device_component.py b/stock_measuring_device_zippcube/components/zippcube_device_component.py
index 6e759412f..44520b34e 100644
--- a/stock_measuring_device_zippcube/components/zippcube_device_component.py
+++ b/stock_measuring_device_zippcube/components/zippcube_device_component.py
@@ -3,8 +3,6 @@
 
 import logging
 
-from odoo import _
-
 from odoo.addons.component.core import Component
 
 _logger = logging.getLogger(__name__)
@@ -38,5 +36,5 @@ class ZippcubeDevice(Component):
         # wizard_line is only set when measurements are made from the measurement
         # device wizard.
         if wizard_line:
-            wizard_line.wizard_id._notify(_("Please, press the REFRESH button."))
+            wizard_line.wizard_id._send_notification_refresh()
         packaging._measuring_device_release()

From 00d027bc96e4a66c54c10ca0eb63c225dd69d0c8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Wed, 28 Apr 2021 14:34:27 +0200
Subject: [PATCH 5/6] stock_measuring_device: Retrieve product when device is
 already assigned

---
 stock_measuring_device/models/measuring_device.py  |  8 +++++++-
 stock_measuring_device/models/product_packaging.py |  1 +
 stock_measuring_device/wizard/measuring_wizard.py  | 10 ++++++++++
 stock_measuring_device/wizard/measuring_wizard.xml |  6 ++++++
 4 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/stock_measuring_device/models/measuring_device.py b/stock_measuring_device/models/measuring_device.py
index 93cb0b9d1..f23875954 100644
--- a/stock_measuring_device/models/measuring_device.py
+++ b/stock_measuring_device/models/measuring_device.py
@@ -40,7 +40,7 @@ class MeasuringDevice(models.Model):
             return work_ctx.component(usage=self.device_type)
 
     def open_wizard(self):
-        return {
+        res = {
             "name": _("Measurement Wizard"),
             "res_model": "measuring.wizard",
             "type": "ir.actions.act_window",
@@ -54,6 +54,12 @@ class MeasuringDevice(models.Model):
                 "no_breadcrumbs": True,
             },
         }
+        if self._is_being_used():
+            pack = self.env["product.packaging"].search(
+                [("measuring_device_id", "=", self.id)], limit=1
+            )
+            res["context"]["default_product_id"] = pack.product_id.id
+        return res
 
     def _is_being_used(self):
         self.ensure_one()
diff --git a/stock_measuring_device/models/product_packaging.py b/stock_measuring_device/models/product_packaging.py
index 2f7aa612c..753a029e2 100644
--- a/stock_measuring_device/models/product_packaging.py
+++ b/stock_measuring_device/models/product_packaging.py
@@ -16,6 +16,7 @@ class ProductPackaging(models.Model):
         string="Measuring device which will scan the package",
         help="Technical field set when an operator uses the device "
         "to scan this package",
+        index=True,
     )
 
     def _measuring_device_assign(self, device):
diff --git a/stock_measuring_device/wizard/measuring_wizard.py b/stock_measuring_device/wizard/measuring_wizard.py
index 2ee9bd709..f4cf664ed 100644
--- a/stock_measuring_device/wizard/measuring_wizard.py
+++ b/stock_measuring_device/wizard/measuring_wizard.py
@@ -89,6 +89,7 @@ class MeasuringWizard(models.TransientModel):
                         "barcode": pack.barcode,
                         "packaging_id": pack.id,
                         "packaging_type_id": pack_type.id,
+                        "scan_requested": bool(pack.measuring_device_id),
                     }
                 )
             vals_list.append(vals)
@@ -160,6 +161,15 @@ class MeasuringWizard(models.TransientModel):
             "flags": {"headless": False, "clear_breadcrumbs": True},
         }
 
+    def retrieve_product(self):
+        """Assigns product that locks the device if a scan is already requested."""
+        if self.device_id._is_being_used():
+            pack = self.env["product.packaging"]._measuring_device_find_assigned(
+                self.device_id
+            )
+            self.product_id = pack.product_id
+            self.onchange_product_id()
+
     def reload(self):
         return {
             "type": "ir.actions.act_view_reload",
diff --git a/stock_measuring_device/wizard/measuring_wizard.xml b/stock_measuring_device/wizard/measuring_wizard.xml
index 41b29509c..a3b248c28 100644
--- a/stock_measuring_device/wizard/measuring_wizard.xml
+++ b/stock_measuring_device/wizard/measuring_wizard.xml
@@ -37,6 +37,12 @@
                             string="Refresh"
                             icon="fa-refresh"
                         />
+                        <button
+                            name="retrieve_product"
+                            type="object"
+                            string="Retrieve Product"
+                            icon="fa-search"
+                        />
                     </group>
                     <group name="col2" />
                 </group>

From f3928f47fecdaba014ebdcfa34276f1b37f22edf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matthieu=20M=C3=A9quignon?=
 <matthieu.mequignon@camptocamp.com>
Date: Wed, 28 Apr 2021 14:45:15 +0200
Subject: [PATCH 6/6] stock_measuring_device: Release device before closing the
 wizard

---
 stock_measuring_device/wizard/measuring_wizard.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/stock_measuring_device/wizard/measuring_wizard.py b/stock_measuring_device/wizard/measuring_wizard.py
index f4cf664ed..e5aa6d489 100644
--- a/stock_measuring_device/wizard/measuring_wizard.py
+++ b/stock_measuring_device/wizard/measuring_wizard.py
@@ -151,7 +151,11 @@ class MeasuringWizard(models.TransientModel):
         self.onchange_product_id()
 
     def action_close(self):
-        self.ensure_one()
+        for line in self.line_ids:
+            if not line.scan_requested:
+                continue
+            line.packaging_id._measuring_device_release()
+            line.scan_requested = False
         return {
             "type": "ir.actions.act_window",
             "res_model": self.device_id._name,