From 5e13ae4c8746a79a07641b6d88c6a2219bd99c30 Mon Sep 17 00:00:00 2001
From: "Laurent Mignon (ACSONE)" <laurent.mignon@acsone.eu>
Date: Wed, 29 Mar 2023 17:03:06 +0200
Subject: [PATCH] [IMP] stock_picking_volume: Avoid useless recompute

Makes computed fields readonly in state 'done' or 'cancel' to avoid triggering recompute when these values are useless
---
 stock_picking_volume/models/stock_move.py    | 6 +++++-
 stock_picking_volume/models/stock_picking.py | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/stock_picking_volume/models/stock_move.py b/stock_picking_volume/models/stock_move.py
index 8bfce4aa7..f86b662a8 100644
--- a/stock_picking_volume/models/stock_move.py
+++ b/stock_picking_volume/models/stock_move.py
@@ -9,7 +9,11 @@ class StockMove(models.Model):
     _inherit = "stock.move"
 
     volume = fields.Float(
-        compute="_compute_volume", readonly=False, store=True, compute_sudo=True
+        compute="_compute_volume",
+        readonly=False,
+        store=True,
+        compute_sudo=True,
+        states={"done": [("readonly", True)], "cancel": [("readonly", True)]},
     )
 
     volume_uom_name = fields.Char(
diff --git a/stock_picking_volume/models/stock_picking.py b/stock_picking_volume/models/stock_picking.py
index 007df9cc7..483a1bde0 100644
--- a/stock_picking_volume/models/stock_picking.py
+++ b/stock_picking_volume/models/stock_picking.py
@@ -9,7 +9,11 @@ class StockPicking(models.Model):
     _inherit = "stock.picking"
 
     volume = fields.Float(
-        compute="_compute_volume", readonly=False, store=True, compute_sudo=True
+        compute="_compute_volume",
+        readonly=False,
+        store=True,
+        compute_sudo=True,
+        states={"done": [("readonly", True)], "cancel": [("readonly", True)]},
     )
     volume_uom_name = fields.Char(
         string="Volume unit of measure label", compute="_compute_volume_uom_name"